Handle multiple proposals in a view correctly in Tendermint #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majecty
force-pushed
the
f/assume-doublevote
branch
from
d448428 to
ce4d818
Compare
majecty
changed the title
foriequal0
requested changes
Sep 25, 2019
majecty
force-pushed
the
f/assume-doublevote
branch
from
ce4d818 to
e2dbe6b
Compare
foriequal0
requested changes
Sep 26, 2019
majecty
force-pushed
the
f/assume-doublevote
branch
from
e2dbe6b to
0c68995
Compare
foriequal0
requested changes
Sep 26, 2019
majecty
force-pushed
the
f/assume-doublevote
branch
from
27faf27 to
fd162f3
Compare
foriequal0
previously approved these changes
Sep 26, 2019
Previous code assumes that there is only one proposal in a view. Tendermint was always using the first proposal even though there are many proposals in a view. This commit makes Tendermint find proper proposal in the situation.
When there are multiple proposals, we want to use the first proposal consistently. To do that the order or votes should be consistent.
majecty
force-pushed
the
f/assume-doublevote
branch
from
fd162f3 to
1d7e06e
Compare
foriequal0
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code assumes that there is only one proposal in a
view. Tendermint was always using the first proposal even though there
are many proposals in a view. This commit makes Tendermint find the
proper proposal for that situation.
Fixes #1773