Skip to content

Cherry-pick] Set finalized_view to None when restoring in the Commit step #1866 #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

foriequal0
Copy link
Contributor

#1866 was a hotfix so it should be backported(?) to the master.

In the Tendermint restoring process, if the backup state is the Commit
step, CodeChain set the step to the Precommit step and handles the
votes. The purpose of the behavior is that calling functions that are
called when enters the Commit state.

After we introduce the `finalized_view_of_current_block` variable, the
variable should be changed to `None` when CodeChain sets the state to
Precommit in the restoring process.
@majecty
Copy link
Contributor

majecty commented Nov 18, 2019

@foriequal0 I added a new PR that fixes the same problem. Could you check it?
#1871

@foriequal0
Copy link
Contributor Author

We decided to drop and revert this from master & 2.2.1 and proceed the release with the new patch from @majecty

@majecty majecty closed this Nov 18, 2019
@foriequal0 foriequal0 deleted the fix-tendermint-restore branch November 19, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants