Fetch consistent state in mempool functions #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgkim126
reviewed
Jun 4, 2020
|
@junha1 I added you as a review since you were curious about the mempool bug. |
sgkim126
previously approved these changes
Jun 4, 2020
junha1
previously approved these changes
Jun 5, 2020
We found that mempool mis-calculates sequence in the TPS test. After fixing the mempool to read consistent state, mempool calculates sequence well.
majecty
force-pushed
the
f/fix-mempool-fetch-22x
branch
from
0b46762 to
ac066f3
Compare
sgkim126
approved these changes
Jun 8, 2020
junha1
approved these changes
Jun 8, 2020
|
The failed e2e test is "Shutdown test". Since it is not related to this PR, I'll merge this PR. Thanks. |
This was referenced Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that mempool mis-calculates sequence in the TPS test. After fixing the mempool to read consistent state, mempool calculates sequence well.