Add account remove command #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseo
requested changes
Jul 18, 2018
codechain/account_command.rs
Outdated
| @@ -111,3 +124,11 @@ fn read_password_and_confirm() -> Option<String> { | |||
| None | |||
| } | |||
| } | |||
|
|
|||
| fn parse_val(val: &str) -> &str { | |||
codechain/account_command.rs
Outdated
| let val = matches.value_of("address").expect("address arg is required"); | ||
| parse_val(val) | ||
| }; | ||
| match Address::from_str(key){ |
There was a problem hiding this comment.
Don't forget to run cargo fmt.
cargo +nightly-2018-05-07 fmt
There was a problem hiding this comment.
From today on, cargo +nightly-2018-07-17 fmt
codechain/codechain.yml
Outdated
| - remove: | ||
| about: remove account | ||
| args: | ||
| - address: |
There was a problem hiding this comment.
It's the convention to use UPPER_CASE for positional argument's name.
junbeomlee
force-pushed
the
account-remove-command
branch
from
99f7b36 to
db84d0e
Compare
|
I fixed it!! |
junbeomlee
force-pushed
the
account-remove-command
branch
3 times, most recently
from
b60083f to
7392d9f
Compare
junbeomlee
force-pushed
the
account-remove-command
branch
from
7392d9f to
1bb0877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#420