fix 'Open Quickly' fatal error #1793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
previously approved these changes
Jul 4, 2024
|
Do you want to wait for #1790 to be merged before merging this? I think there will be a conflict |
|
I think they can be merged in any order, there wasn't a modification in that part of NSTableViewWrapper in #1790. |
tom-ludwig
requested changes
Jul 4, 2024
CodeEdit/Features/QuickOpen/Extensions/Array+subscript_safe.swift
Outdated
Show resolved
Hide resolved
thecoolwinter
previously approved these changes
Jul 7, 2024
…ix-open-quickly-fatal-error
thecoolwinter
approved these changes
Jul 7, 2024
0xWDG
approved these changes
Jul 8, 2024
tom-ludwig
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents a fatal error from occurring when selecting and unselecting items in 'Open Quickly'.
Related Issues
Checklist
Screenshots
fix.open.quickly.fatal.error.mov