Skip to content

Conversation

thecoolwinter
Copy link
Contributor

Description

Fixes marked text input for sequences longer than one marked character. Also ensures marked text works consistently with multiple cursors and adds testing for the marked text functionality.

Also:

  • Fixes a few lint markers in test files that have caused issues for others.
  • Adds a public TextView.markedTextAttributes property for modifying the marked text attributes if desired.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-06-22.at.12.45.56.AM.mov

@RonghuaHe
Copy link

Hello, the previous issue is resolved, but now we have a new issue:when using Chinese or Japanese input method, input part of Chinese or Japanese, and then press the enter key, the text will be accidentally hidden.

@thecoolwinter
Copy link
Contributor Author

Hello, the previous issue is resolved, but now we have a new issue:when using Chinese or Japanese input method, input part of Chinese or Japanese, and then press the enter key, the text will be accidentally hidden.

I'll look into this again, thank you for bringing it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants