Bot revamp #8
Open
Bot revamp #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: daminokun <[email protected]>
Co-authored-by: daminokun <[email protected]>
…d8d-f1d050139087 Add automatic ADB connectivity checking with improved error handling
Added instructions for adding ADB to system PATH.
This script manages screenshots by limiting their count, generating new filenames, and saving screenshots from an Android device.
Refactor screenshot capturing logic to use screenshot_manager and handle exceptions.
Fix screenshot saving and update variable name.
Add return statement to save_new_screenshot function.
Fix indentation of the while loop in bot.py.
Corrected a comment regarding the screenshot_manager import.
Update condition to check forfeit action position range.
Add a step to inject Google Site Verification meta tag into HTML files.
Refactor image matching logic to prioritize best matches by confidence and filter results based on y-coordinate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to the bot's reliability, image matching, user experience, and documentation, especially around ADB (Android Debug Bridge) connectivity and usage. The highlights include robust ADB status checking, refactoring of ADB command execution, enhanced documentation for Windows users, and improved bot logic for image matching and tapping. These changes make the bot easier to set up and less error-prone, especially for new users.
ADB Connectivity Improvements
src/adb_checker.pywith functions to check ADB installation, connected devices, and device communication, including comprehensive status messages and a device wait loop. This allows the bot to verify ADB readiness before running, reducing setup errors.src/adb_commands.pyto usesubprocess.runfor all ADB commands (tap, keyevent, screen off), with proper error handling and logging for failures/timeouts, improving reliability and debuggability.Bot Logic and Usability
src/bot.pyto support skipping ADB checks (for advanced users), implemented frame-skipping via screenshot hashes to avoid redundant actions, and improved image matching/tapping logic to select the best match with y > 296. [1] [2]Documentation and User Guidance
README.mdwith detailed Windows setup instructions for adding ADB to PATH, clarified bot startup and connectivity requirements, described new command-line options (--skip-adb-check), and provided updated output examples and troubleshooting tips. [1] [2]Platform Tools and CI
platform-tools/mke2fs.conf,platform-tools/source.properties) and a GitHub Actions workflow for deploying the Jekyll site to GitHub Pages, including Google site verification. [1] [2] [3]These changes collectively improve the bot's robustness, make setup easier for new users, and add advanced options for experienced users.