London | Ameneh Keshavarz | Module Legacy Code | WEEK 1 | Extra long blooms #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ameneh-Keshavarz
added
the
Needs Review
Ameneh-Keshavarz
force-pushed
the
extra-long-blooms
branch
2 times, most recently
from
1275097 to
c0add7d
Compare
illicitonion
added
Complete
There was a problem hiding this comment.
Perfect, well done!
Good job particularly covering this at multiple levels - making sure the DB enforces the constraint, making sure the backend enforces it, and making sure the frontend discourages legitimate users from accidentally bypassing it and hitting the backend with a request which is going to be rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.