Skip to content

fix: example for ResponsiveWrapper class in README #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

fix: example for ResponsiveWrapper class in README #96

merged 1 commit into from
May 12, 2022

Conversation

Guo-Zhang
Copy link
Contributor

The exmaple for ResponsiveWrapper class in README has two small problems:

  1. It doesn't load the package, which may confuse some new learners.
  2. (context, widget) => ...(child), the params don't match, which also confuse me for a while.

README is quiet important for new users to know about that.

Hope it helps! I am willing to contribute on this project.

@rayliverified
Copy link
Contributor

Nice catch! This should help make it easier for people to get started!

@rayliverified rayliverified merged commit 39e74b2 into Codelessly:master May 12, 2022
@rainteen rainteen mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guo-Zhang @rayliverified