Skip to content

Conversation

n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Aug 26, 2022

See https://github.com/Codex-/cosmiconfig-typescript-loader/issues/36

This PR is built on top of https://github.com/Codex-/cosmiconfig-typescript-loader/pull/38 and show-cases how the import/require behavior is consistent on both platforms when switching from default imports to named imports.

See https://github.com/n1ru4l/cosmiconfig-typescript-loader/runs/8034633946 for a passing build

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #37 (a9f88de) into main (415618e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           25        24    -1     
  Branches         2         2           
=========================================
- Hits            25        24    -1     
Impacted Files Coverage Δ
lib/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Aug 26, 2022

@Codex- I pushed a commit for solving the eslint issues: 3e9aa4d

I need approval for running the tests!

@Codex-
Copy link
Owner

Codex- commented Aug 26, 2022

No problem, I can take it from here :)

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Aug 26, 2022

@Codex- Thank you for your quick response and actions ❤️

@Codex-
Copy link
Owner

Codex- commented Aug 26, 2022

No problem, always happy to help out where I can :)

Copy link
Owner

@Codex- Codex- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

@Codex- Codex- merged commit 9b9a9bd into Codex-:main Aug 26, 2022
@n1ru4l n1ru4l deleted the named-export branch August 26, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants