Add ESM support #96
Closed
Add ESM support #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for addressing this! 🙌 |
darkobits
reviewed
Jun 18, 2023
lib/loader.ts
Outdated
| export function TypeScriptLoader(options?: RegisterOptions): Loader { | ||
| const tsNodeInstance = register({ | ||
| ...options, | ||
| compilerOptions: { module: "commonjs" }, |
There was a problem hiding this comment.
FYI as of version 8.2.0, Cosmiconfig no longer requires transpiled configuration to be CJS; they now accept pure ESM configuration files when using the asynchronous API.
There was a problem hiding this comment.
yeah haven't had another chance yet to finish this off, this and the usage of require/import might need some changes during compilation to generate the appropriate sources
There was a problem hiding this comment.
@darkobits if you get a chance, this branch is now ready for testing :)
Repository owner
deleted a comment from
codecov-commenter
Jul 24, 2023
|
Closed in favour of #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.