Added tanh activation and a way to switch between different functions #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When testing with the xor..... it is a little sensitive to the learning rate...... |
shiffman
requested changes
Feb 11, 2018
lib/nn.js
Outdated
|
|
||
| setDActivationFunction(dFun = dsigmoid) { | ||
| this.d_activation_function = dFun; | ||
| setActivationFunction(Fun = 'sigmoid') { |
There was a problem hiding this comment.
Would you mind using func instead of Fun?
lib/nn.js
Outdated
| return Math.tanh(x); | ||
| } | ||
| function dtanh(x) { | ||
| return 1-(tanh(x)*tanh(x)); |
There was a problem hiding this comment.
Since the output of a node has already been passed through tanh() I believe this would be (1-y*y)? (The convention I'm using to note this is y instead of x. Am I mistaken about this?
lib/nn.js
Outdated
| } | ||
|
|
||
| function tanh(x) { | ||
| return Math.tanh(x); |
There was a problem hiding this comment.
Would you mind conforming to the 2 space indentation?
|
Made changes and fixed a confilict |
|
this seems to be covered on PR #62... |
|
Yes indeed, apologies @schrummy14 but I just couldn't resist the object-oriented solution. |
|
That is fine. It will allow for a cleaner solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed function so user does not have to choose both the correct activation function with the correct derivative of the activation function