-
Notifications
You must be signed in to change notification settings - Fork 121
Rough draft of showcase page #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for codingtrain ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@klinegareth @shiffman Alright - got the showcase page in a working state with a few improvements, we're back on track! It's nice to see the community contributions all in one place. You can keep iterating on the page. Let me know if you need anything or have any questions. https://deploy-preview-638--codingtrain.netlify.app/showcase We now have to build 12,054 pages compared to 6,686 in the last production build. It's still manageable, but I think we'll eventually have to explore some new ideas (SSR, client-side pagination and filtering) to make the build and dev server startup times more reasonable. |
I will also add that the language filter as currently implemented doesn't make too much sense. It refers to technologies used in the Coding Train video that inspired the contribution, and not the contribution itself. |
Yes, I think we can do away with the filters. If I were to have filters what would be useful is:
I love the idea of being to see all showcase projects by any given passenger. I could also imagine wanting to sort in reverse chronological order but that is very low priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two things that I think are worth watching out for.
Wow, amazing! Thank you @fturmel! I love the filtering by author so much. I think that's really the only filter we need since to see the showcase projects for any given video I can just click over to the video page. We are so close to merging yay! |
With @klinegareth's latest commit I think this is ready to merge!!! Wowza!!! https://deploy-preview-638--codingtrain.netlify.app/showcase I'm updating this with main and marking ready for review! I may do a couple final language tweaks. Any last comments or thoughts before I merge from anyone following? I think we can make some refinements going forward:
We can open a new issue to track! |
@shiffman Looks good to me, and I agree with the refinement ideas. I would add that we might want a "browse showcase" button on the homepage, just like tracks and challenges. |
Oh and we haven't resolved the homepage JSON with two CTA comment I left before. Would be nice to fix before we merge and just forget. |
@shiffman Perfect! |
Here we gooooooooooooooo! |
No description provided.