Skip to content

Rough draft of showcase page #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 21, 2023
Merged

Rough draft of showcase page #638

merged 31 commits into from
Feb 21, 2023

Conversation

augustkline
Copy link
Collaborator

No description provided.

@augustkline augustkline added the enhancement New feature or request label Oct 7, 2022
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit b199c41
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/63f5378e57e35c000870d623
😎 Deploy Preview https://deploy-preview-638--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fturmel fturmel mentioned this pull request Feb 7, 2023
@fturmel
Copy link
Collaborator

fturmel commented Feb 9, 2023

@klinegareth @shiffman Alright - got the showcase page in a working state with a few improvements, we're back on track! It's nice to see the community contributions all in one place. You can keep iterating on the page. Let me know if you need anything or have any questions.

https://deploy-preview-638--codingtrain.netlify.app/showcase

We now have to build 12,054 pages compared to 6,686 in the last production build. It's still manageable, but I think we'll eventually have to explore some new ideas (SSR, client-side pagination and filtering) to make the build and dev server startup times more reasonable.

fturmel and others added 3 commits February 9, 2023 01:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@fturmel
Copy link
Collaborator

fturmel commented Feb 9, 2023

I will also add that the language filter as currently implemented doesn't make too much sense. It refers to technologies used in the Coding Train video that inspired the contribution, and not the contribution itself.

@shiffman
Copy link
Member

shiffman commented Feb 9, 2023

Yes, I think we can do away with the filters. If I were to have filters what would be useful is:

  • filter by associated video title
  • filter by submitter name

I love the idea of being to see all showcase projects by any given passenger.

I could also imagine wanting to sort in reverse chronological order but that is very low priority.

Copy link
Collaborator

@fdoflorenzano fdoflorenzano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two things that I think are worth watching out for.

@fturmel
Copy link
Collaborator

fturmel commented Feb 19, 2023

OK... that was a decent amount of work, but I extracted the filters from the large ItemsPage component to simplify things and allow us some flexibility. Had to also change the function signature of filteredPath to make it more flexible.

I implemented only filtering by authors in the showcase page after all. Mostly because 845 authors * 401 topics ~= 340k static pages to build 😂 Not going to happen unless we switch to SSR or client-side pagination/filtering.

@klinegareth I added the missing "purple" variant for the showcase filter component, but that's the only style-related change that happened over the last commits. You can pick things up from here and work on the card layout if you want. Let me know if you're stuck or need any help!

One thing to look out for are rows of 2 contributions in the 3 columns layout:
Screenshot 2023-02-18 at 9 14 33 PM

@shiffman
Copy link
Member

Wow, amazing! Thank you @fturmel! I love the filtering by author so much. I think that's really the only filter we need since to see the showcase projects for any given video I can just click over to the video page.

We are so close to merging yay!

august kline and others added 2 commits February 21, 2023 13:31

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@shiffman shiffman marked this pull request as ready for review February 21, 2023 19:49
@shiffman
Copy link
Member

With @klinegareth's latest commit I think this is ready to merge!!! Wowza!!!

https://deploy-preview-638--codingtrain.netlify.app/showcase

I'm updating this with main and marking ready for review! I may do a couple final language tweaks. Any last comments or thoughts before I merge from anyone following?

I think we can make some refinements going forward:

  • handle video titles that are cut off
  • add information / headers to each passenger filter page so it's a bit more like a "profile" page
  • change author links to go to their filtered page (and there, you'd find a link to their website, etc.)?

We can open a new issue to track!

@fturmel
Copy link
Collaborator

fturmel commented Feb 21, 2023

@shiffman Looks good to me, and I agree with the refinement ideas.

I would add that we might want a "browse showcase" button on the homepage, just like tracks and challenges.
image

@fturmel
Copy link
Collaborator

fturmel commented Feb 21, 2023

Oh and we haven't resolved the homepage JSON with two CTA comment I left before. Would be nice to fix before we merge and just forget.

@shiffman
Copy link
Member

@fturmel I think I cleaned this up in 07a2b8d, how does it look?

@fturmel
Copy link
Collaborator

fturmel commented Feb 21, 2023

@shiffman Perfect!

@shiffman
Copy link
Member

Here we gooooooooooooooo!

@shiffman shiffman merged commit 9346c23 into main Feb 21, 2023
@shiffman shiffman deleted the showcase-page branch February 21, 2023 21:38
This was referenced Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants