Skip to content

Share replay leak #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2021
Merged

Share replay leak #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
397abb1
Add failing test for memory leak issue
jabeattie Mar 29, 2021
11cedcd
Ensure the cancellationHandler is called if present when completion r…
jabeattie Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Subjects/ReplaySubject.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ extension ReplaySubject {

func forwardCompletionToBuffer(_ completion: Subscribers.Completion<Failure>) {
demandBuffer?.complete(completion: completion)
cancel()
}

func request(_ demand: Subscribers.Demand) {
Expand Down
28 changes: 28 additions & 0 deletions Tests/ShareReplayTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,5 +213,33 @@ final class ShareReplayTests: XCTestCase {
XCTAssertTrue(results.isEmpty)
XCTAssertEqual(completions, [.failure(.someError)])
}

func testSharingDoesNotRetainClassBasedPublisher() {
var results = [Int]()
var completions = [Subscribers.Completion<Never>]()

var source: PassthroughSubject? = PassthroughSubject<Int, Never>()
weak var weakSource = source

var stream = source?.share(replay: 1)

stream?
.sink(
receiveCompletion: { completions.append($0) },
receiveValue: { results.append($0) }
)
.store(in: &subscriptions)

source?.send(1)
source?.send(completion: .finished)

subscriptions.forEach({ $0.cancel() })
stream = nil
source = nil

XCTAssertEqual(results, [1])
XCTAssertEqual(completions, [.finished])
XCTAssertNil(weakSource)
}
}
#endif