Skip to content

CLOrient3D parameter n_check validation #966

Open
@j-c-c

Description

@j-c-c

The n_check parameter is used in build_clmatrix() to reduce the number of pairs to find common lines between and in estimate_shifts() to reduce memory usage.

There are a couple issues with this parameter that need investigating:

  1. The parameter is not currently configurable from any of the subclasses that actually implement a common-lines method.
  2. It is not clear that this parameter is needed in build_clmatrix(). If it is, we should validate that the CL algos still work with it.
  3. We should validate that there is actually a memory issue when using estimate_shifts().

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcleanup

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions