FLE Basis

[chris-langfield]

Porting https://github.com/nmarshallf/fle_2d/ into ASPIRE.

Old version:
Relevant paper: https://arxiv.org/pdf/2207.13674.pdf

[codecov]

Codecov Report

Merging #693 (3c22ce8) into develop (a30567c) will increase coverage by 0.89%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #693      +/-   ##
===========================================
+ Coverage    88.33%   89.22%   +0.89%     
===========================================
  Files          113      115       +2     
  Lines         8922     9813     +891     
===========================================
+ Hits          7881     8756     +875     
- Misses        1041     1057      +16     

Impacted Files	Coverage Δ
src/aspire/basis/__init__.py	100.00% <100.00%> (ø)
src/aspire/basis/fle_2d.py	100.00% <100.00%> (ø)
src/aspire/basis/fle_2d_utils.py	100.00% <100.00%> (ø)
src/aspire/basis/steerable.py	88.77% <100.00%> (ø)
src/aspire/nufft/__init__.py	82.41% <100.00%> (ø)
src/aspire/utils/relion_interop.py	93.65% <0.00%> (-6.35%)	⬇️
src/aspire/source/image.py	97.22% <0.00%> (-0.25%)	⬇️
src/aspire/source/relion.py	96.83% <0.00%> (-0.08%)	⬇️
src/aspire/utils/__init__.py	100.00% <0.00%> (ø)
src/aspire/source/coordinates.py	93.65% <0.00%> (+1.21%)	⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[chris-langfield]

Turns out the fle_ells_sign method wasn't actually needed (holdover from previous method of getting FB ordering).

Think we addressed the main comments from this review. A few unresolved ones will be useful for future developers.

[chris-langfield]

Grid issue will be up by EOD of tomorrow.

[garrettwrong]

One last quick question regarding the sign flipping order thing. Otherwise anything unresolved is probably going to stay that way until we can take another closer pass.

I still have concerns with the code (grid, correspondence, and now the CTF convolution 😬 too). Will catch up with you later about the issue documentation. We can see what Joakim thinks about next steps (merging) tomorrow at our meeting.

Thanks for all your effort tidying this up!

[garrettwrong]

Okay. I'm going to leave this conversation open for the future, but nothing to do now.

[chris-langfield]

Thanks Garrett, sounds good!

[garrettwrong]

I think this is about as far as we can take this with the time left. Lets discuss it more tomorrow as a group. Thanks!

[chris-langfield]

Created #856 to track the odd resolutions grids problem

[garrettwrong]

Unless there were outstanding requests from Joakim that I missed, I think this ready to merge.

If we want to look at updating any issues, can make another PR.