Change tox.ini to follow external command rules for tox 4.x
#820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #820 +/- ##
========================================
Coverage 88.25% 88.25%
========================================
Files 113 113
Lines 8891 8891
========================================
Hits 7847 7847
Misses 1044 1044 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
j-c-c
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Github Actions runners have recently stopped installing
tox==3.28and started testing withtox=4.0.16. See #819 for details on this.This means that our
toxworkflow is now failing because of the use of theshcommand within thetox.ini. Withtox 4.x, this command must be added to theallowlist_externalin the tox environment.This PR makes that change.
I also tested this
toxconfiguration file with 3.28 locally and it appears to work. So we should be safe in the unlikely event that the GA runner happens to try running 3.28 again.