Skip to content

Update Schedule.php to fix iCal Generation #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

natep-tech
Copy link

@natep-tech natep-tech commented Jul 13, 2023

Updated the generateIcal() function.

  1. Updated the code that gets the starting date of the course, to use the weekday number of the term start date. This way if the term starts on a day other than Monday, it'll still correctly generate the start day of the course. iCal Export Dates placed wrong #310 Schedule offsets dates by one day #232

  2. Added code that'll generate a single series for a multi-day course (Mon,Web,Fri for example) to simplify calendars (see the iCal specification for RRULE). If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course. Exporting to Google Calendar Creates Separate Series #63

Updated the generateIcal() function.

1. Updated the code that gets the starting date of the course, to use the weekday number of the term start date. This way if the term starts on a day other than Monday, it'll still correctly generate the start day of the course.,

2. Added code that'll generate a single series for a multiday course (Mon,Web,Fri for example) to simplify calendars. If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course.
@natep-tech natep-tech marked this pull request as ready for review July 13, 2023 04:01
@natep-tech natep-tech requested a review from a team as a code owner July 13, 2023 04:01
@natep-tech natep-tech marked this pull request as draft July 13, 2023 04:14
@natep-tech
Copy link
Author

I need to update the first fix to support term start dates after the first day a class is supposed to start (Term starts Wednesday, so Tuesday/Thursday classes start on Thursday)

@MoralCode
Copy link
Contributor

MoralCode commented Jul 15, 2023

i assume the issues you linked are meant to be resolved when this issue closes, so you may need to add the following to the bottom of the PR description:

fixes #310
fixes #232
fixes #63

@natep-tech
Copy link
Author

I need to update the first fix to support term start dates after the first day a class is supposed to start (Term starts Wednesday, so Tuesday/Thursday classes start on Thursday)

Due to the issue #326 I am unable to finish this without correct data.

@MoralCode
Copy link
Contributor

@Lontronix are you able to help with this?

@MoralCode
Copy link
Contributor

Due to the issue #326 I am unable to finish this without correct data.

Correct data is present on rit.edu/calendar right?

Maybe making a scraper for that page to grab terms and start dates would be helpful both here and for #327

@Mstrodl Mstrodl mentioned this pull request Dec 24, 2023
@Mstrodl Mstrodl closed this Dec 24, 2023
@natep-tech
Copy link
Author

Change number 2, which generate a single series for a multi-day course (Mon,Web,Fri for example) and resolves #63 , was not addressed with #337 . This PR should stay open until all the features are merged.

@natep-tech
Copy link
Author

I broke out the unreviewed part into its own PR: #339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants