feat: improved LaTeX check workflows #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for c13n-newsletter ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I think it should be included in make.py rather than the writer since we may have older files that also need fixing. |
|
The code looks good for me. You could run the workflow in your forked repo to see the effects. |
|
Seems like the regex which matches valid TeX style math delimiters does not conform to our spec (available here). In short, the normal dollar signs should not be escaped as in the CommonMark spec. And I suggest using a finite state machine instead of regex to do the job. You may refer to the C implementation while implementing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the LaTeX checks;
Moved the modificatioin process in to a while loop, to ensure the error is fixed;
Only put LaTeX errors in the prompt when requesting a rewriting (the error prompts haven't been tested yet, they are generated by llms);
Isolated LaTeX when beautifying;
Haven't test the code ever once... not sure if it works.