Skip to content

Bugfix: Domain save issue - #879

Open
ziyacivan wants to merge 1 commit into
Corvia:masterfrom
ziyacivan:bugfix/domain-url-save-issue
Open

Bugfix: Domain save issue#879
ziyacivan wants to merge 1 commit into
Corvia:masterfrom
ziyacivan:bugfix/domain-url-save-issue

Conversation

@ziyacivan

Copy link
Copy Markdown

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • [] I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Other Information

I observed an issue within an edge-case scenario. After executing the code block below:

instance.delete_tenant()

I noticed that the domain_url field on the instance remained unchanged. The changes only became visible after I explicitly called instance.save(). Due to this inconsistency, I have created this pull request.

@Dresdn

Dresdn commented Oct 19, 2025

Copy link
Copy Markdown
Collaborator

@ziyacivan I see there are changes to some tests, but they look like formatting changes only. I don't know if you added or updated a test that showcases the bug and forgot to commit, but I wanted to check before adding one myself. Would be great to have a test for this edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants