Bugfix: Domain save issue - #879
Open
ziyacivan wants to merge 1 commit into
Open
Conversation
Collaborator
|
@ziyacivan I see there are changes to some tests, but they look like formatting changes only. I don't know if you added or updated a test that showcases the bug and forgot to commit, but I wanted to check before adding one myself. Would be great to have a test for this edge case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm helping!
Checklist
CHANGELOG.mdPull Request type
Please check the type of change your PR introduces:
Related issue(s)
Other Information
I observed an issue within an edge-case scenario. After executing the code block below:
I noticed that the
domain_urlfield on the instance remained unchanged. The changes only became visible after I explicitly calledinstance.save(). Due to this inconsistency, I have created this pull request.