Class naming for array elements

[gertvv]

I'm unable to set singular class names for elements of arrays. This might just be a documentation issue. I have tried the following. Schema:

{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "type": "object",
  "properties": {
    "outcomes": {
      "type": "array",
      "items": {
        "$id": "outcome",
        "type": "object",
        "properties": {
          "name": {
            "type": "string"
          }
        }
      }
    }
  }
}

And package-info:

@GenerateRecordsFromJsonSchemas(
  schemaRootFileLocations =
  @JsonSchemaFileLocation(
    moduleAndPackage = "com.example",
    relativeName = "my-schema.json"
  ),
  schemaConfigurations = {
    @JsonSchemaConfiguration(
      schemaId = "outcome",
      javaTypeQualifiedName = "com.example.Outcome"
    )
  }
)
package org.cochrane.datatransfer;

import com.cosium.json_schema_to_java_record_api.GenerateRecordsFromJsonSchemas;
import com.cosium.json_schema_to_java_record_api.JsonSchemaConfiguration;
import com.cosium.json_schema_to_java_record_api.JsonSchemaFileLocation;

Based on the README I had expected this to work. I also tried putting the Outcome under a definitions property and referring to it by $ref. While either way parse and generate OK, the configuration is not being applied. I have also tried with and without the brackets ({}) around the @JsonSchemaConfiguration.

I've further tried to assign a $id to the top-level schema and referring to it like <id>#/definitions/Outcome but that also didn't work. And finally I've tried nested schemas within $defs as well without success.

If the only way to handle this is to put schemas in separate files and refer to them via classpath URLs that would be disappointing because I'd like to be able to publish the schema without reference to any Java-isms.

[gertvv]

I've done some further experimenting with this and have noticed the following.

Breaking the main schema up into smaller files does get the configuration to apply. Using relative URIs would have allowed me to do this while keeping the schema "clean". Unfortunately that doesn't work and it seems like there might be a straightforward fix:

Fatal error compiling: java.lang.NullPointerException: Cannot invoke "java.net.URI.toString()" because "referencingFileURL" is null -> [Help 1]

Further, there appears to be a difference in how the main file is parsed versus any referenced schema files. In the main file I'm able to use kebab-case property names without issue but in the auxiliary files I get:

Fatal error compiling: java.lang.IllegalArgumentException: not a valid name: outcome-type
...
at com.cosium.json_schema_to_java_record.JsonSchemaContent.writeJavaType (JsonSchemaContent.java:169)

I can open a separate issue about either of these if you wish?

[gertvv]

One further comment on the naming strategy for classes. It occurred to me that the root schema class is derived from the name of the schema file (or perhaps the $id?). This would seem a more sensible default for the class names of any referenced schema files as well. Why not use that default rather than basing it on a property name (which also leads to duplicated classes vs. the schema)?

[reda-alaoui]

There are many mentioned topics here. Could you please split these into single topic issues?
For each issue, please provide a git repository allowing to reproduce the problem you are encountering.