chore: Register all contracts in IBCv2 port router #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
changed the title
kulikthebird
force-pushed
the
tkulik/feat/register_ibc2_contracts
branch
from
644017b to
082f2ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 44.90% 44.87% -0.03%
==========================================
Files 79 79
Lines 11035 11050 +15
==========================================
+ Hits 4955 4959 +4
- Misses 5643 5654 +11
Partials 437 437
🚀 New features to boost your workflow:
|
kulikthebird
force-pushed
the
tkulik/feat/register_ibc2_contracts
branch
2 times, most recently
from
e1f584e to
7f3d719
Compare
kulikthebird
commented
May 29, 2025
|
|
||
| // TODO: Remove the registration of each contract in https://github.com/CosmWasm/wasmd/issues/2278 | ||
| // and add IBCv2 port ID prefix before calling `SetRouterV2` during WasmKeeper creation. | ||
| app.WasmKeeper.RegisterContractsInIbc2Router(ctx) |
There was a problem hiding this comment.
I couldn't find a way to test the contracts registration during the app initialization procedure. It seems like the contracts list on the app start up is always empty. As for now I found out that the only way to update the application with an up-to-date state is via InitGenesis procedure.
There was a problem hiding this comment.
I've tested that manually - the contracts are registered in the RouterV2 after reboot of wasmd
kulikthebird
force-pushed
the
tkulik/feat/register_ibc2_contracts
branch
from
7f3d719 to
d2a1e80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.