Package bumps #355
Merged
Package bumps #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you for bringing this up. I agree with the version bump to 1.18. This was the opportunity to get some more clarity on the different compiler versions and share that in #361. I'd appreciate if you could have a read and see if it makes sense to you. |
webmaster128
requested changes
Nov 23, 2022
There was a problem hiding this comment.
Two minor things that should be adjusted before merge. #361 should provide the motivation why those changes make sense.
| command: | | ||
| [ "$(gofmt -l .)" = "" ] || (gofmt -d . && exit 1) | ||
| tidy-go: |
There was a problem hiding this comment.
Could you also update the format-go job above? There are currently 4 places where cimg/go:1.17.4 is used.
| tidy-go: | ||
| docker: | ||
| - image: cimg/go:1.17.4 | ||
| - image: cimg/go:1.18 |
There was a problem hiding this comment.
Could you pin the patch version? cimg/go:1.18.8
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: