Skip to content

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Jun 3, 2024

First stab to fix #1061. Also added support for lock file v9 in the process.

@setchy any thoughts?
@cerrussell would this affect your work?

Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu marked this pull request as ready for review June 3, 2024 20:29
@prabhu prabhu requested a review from setchy as a code owner June 3, 2024 20:29
prabhu added 2 commits June 3, 2024 21:36
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
@setchy
Copy link
Member

setchy commented Jun 3, 2024

Nice!

I haven't used corepack much... Did you happen to try corepack enable pnpm instead of corepack enable && corepack pnpm install - per pnpm docs?

@prabhu
Copy link
Collaborator Author

prabhu commented Jun 4, 2024

Thanks @setchy. Not seeing any difference between the two enable commands. Guessing since we already have the packageManager specified in the package.json file. It doesn't run install command automatically, which is correct since cannot know the arguments to be used.

@prabhu prabhu merged commit 3b698cd into master Jun 4, 2024
@prabhu prabhu deleted the feature/pnpm branch June 4, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: switch from npm to pnpm
2 participants