[grapefruitgreentealoe] WEEK 01 solutions #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiji-hoon96
reviewed
Mar 31, 2025
| var containsDuplicate = function (nums) { | ||
| const numberSet = new Set(); | ||
| //시간 복잡도 O(n) | ||
| for (i of nums) { |
There was a problem hiding this comment.
안녕하세요! 첫 리뷰 남겨봅니다!
i 변수가 let, const로 선언되어 있지 않아 JS에서 자동으로 전역 변수로 취급되어 글로벌 스코프 오염 문제가 발생할 수 있을 것 같습니다.
지금처럼 단순한 로직에서는 큰 문제가 없어 보이지만, 복잡한 코드에서는 신경 써야 할 것 같습니다~!
grapefruitgreentealoe
force-pushed
the
main
branch
from
6b72441 to
9e20a2f
Compare
jiji-hoon96
reviewed
Apr 3, 2025
Comment on lines
+13
to
+20
| var twoSum = function (nums, target) { | ||
| //순회. target에서 nums[i]를 뺀 요소를 찾기. | ||
| //2중포문. 시간복잡도 O(1)~O(N^2) | ||
| for (let i = 0; i < nums.length; i++) { | ||
| const subNum = target - nums[i]; // 공간 O(1) | ||
| for (let j = i + 1; j < nums.length; j++) { | ||
| if (nums[j] == subNum) { | ||
| return [i, j]; |
There was a problem hiding this comment.
역시 시작은 다 이렇게..ㅋㅋ (저만 그런게 아니였네요)
1주차 고생많으셨습니다! 이번주도 화이팅입니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!