[jiji-hoon96] WEEK 01 solutions #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisdom08
approved these changes
Apr 5, 2025
|
|
||
| function longestConsecutive(nums: number[]): number { | ||
| if (nums.length === 0) return 0; | ||
| const sortNum = Array.from(new Set(nums)).sort((a, b) => a - b); |
|
|
||
| if (sortNum.length === 1) return 1; | ||
|
|
||
| const resultArray : number[] = [] |
There was a problem hiding this comment.
최댓값만 필요하니까 resultArray 제거하고 maxCount 변수 하나로도 추적할 수 있지 않을까요?
There was a problem hiding this comment.
오! 피드백 감사합니다
개선해보았어요!
| for(const [key] of sortObject){ | ||
| if(k>0){ | ||
| result.push(Number(key)) | ||
| k--; |
There was a problem hiding this comment.
k를 직접 감소시키는 방법도 있지만 slice를 쓸 수도 있을 것 같아요!
There was a problem hiding this comment.
sortObject.slice(0, k).map(([key]) => Number(key))
코드가 더 간결해졌군요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!