datadog_monitor doesn't automatically restart the Agent #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ef-datadog into remeh/notification-handlers
… dd-agent recipe.
olivielpeau
approved these changes
Apr 24, 2019
README.md
Outdated
| ### Example | ||
|
|
||
| This example enables the ElasticSearch integration by using the `datadog_monitor` resource. It provides the instance configuration (in this case: the url to connect to ElasticSearch) and set the `use_integration_template` flag to use the default configuration template. | ||
| This example enables the ElasticSearch integration by using the `datadog_monitor` resource. It provides the instance configuration (in this case: the url to connect to ElasticSearch) and set the `use_integration_template` flag to use the default configuration template. Also, it notifies the `service[datadog-agent]` resource in order to restart the Agent. If you use multiple times the resource `datadog_monitor` in your cookbook, it's recommended for speed purpose to restart the Agent only with the last call. |
There was a problem hiding this comment.
Suggested change
| This example enables the ElasticSearch integration by using the `datadog_monitor` resource. It provides the instance configuration (in this case: the url to connect to ElasticSearch) and set the `use_integration_template` flag to use the default configuration template. Also, it notifies the `service[datadog-agent]` resource in order to restart the Agent. If you use multiple times the resource `datadog_monitor` in your cookbook, it's recommended for speed purpose to restart the Agent only with the last call. | |
| This example enables the ElasticSearch integration by using the `datadog_monitor` resource. It provides the instance configuration (in this case: the url to connect to ElasticSearch) and sets the `use_integration_template` flag to use the default configuration template. Also, it notifies the `service[datadog-agent]` resource in order to restart the Agent. |
(note: no need to use notifies only once: by default notifies is used with the :delayed option, which means that Chef will queue the notifies until the end of the Chef run, dedupe them, and actually restart the service only once at the end of the run. Pretty neat stuff)
remeh
force-pushed
the
remeh/notification-handlers
branch
from
a6d9e2f to
917b1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It must now be done explicitly while using the
datadog_monitorresource. See the change in the README.This PR has been first created by @someara in #323