add datadog-origin header resolves #189 #215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojproductions
changed the title
nitpik for this: it would be nice to have some screenshots or links to view, validate and understand. In this specific case, I was wondering where the headers are showing in the UI? is it a tag of a span? |
| traceIDHeader = "x-datadog-trace-id" | ||
| parentIDHeader = "x-datadog-parent-id" | ||
| samplingPriorityHeader = "x-datadog-sampling-priority" | ||
| originHeader = "x-datadog-origin" |
There was a problem hiding this comment.
i see in this PR this header is created but could you please help me understand how this originHeader is used in the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the datadog-origin header to context if its present in given event headers or extension context
Motivation
Issue #189
Testing Guidelines
I created some unit tests and updated existing ones. Also ran lamba functions to see if expected header was present
Additional Notes
Types of changes
Checklist