-
Notifications
You must be signed in to change notification settings - Fork 38
fix: reset tracecontext to avoid unintentional caching #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@codex review |
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
[HOLD] Not merging yet because this seems to be a broader issue if the fix is correct. So we should reproduce first.
Trying these now. |
I could not reproduce. We actually have the exact payload in this customer's case but somehow it's not getting any failure , yet the extracted context is different from the customer's case, which is different from any of the tracecontext propagated. |
What does this PR do?
The customer is experiencing a case where multiple lambda invocations are put into one trace even though they have different tracecontext in their payload. This indicates that the
rootTraceContext
was reused/cached unintentionally.Motivation
https://datadoghq.atlassian.net/browse/APMS-17080
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply