Skip to content

feat(appsec): enable telemetry when appsec is enabled through the tracer and not the extension #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025

Conversation

florentinl
Copy link
Contributor

@florentinl florentinl commented Jul 29, 2025

What does this PR do?

This PR does the two following things:

Motivation

In the continuity of moving from the extension implementation of appsec for python to the tracer, having functional runtime Software Composition Analysis is part of the scope.

Testing Guidelines

Manual testing for now, and system-tests will be coming soon.

Because the feature is entirely implemented on the dd-trace-py side, I don't think it makes a lot of sense to add unit tests here.

Additional Notes

I reused the env variable instead of relying on the config module. Importing the config module resulted in cyclic imports that caused a lot of tests to fail for reasons I don't fully understand. I have not investigated further.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@florentinl florentinl force-pushed the florentinl/APPSEC-58473/agentless-telemetry-and-sca branch 2 times, most recently from e6cfcc8 to 549c6eb Compare July 29, 2025 15:50
@florentinl florentinl changed the title feat(appsec): make SCA available in Lambda, the same way it is done in the extension feat(appsec): make SCA available in Lambda without DD_SERVERLESS_APPSEC_ENABLED Jul 30, 2025
@florentinl florentinl force-pushed the florentinl/APPSEC-58473/agentless-telemetry-and-sca branch from 549c6eb to d14e1cd Compare July 30, 2025 07:54
@florentinl florentinl changed the title feat(appsec): make SCA available in Lambda without DD_SERVERLESS_APPSEC_ENABLED feat(appsec): enable telemetry when appsec is enabled through the tracer and not the extension Jul 30, 2025
@florentinl florentinl marked this pull request as ready for review July 30, 2025 08:14
@florentinl florentinl requested review from a team as code owners July 30, 2025 08:14
@florentinl florentinl merged commit f2808fb into main Jul 31, 2025
61 checks passed
@florentinl florentinl deleted the florentinl/APPSEC-58473/agentless-telemetry-and-sca branch July 31, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants