RUM-11830: Create profiling module #2893
Open
+144
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambushwork
force-pushed
the
yl/profiling/create-module
branch
3 times, most recently
from
586a44c to
e2c2547
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #2893 +/- ##
==============================================================
- Coverage 71.11% 70.89% -0.22%
==============================================================
Files 810 811 +1
Lines 29677 29678 +1
Branches 4967 4967
==============================================================
- Hits 21104 21038 -66
- Misses 7230 7285 +55
- Partials 1343 1355 +12
🚀 New features to boost your workflow:
|
ambushwork
force-pushed
the
yl/profiling/create-module
branch
from
e2c2547 to
1495bbf
Compare
0xnm
previously approved these changes
Sep 24, 2025
Comment on lines
44
to
45
| implementation(libs.gson) | ||
| implementation(libs.okHttp) |
There was a problem hiding this comment.
I'm not sure these 2 will be needed. It is better to remove them and add only in needed.
Same maybe for dd-sdk-android-internal usage above so far.
Comment on lines
61
to
62
| testImplementation(libs.okHttp) | ||
| testImplementation(libs.okHttpMock) |
aleksandr-gringauz
previously approved these changes
Sep 24, 2025
ambushwork
dismissed stale reviews from aleksandr-gringauz and 0xnm
via
08b5702
ambushwork
force-pushed
the
yl/profiling/create-module
branch
from
1495bbf to
08b5702
Compare
0xnm
previously approved these changes
Sep 24, 2025
| api(project(":dd-sdk-android-core")) | ||
| implementation(project(":dd-sdk-android-internal")) | ||
| implementation(libs.kotlin) | ||
| implementation(libs.gson) |
ambushwork
force-pushed
the
yl/profiling/create-module
branch
from
08b5702 to
4b6551d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create profiling module
Motivation
RUM-11830
Review checklist (to be filled by reviewers)