RUM-1871 Reduced view update may miss hasReplay
flag set before
#2205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
RUM backend has a special handling for
hasReplay
flag - once it is sent to true in any view update it cannot go back to false.On the client side, however, we reduce the views, keeping only the last view update for a given
viewId
in the batch. If this view had originallyhasReplay: true
and then last view update hashasReplay:false
(because by the time view update is sent session replay is disabled) we will miss session replay info for this view.How?
Introduction of a new private attribute
hasReplay
in theRUMViewScope
class that is set each time a new View event is built. In the case that it has once been set to true, each followingRUMViewEvent
that is created will keephasReplay
set to true.Review checklist
make api-surface
)