profiler: log cpuProfileRate when starting a trace #2030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2023-06-29 14:43:03 Comparing candidate commit 0dae742 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics. |
nsrip-dd
previously approved these changes
Jun 9, 2023
felixge
force-pushed
the
felix.geisendoerfer/PROF-7728-reveal-os-scheduling-latency
branch
from
7992969 to
5ccb743
Compare
This will improve our ability to analyze OS scheduling latency. See golang/go#60701 for a better approach in the long run. For PROF-7728
felixge
force-pushed
the
felix.geisendoerfer/PROF-7728-reveal-os-scheduling-latency
branch
from
5ccb743 to
323dc59
Compare
nsrip-dd
approved these changes
Jun 9, 2023
felixge
deleted the
felix.geisendoerfer/PROF-7728-reveal-os-scheduling-latency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
profiler: log cpuProfileRate when starting a trace
Motivation
This will improve our ability to analyze OS scheduling latency.
See golang/go#60701 for a better approach in the long run.
For PROF-7728
Describe how to test/QA your changes
See new test case.
Reviewer's Checklist