Skip to content

feat: new payload interface to represent payload types #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 5, 2025
Merged

feat: new payload interface to represent payload types #3933

merged 7 commits into from
Sep 5, 2025

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Aug 29, 2025 •
edited
Loading

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

kakkoyun and others added 6 commits August 27, 2025 15:15
@kakkoyun
fix(ddtrace/tracer): resolve race conditions in write pipeline (#3821)
77122a1 
Signed-off-by: Kemal Akkoyun <[email protected]>
@nsrip-dd
fix(profiler): don't double compress non-delta profiles (#3918)
35e1174 
Our non-delta heap, block, and mutex profiles are getting
double-compressed. That is, they are gzip-compressed, and if you
decompress them then you get another gzip-compressed blob, which is in
turn a compressed pprof file.

This is due to a bug introduced by #3529. In that PR we reworked our
compression logic in order to support re-compression (into zstd in
particular). We incorrectly decided whether a given profile type is a
delta profile by just checking whether there are delta values for the
profile type, without checking whether delta profiling is actually enabled.
As a result, when delta profiling is disabled we use the delta profling
enabled logic, where we assume the input data is uncomprossed and then
gzip-compress it.
@ichinaski
feat(ddtrace/tracer): Add 'endpoint' tag to API error metric (#3925)
105f1ef
@hannahkm
Merge remote-tracking branch 'origin' into hannahkm/msgp-payload-inte…
a7b2c38 
…rface
@hannahkm
todo
6a204dd
@hannahkm
add unsafe payload back as interface
9e1e483
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 29, 2025
@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-08-29 17:31:42

Comparing candidate commit 3e056aa in PR branch hannahkm/msgp-payload-interface with baseline commit 8b6c47f in branch hannahkm/new-msgp-serialization.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@hannahkm hannahkm marked this pull request as ready for review September 5, 2025 15:46
@hannahkm hannahkm requested review from a team as code owners September 5, 2025 15:46
@hannahkm hannahkm merged commit 1b4efb4 into hannahkm/new-msgp-serialization Sep 5, 2025
216 checks passed
@hannahkm hannahkm deleted the hannahkm/msgp-payload-interface branch September 5, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannahkm @kakkoyun @nsrip-dd @ichinaski