Skip to content

Error flag manually set to a gRPC server span gets overwritten #8042

@sdwa0

Description

@sdwa0

GrpcServerDecorator overwrites an error flag manually set to a gRPC server span, based on the status code returned by the gRPC server. That shouldn't be overwritten.

The behavior was slightly different before #7505, which was released in v1.39.0. Before the change, the gRPC server instrumentation code overwrote the error flag only when the gRPC server returned an error. Now, it overwrites the error flag regardless of the server response status.

Similar to what HttpServerDecorator does (introduced in #5359), GrpcServerDecorator can set the error flag with a lower priority.

Metadata

Metadata

Assignees

Labels

inst: grpcgRPC instrumentationtype: bugBug report and fix

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions