Minor optimization to avoid using BigInteger if possible #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougqh
approved these changes
Sep 27, 2019
| @@ -430,7 +431,15 @@ public UInt64IDStringSerializer(final Class<String> stringClass) { | |||
| public void serialize( | |||
| final String value, final JsonGenerator gen, final SerializerProvider provider) | |||
| throws IOException { | |||
| gen.writeNumber(new BigInteger(value)); | |||
| final int length = value.length(); | |||
| // BigInteger's are expensive, so lets try to avoid using them if possible. | |||
There was a problem hiding this comment.
Can we use JsonGenerator::writeNumber(String)?
The doc says it isn't support for all generators, but if it is available it would save us parsing & allocating.
My other thought was a custom Number class to represent UInt64, but JsonGenerator doesn't support that.
There was a problem hiding this comment.
While I agree, that would be nice to use, but unfortunately this is what that would end up using: https://github.com/msgpack/msgpack-java/blob/0.8.18/msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java#L437-L477
There was a problem hiding this comment.
Ah, fair enough. I was hoping that it would be implemented more efficiently, but apparently, it is less efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.