Skip to content

Add compatibility tests for OpenTracing 0.31.0 #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

Add compatibility tests for OpenTracing 0.31.0 #1044

merged 1 commit into from
Oct 16, 2019

Conversation

tylerbenson
Copy link
Contributor

In preparation for merging #641

@tylerbenson tylerbenson requested a review from a team as a code owner October 15, 2019 22:16
dougqh
dougqh approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@dougqh dougqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As basic test, I think this is good. I'm a little concerned that Groovy will let certain compatibility errors slip through, but since the actual code under test is in Java, I think we're okay.

@tylerbenson
Copy link
Contributor Author

I had a similar concern, so I did some validation by forcing an incompatible version to verify that errors were discovered.

@tylerbenson tylerbenson merged commit 397299f into master Oct 16, 2019
@tylerbenson tylerbenson deleted the tyler/ot-compat-test branch October 16, 2019 18:57
@tylerbenson tylerbenson added this to the 0.35.0 milestone Oct 22, 2019
@randomanderson randomanderson mentioned this pull request Oct 24, 2019
Closed
@dougqh dougqh mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerbenson @dougqh