Skip to content

Optimize Git repository information computation #8270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Optimize Git repository information computation #8270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee18c9b
Moving null path computation into static
dougqh Jan 22, 2025
11ff523
spotless
dougqh Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal-api/src/main/java/datadog/trace/api/git/GitInfoProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public class GitInfoProvider {
INSTANCE.registerGitInfoBuilder(new UserSuppliedGitInfoBuilder());
}

static final String NULL_PATH_STRING = Paths.get("").toAbsolutePath().toString();

private volatile Collection<GitInfoBuilder> builders = Collections.emptyList();

// in regular cases git info has to be built only once,
Expand All @@ -42,7 +44,7 @@ public GitInfo getGitInfo() {

public GitInfo getGitInfo(@Nullable String repositoryPath) {
if (repositoryPath == null) {
repositoryPath = Paths.get("").toAbsolutePath().toString();
repositoryPath = NULL_PATH_STRING;
}
return gitInfoCache.computeIfAbsent(repositoryPath, this::buildGitInfo);
}
Expand Down
Loading