Skip to content

Avoid unsupported API call for creating folders on windows #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Avoid unsupported API call for creating folders on windows #8304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...filing-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import datadog.trace.util.AgentTaskScheduler;
import datadog.trace.util.PidHelper;
import java.io.IOException;
import java.nio.file.FileSystems;
import java.nio.file.FileVisitResult;
import java.nio.file.FileVisitor;
import java.nio.file.Files;
Expand Down Expand Up @@ -344,9 +345,16 @@ public Path getTempDir(Path subPath, boolean create) {
subPath != null && !subPath.toString().isEmpty() ? tempDir.resolve(subPath) : tempDir;
if (create && !Files.exists(rslt)) {
try {
Files.createDirectories(
rslt,
PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rwx------")));
Set<String> supportedViews = FileSystems.getDefault().supportedFileAttributeViews();
if (supportedViews.contains("posix")) {
Files.createDirectories(
rslt,
PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rwx------")));
} else {
// non-posix, eg. Windows - let's rely on the created folders being world-writable
Files.createDirectories(rslt);
}

} catch (Exception e) {
log.warn(SEND_TELEMETRY, "Failed to create temp directory: {}", tempDir, e);
throw new IllegalStateException("Failed to create temp directory: " + tempDir, e);
Expand Down
Loading