Skip mule-core 4.9.1 due to missing mule-artifact-ast:1.5.1 dependency #8415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y (also removed redundant muzzle block)
mcculls
added
tag: no release notes
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043154
Total [baseline] (8.701 s) : 0, 8700806
Agent [candidate] (1.042 s) : 0, 1041555
Total [candidate] (8.644 s) : 0, 8644095
section iast
Agent [baseline] (1.172 s) : 0, 1172060
Total [baseline] (9.265 s) : 0, 9264509
Agent [candidate] (1.173 s) : 0, 1172821
Total [candidate] (9.262 s) : 0, 9262439
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1188642
Total [baseline] (9.283 s) : 0, 9282687
Agent [candidate] (1.181 s) : 0, 1180536
Total [candidate] (9.291 s) : 0, 9290572
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1170596
Total [baseline] (9.263 s) : 0, 9262787
Agent [candidate] (1.166 s) : 0, 1166450
Total [candidate] (9.248 s) : 0, 9247587
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.489 ms) : 0, 718489
BytebuddyAgent [candidate] (718.165 ms) : 0, 718165
GlobalTracer [baseline] (240.448 ms) : 0, 240448
GlobalTracer [candidate] (239.797 ms) : 0, 239797
AppSec [baseline] (55.377 ms) : 0, 55377
AppSec [candidate] (55.527 ms) : 0, 55527
Remote Config [baseline] (705.852 µs) : 0, 706
Remote Config [candidate] (698.667 µs) : 0, 699
Telemetry [baseline] (12.904 ms) : 0, 12904
Telemetry [candidate] (12.19 ms) : 0, 12190
section iast
BytebuddyAgent [baseline] (836.293 ms) : 0, 836293
BytebuddyAgent [candidate] (836.867 ms) : 0, 836867
GlobalTracer [baseline] (230.751 ms) : 0, 230751
GlobalTracer [candidate] (231.382 ms) : 0, 231382
IAST [baseline] (22.832 ms) : 0, 22832
IAST [candidate] (22.715 ms) : 0, 22715
AppSec [baseline] (57.566 ms) : 0, 57566
AppSec [candidate] (57.262 ms) : 0, 57262
Remote Config [baseline] (617.541 µs) : 0, 618
Remote Config [candidate] (612.31 µs) : 0, 612
Telemetry [baseline] (8.738 ms) : 0, 8738
Telemetry [candidate] (8.703 ms) : 0, 8703
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (849.766 ms) : 0, 849766
BytebuddyAgent [candidate] (843.437 ms) : 0, 843437
GlobalTracer [baseline] (233.208 ms) : 0, 233208
GlobalTracer [candidate] (231.995 ms) : 0, 231995
IAST [baseline] (23.241 ms) : 0, 23241
IAST [candidate] (22.977 ms) : 0, 22977
AppSec [baseline] (57.383 ms) : 0, 57383
AppSec [candidate] (57.414 ms) : 0, 57414
Remote Config [baseline] (638.3 µs) : 0, 638
Remote Config [candidate] (610.561 µs) : 0, 611
Telemetry [baseline] (8.734 ms) : 0, 8734
Telemetry [candidate] (8.669 ms) : 0, 8669
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.981 ms) : 0, 835981
BytebuddyAgent [candidate] (832.279 ms) : 0, 832279
GlobalTracer [baseline] (231.195 ms) : 0, 231195
GlobalTracer [candidate] (230.514 ms) : 0, 230514
IAST [baseline] (24.238 ms) : 0, 24238
IAST [candidate] (25.333 ms) : 0, 25333
AppSec [baseline] (54.702 ms) : 0, 54702
AppSec [candidate] (53.778 ms) : 0, 53778
Remote Config [baseline] (615.458 µs) : 0, 615
Remote Config [candidate] (634.969 µs) : 0, 635
Telemetry [baseline] (8.531 ms) : 0, 8531
Telemetry [candidate] (8.57 ms) : 0, 8570
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041513
Total [baseline] (10.486 s) : 0, 10485786
Agent [candidate] (1.042 s) : 0, 1041553
Total [candidate] (10.506 s) : 0, 10506463
section appsec
Agent [baseline] (1.187 s) : 0, 1187212
Total [baseline] (10.749 s) : 0, 10749097
Agent [candidate] (1.182 s) : 0, 1182427
Total [candidate] (10.77 s) : 0, 10769513
section iast
Agent [baseline] (1.171 s) : 0, 1171496
Total [baseline] (11.058 s) : 0, 11058001
Agent [candidate] (1.175 s) : 0, 1174543
Total [candidate] (11.005 s) : 0, 11004939
section profiling
Agent [baseline] (1.263 s) : 0, 1262988
Total [baseline] (10.991 s) : 0, 10991070
Agent [candidate] (1.261 s) : 0, 1260862
Total [candidate] (10.909 s) : 0, 10908700
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.646 ms) : 0, 717646
BytebuddyAgent [candidate] (717.404 ms) : 0, 717404
GlobalTracer [baseline] (239.658 ms) : 0, 239658
GlobalTracer [candidate] (239.673 ms) : 0, 239673
AppSec [baseline] (55.398 ms) : 0, 55398
AppSec [candidate] (55.486 ms) : 0, 55486
Remote Config [baseline] (710.878 µs) : 0, 711
Remote Config [candidate] (695.004 µs) : 0, 695
Telemetry [baseline] (12.913 ms) : 0, 12913
Telemetry [candidate] (13.024 ms) : 0, 13024
section appsec
BytebuddyAgent [baseline] (737.751 ms) : 0, 737751
BytebuddyAgent [candidate] (733.739 ms) : 0, 733739
GlobalTracer [baseline] (237.511 ms) : 0, 237511
GlobalTracer [candidate] (236.472 ms) : 0, 236472
AppSec [baseline] (176.849 ms) : 0, 176849
AppSec [candidate] (176.858 ms) : 0, 176858
Remote Config [baseline] (675.07 µs) : 0, 675
Remote Config [candidate] (670.27 µs) : 0, 670
Telemetry [baseline] (8.352 ms) : 0, 8352
Telemetry [candidate] (8.664 ms) : 0, 8664
IAST [baseline] (21.414 ms) : 0, 21414
IAST [candidate] (21.503 ms) : 0, 21503
section iast
BytebuddyAgent [baseline] (835.857 ms) : 0, 835857
BytebuddyAgent [candidate] (838.162 ms) : 0, 838162
GlobalTracer [baseline] (230.457 ms) : 0, 230457
GlobalTracer [candidate] (231.576 ms) : 0, 231576
AppSec [baseline] (57.577 ms) : 0, 57577
AppSec [candidate] (57.469 ms) : 0, 57469
Remote Config [baseline] (628.136 µs) : 0, 628
Remote Config [candidate] (611.233 µs) : 0, 611
Telemetry [baseline] (8.778 ms) : 0, 8778
Telemetry [candidate] (8.725 ms) : 0, 8725
IAST [baseline] (22.891 ms) : 0, 22891
IAST [candidate] (22.734 ms) : 0, 22734
section profiling
ProfilingAgent [baseline] (96.343 ms) : 0, 96343
ProfilingAgent [candidate] (96.16 ms) : 0, 96160
BytebuddyAgent [baseline] (708.542 ms) : 0, 708542
BytebuddyAgent [candidate] (707.457 ms) : 0, 707457
GlobalTracer [baseline] (350.41 ms) : 0, 350410
GlobalTracer [candidate] (350.54 ms) : 0, 350540
AppSec [baseline] (55.715 ms) : 0, 55715
AppSec [candidate] (54.871 ms) : 0, 54871
Remote Config [baseline] (672.009 µs) : 0, 672
Remote Config [candidate] (674.9 µs) : 0, 675
Telemetry [baseline] (8.978 ms) : 0, 8978
Telemetry [candidate] (8.904 ms) : 0, 8904
Profiling [baseline] (96.367 ms) : 0, 96367
Profiling [candidate] (96.184 ms) : 0, 96184
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1343, 1384
. : milestone, 1364,
appsec (1.741 ms) : 1718, 1764
. : milestone, 1741,
appsec_no_iast (1.766 ms) : 1741, 1791
. : milestone, 1766,
iast (1.505 ms) : 1481, 1530
. : milestone, 1505,
profiling (1.483 ms) : 1459, 1506
. : milestone, 1483,
tracing (1.516 ms) : 1491, 1541
. : milestone, 1516,
section candidate
no_agent (1.362 ms) : 1343, 1381
. : milestone, 1362,
appsec (1.732 ms) : 1708, 1756
. : milestone, 1732,
appsec_no_iast (1.777 ms) : 1752, 1803
. : milestone, 1777,
iast (1.521 ms) : 1497, 1545
. : milestone, 1521,
profiling (1.536 ms) : 1511, 1561
. : milestone, 1536,
tracing (1.505 ms) : 1481, 1530
. : milestone, 1505,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section baseline
no_agent (381.642 µs) : 362, 402
. : milestone, 382,
iast (509.151 µs) : 487, 531
. : milestone, 509,
iast_FULL (733.54 µs) : 712, 755
. : milestone, 734,
iast_GLOBAL (565.07 µs) : 543, 587
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (512.345 µs) : 491, 534
. : milestone, 512,
iast_INACTIVE (465.097 µs) : 443, 487
. : milestone, 465,
iast_TELEMETRY_OFF (502.823 µs) : 479, 526
. : milestone, 503,
tracing (453.909 µs) : 433, 475
. : milestone, 454,
section candidate
no_agent (380.765 µs) : 361, 400
. : milestone, 381,
iast (510.211 µs) : 488, 532
. : milestone, 510,
iast_FULL (731.854 µs) : 710, 754
. : milestone, 732,
iast_GLOBAL (569.241 µs) : 546, 593
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (524.26 µs) : 501, 547
. : milestone, 524,
iast_INACTIVE (465.838 µs) : 445, 487
. : milestone, 466,
iast_TELEMETRY_OFF (499.214 µs) : 476, 522
. : milestone, 499,
tracing (453.408 µs) : 433, 474
. : milestone, 453,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.355 ms) : 2312, 2398
. : milestone, 2355,
iast (2.095 ms) : 2041, 2150
. : milestone, 2095,
iast_GLOBAL (2.147 ms) : 2091, 2203
. : milestone, 2147,
profiling (1.98 ms) : 1936, 2025
. : milestone, 1980,
tracing (1.929 ms) : 1887, 1971
. : milestone, 1929,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.352 ms) : 2309, 2395
. : milestone, 2352,
iast (2.106 ms) : 2051, 2161
. : milestone, 2106,
iast_GLOBAL (2.148 ms) : 2092, 2203
. : milestone, 2148,
profiling (1.959 ms) : 1915, 2002
. : milestone, 1959,
tracing (1.937 ms) : 1895, 1980
. : milestone, 1937,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d22b1025f6, baseline=1.47.0-SNAPSHOT~a47c3cefc3
dateFormat X
axisFormat %s
section baseline
no_agent (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
appsec (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
iast (18.817 s) : 18817000, 18817000
. : milestone, 18817000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
. : milestone, 17882000,
profiling (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
tracing (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
section candidate
no_agent (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
appsec (15.178 s) : 15178000, 15178000
. : milestone, 15178000,
iast (18.659 s) : 18659000, 18659000
. : milestone, 18659000,
iast_GLOBAL (18.132 s) : 18132000, 18132000
. : milestone, 18132000,
profiling (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
tracing (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
|
PerfectSlayer
approved these changes
Feb 18, 2025
amarziali
reviewed
Feb 18, 2025
| excludeDependency 'com.google.code.findbugs:jsr305' | ||
| additionalDependencies +="org.mule.runtime:mule-core:$muleVersion" | ||
| } | ||
| pass { |
There was a problem hiding this comment.
that was asserting that part of the instrumentation that was previously applying for mule-core (i.e. EventContextInstrumentation) is not applying anymore before 4.5.0. Naturally it would but there are muzzle references added to make it fail. The reason is that, since we offcially support mule from 4.5.0, we want to make the instrumentation not partially applying on version below
There was a problem hiding this comment.
I don't think that's what it was testing though because the version it tested was "[$muleVersion,)" i.e. 4.5.0 and above - it was also asserting pass but from your description it should have been asserting fail?
there is a block which is testing the instrumentation doesn't apply for versions before 4.5.0 - I left that in place
There was a problem hiding this comment.
Yeah it's a bit confusing. It was asserting that it was still passing but it dit assertInverse. In fact that specific EventContextInstrumentation would have normally passed on < 4.5.0 without the muzzleCheck it contains. On the contrary other instrumentations are only passing after 4.5.0. For this reason it had a specific muzzle check. The global goal was to have everything (> 4.5.0) or nothing (<4.5.0)
Perhaps there is a cleaner way to do it
There was a problem hiding this comment.
yeah, I think calling it something like fails-before-4.5.0-passes-after would have been clearer :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Skip mule-core 4.9.1 due to missing mule-artifact-ast:1.5.1 dependency - looks like a partial deployment issue
also removed redundant muzzle block, which appears to duplicate one of the blocks above