-
Notifications
You must be signed in to change notification settings - Fork 313
Migrate agent integration tests to gitlab #8448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate agent integration tests to gitlab #8448
Conversation
# Conflicts: # .gitlab-ci.yml
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046470
Total [baseline] (10.477 s) : 0, 10476930
Agent [candidate] (1.04 s) : 0, 1039615
Total [candidate] (10.483 s) : 0, 10483431
section appsec
Agent [baseline] (1.185 s) : 0, 1184955
Total [baseline] (10.749 s) : 0, 10749286
Agent [candidate] (1.187 s) : 0, 1187286
Total [candidate] (10.761 s) : 0, 10760535
section iast
Agent [baseline] (1.17 s) : 0, 1169619
Total [baseline] (11.028 s) : 0, 11027579
Agent [candidate] (1.173 s) : 0, 1172840
Total [candidate] (11.106 s) : 0, 11105789
section profiling
Agent [baseline] (1.26 s) : 0, 1260358
Total [baseline] (10.854 s) : 0, 10853701
Agent [candidate] (1.261 s) : 0, 1261177
Total [candidate] (10.849 s) : 0, 10848962
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.94 ms) : 0, 720940
BytebuddyAgent [candidate] (717.447 ms) : 0, 717447
GlobalTracer [baseline] (239.8 ms) : 0, 239800
GlobalTracer [candidate] (239.429 ms) : 0, 239429
AppSec [baseline] (56.079 ms) : 0, 56079
AppSec [candidate] (55.769 ms) : 0, 55769
Remote Config [baseline] (718.076 µs) : 0, 718
Remote Config [candidate] (694.171 µs) : 0, 694
Telemetry [baseline] (13.96 ms) : 0, 13960
Telemetry [candidate] (11.397 ms) : 0, 11397
section appsec
BytebuddyAgent [baseline] (736.528 ms) : 0, 736528
BytebuddyAgent [candidate] (737.633 ms) : 0, 737633
GlobalTracer [baseline] (236.983 ms) : 0, 236983
GlobalTracer [candidate] (237.305 ms) : 0, 237305
IAST [baseline] (21.447 ms) : 0, 21447
IAST [candidate] (21.772 ms) : 0, 21772
AppSec [baseline] (176.85 ms) : 0, 176850
AppSec [candidate] (177.525 ms) : 0, 177525
Remote Config [baseline] (658.817 µs) : 0, 659
Remote Config [candidate] (661.247 µs) : 0, 661
Telemetry [baseline] (8.293 ms) : 0, 8293
Telemetry [candidate] (8.355 ms) : 0, 8355
section iast
BytebuddyAgent [baseline] (835.83 ms) : 0, 835830
BytebuddyAgent [candidate] (837.929 ms) : 0, 837929
GlobalTracer [baseline] (229.43 ms) : 0, 229430
GlobalTracer [candidate] (230.57 ms) : 0, 230570
IAST [baseline] (22.785 ms) : 0, 22785
IAST [candidate] (22.911 ms) : 0, 22911
AppSec [baseline] (57.324 ms) : 0, 57324
AppSec [candidate] (57.127 ms) : 0, 57127
Remote Config [baseline] (616.933 µs) : 0, 617
Remote Config [candidate] (614.239 µs) : 0, 614
Telemetry [baseline] (8.723 ms) : 0, 8723
Telemetry [candidate] (8.737 ms) : 0, 8737
section profiling
BytebuddyAgent [baseline] (709.129 ms) : 0, 709129
BytebuddyAgent [candidate] (709.778 ms) : 0, 709778
GlobalTracer [baseline] (349.542 ms) : 0, 349542
GlobalTracer [candidate] (350.605 ms) : 0, 350605
AppSec [baseline] (55.345 ms) : 0, 55345
AppSec [candidate] (54.618 ms) : 0, 54618
Remote Config [baseline] (664.025 µs) : 0, 664
Remote Config [candidate] (672.695 µs) : 0, 673
Telemetry [baseline] (8.957 ms) : 0, 8957
Telemetry [candidate] (8.937 ms) : 0, 8937
ProfilingAgent [baseline] (96.346 ms) : 0, 96346
ProfilingAgent [candidate] (96.28 ms) : 0, 96280
Profiling [baseline] (96.37 ms) : 0, 96370
Profiling [candidate] (96.304 ms) : 0, 96304
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043234
Total [baseline] (8.669 s) : 0, 8669474
Agent [candidate] (1.041 s) : 0, 1041167
Total [candidate] (8.652 s) : 0, 8651590
section iast
Agent [baseline] (1.17 s) : 0, 1169940
Total [baseline] (9.221 s) : 0, 9220561
Agent [candidate] (1.172 s) : 0, 1172306
Total [candidate] (9.241 s) : 0, 9240976
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1176537
Total [baseline] (9.183 s) : 0, 9182884
Agent [candidate] (1.17 s) : 0, 1169918
Total [candidate] (9.18 s) : 0, 9179987
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1175658
Total [baseline] (9.228 s) : 0, 9227889
Agent [candidate] (1.175 s) : 0, 1174638
Total [candidate] (9.256 s) : 0, 9255661
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.878 ms) : 0, 720878
BytebuddyAgent [candidate] (719.314 ms) : 0, 719314
GlobalTracer [baseline] (239.338 ms) : 0, 239338
GlobalTracer [candidate] (239.91 ms) : 0, 239910
AppSec [baseline] (55.786 ms) : 0, 55786
AppSec [candidate] (55.576 ms) : 0, 55576
Remote Config [baseline] (687.502 µs) : 0, 688
Remote Config [candidate] (693.481 µs) : 0, 693
Telemetry [baseline] (11.565 ms) : 0, 11565
Telemetry [candidate] (10.697 ms) : 0, 10697
section iast
BytebuddyAgent [baseline] (835.396 ms) : 0, 835396
BytebuddyAgent [candidate] (838.106 ms) : 0, 838106
GlobalTracer [baseline] (229.968 ms) : 0, 229968
GlobalTracer [candidate] (230.18 ms) : 0, 230180
IAST [baseline] (22.749 ms) : 0, 22749
IAST [candidate] (22.805 ms) : 0, 22805
AppSec [baseline] (57.517 ms) : 0, 57517
AppSec [candidate] (56.88 ms) : 0, 56880
Remote Config [baseline] (607.343 µs) : 0, 607
Remote Config [candidate] (621.338 µs) : 0, 621
Telemetry [baseline] (8.732 ms) : 0, 8732
Telemetry [candidate] (8.737 ms) : 0, 8737
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.569 ms) : 0, 841569
BytebuddyAgent [candidate] (835.601 ms) : 0, 835601
GlobalTracer [baseline] (230.781 ms) : 0, 230781
GlobalTracer [candidate] (230.43 ms) : 0, 230430
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (22.779 ms) : 0, 22779
AppSec [baseline] (56.92 ms) : 0, 56920
AppSec [candidate] (56.908 ms) : 0, 56908
Remote Config [baseline] (602.249 µs) : 0, 602
Remote Config [candidate] (603.092 µs) : 0, 603
Telemetry [baseline] (8.662 ms) : 0, 8662
Telemetry [candidate] (8.676 ms) : 0, 8676
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (840.796 ms) : 0, 840796
BytebuddyAgent [candidate] (840.263 ms) : 0, 840263
GlobalTracer [baseline] (231.07 ms) : 0, 231070
GlobalTracer [candidate] (230.854 ms) : 0, 230854
IAST [baseline] (26.298 ms) : 0, 26298
IAST [candidate] (24.829 ms) : 0, 24829
AppSec [baseline] (53.319 ms) : 0, 53319
AppSec [candidate] (54.494 ms) : 0, 54494
Remote Config [baseline] (623.296 µs) : 0, 623
Remote Config [candidate] (606.88 µs) : 0, 607
Telemetry [baseline] (8.556 ms) : 0, 8556
Telemetry [candidate] (8.5 ms) : 0, 8500
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.761 ms) : 1737, 1786
. : milestone, 1761,
appsec_no_iast (1.755 ms) : 1729, 1781
. : milestone, 1755,
code_origins (1.683 ms) : 1646, 1720
. : milestone, 1683,
iast (1.518 ms) : 1493, 1542
. : milestone, 1518,
profiling (1.535 ms) : 1510, 1561
. : milestone, 1535,
tracing (1.492 ms) : 1467, 1516
. : milestone, 1492,
section candidate
no_agent (1.36 ms) : 1341, 1380
. : milestone, 1360,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.759 ms) : 1735, 1783
. : milestone, 1759,
code_origins (1.686 ms) : 1653, 1719
. : milestone, 1686,
iast (1.522 ms) : 1499, 1546
. : milestone, 1522,
profiling (1.53 ms) : 1506, 1554
. : milestone, 1530,
tracing (1.499 ms) : 1474, 1524
. : milestone, 1499,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section baseline
no_agent (385.114 µs) : 365, 405
. : milestone, 385,
iast (515.037 µs) : 493, 537
. : milestone, 515,
iast_FULL (728.91 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (552.284 µs) : 531, 574
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (509.315 µs) : 487, 532
. : milestone, 509,
iast_INACTIVE (472.542 µs) : 451, 494
. : milestone, 473,
iast_TELEMETRY_OFF (494.656 µs) : 472, 517
. : milestone, 495,
tracing (457.053 µs) : 436, 479
. : milestone, 457,
section candidate
no_agent (381.428 µs) : 361, 401
. : milestone, 381,
iast (516.581 µs) : 494, 540
. : milestone, 517,
iast_FULL (729.167 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (562.444 µs) : 540, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (516.432 µs) : 493, 539
. : milestone, 516,
iast_INACTIVE (460.492 µs) : 439, 482
. : milestone, 460,
iast_TELEMETRY_OFF (497.388 µs) : 474, 521
. : milestone, 497,
tracing (458.855 µs) : 438, 479
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.367 ms) : 2323, 2411
. : milestone, 2367,
iast (2.115 ms) : 2060, 2170
. : milestone, 2115,
iast_GLOBAL (2.16 ms) : 2105, 2216
. : milestone, 2160,
profiling (1.967 ms) : 1923, 2010
. : milestone, 1967,
tracing (1.961 ms) : 1918, 2003
. : milestone, 1961,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.378 ms) : 2334, 2421
. : milestone, 2378,
iast (2.121 ms) : 2066, 2176
. : milestone, 2121,
iast_GLOBAL (2.167 ms) : 2112, 2223
. : milestone, 2167,
profiling (2.475 ms) : 2292, 2658
. : milestone, 2475,
tracing (1.949 ms) : 1907, 1991
. : milestone, 1949,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~ee55e639a9, baseline=1.47.0-SNAPSHOT~5a2c959566
dateFormat X
axisFormat %s
section baseline
no_agent (15.547 s) : 15547000, 15547000
. : milestone, 15547000,
appsec (14.919 s) : 14919000, 14919000
. : milestone, 14919000,
iast (18.399 s) : 18399000, 18399000
. : milestone, 18399000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
. : milestone, 17830000,
profiling (15.688 s) : 15688000, 15688000
. : milestone, 15688000,
tracing (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
section candidate
no_agent (15.59 s) : 15590000, 15590000
. : milestone, 15590000,
appsec (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
iast (18.665 s) : 18665000, 18665000
. : milestone, 18665000,
iast_GLOBAL (17.955 s) : 17955000, 17955000
. : milestone, 17955000,
profiling (15.478 s) : 15478000, 15478000
. : milestone, 15478000,
tracing (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good. Thanks for the refactoring and enabling us to run tests locally!
What Does This Do
This PR moves agent integration tests to Gitlab from CircleCI. Additionally, I extracted the testcontainer and setup logic to a base test class,
AbstractTraceAgentTest
, so that tests can be run locally on dev machines.Motivation
Eventually, all jobs will be moved from CircleCI to Gitlab
Additional Notes
Test results upload to Datadog correctly works. Visualizing results in Gitlab itself doesn't work currently.
I did not remove the CircleCI jobs because the last removal was reverted in #8429
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]