Config Consistency Round 2 #8489

mhlidd · 2025-03-03T18:45:14Z

What Does This Do

This PR updates the config implementations for the following configurations:

DD_LOGS_INJECTION default value to be false
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED default value to be true

This PR also adds support for the following configuration: DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED, which takes in a string and stores a list of configurations to run the "breaking change" version of.

Motivation

The SDK Capabilities team is working on modifying configurations to be consistent across all SDKs. This PR aims to update configs in dd-trace-java to match the following RFC.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-1037

pr-commenter · 2025-03-03T19:12:08Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/config_consistency
git_commit_date	1742305462	1742327756
git_commit_sha	`ffa2073`	`884e147`
release_version	1.48.0-SNAPSHOT~ffa2073a5c	1.48.0-SNAPSHOT~884e147c0b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1742330353	1742330353
ci_job_id	853810566	853810566
ci_pipeline_id	59243301	59243301
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-psmztocj-project-304-concurrent-0-n6pyxfoo 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-psmztocj-project-304-concurrent-0-n6pyxfoo 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040983
Total [baseline] (10.577 s) : 0, 10576684
Agent [candidate] (1.046 s) : 0, 1045878
Total [candidate] (10.477 s) : 0, 10477076
section appsec
Agent [baseline] (1.181 s) : 0, 1180798
Total [baseline] (10.795 s) : 0, 10794940
Agent [candidate] (1.183 s) : 0, 1182739
Total [candidate] (10.754 s) : 0, 10753791
section iast
Agent [baseline] (1.173 s) : 0, 1173025
Total [baseline] (10.967 s) : 0, 10966718
Agent [candidate] (1.172 s) : 0, 1172225
Total [candidate] (10.958 s) : 0, 10958220
section profiling
Agent [baseline] (1.263 s) : 0, 1262644
Total [baseline] (10.836 s) : 0, 10835846
Agent [candidate] (1.259 s) : 0, 1259497
Total [candidate] (10.834 s) : 0, 10833761

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	appsec	1.181 s	139.815 ms (13.4%)
Agent	iast	1.173 s	132.042 ms (12.7%)
Agent	profiling	1.263 s	221.661 ms (21.3%)
Total	tracing	10.577 s	-
Total	appsec	10.795 s	218.256 ms (2.1%)
Total	iast	10.967 s	390.034 ms (3.7%)
Total	profiling	10.836 s	259.161 ms (2.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.183 s	136.86 ms (13.1%)
Agent	iast	1.172 s	126.347 ms (12.1%)
Agent	profiling	1.259 s	213.619 ms (20.4%)
Total	tracing	10.477 s	-
Total	appsec	10.754 s	276.715 ms (2.6%)
Total	iast	10.958 s	481.144 ms (4.6%)
Total	profiling	10.834 s	356.686 ms (3.4%)

gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.578 ms) : 0, 717578
BytebuddyAgent [candidate] (723.491 ms) : 0, 723491
GlobalTracer [baseline] (239.384 ms) : 0, 239384
GlobalTracer [candidate] (240.721 ms) : 0, 240721
AppSec [baseline] (54.547 ms) : 0, 54547
AppSec [candidate] (54.94 ms) : 0, 54940
Remote Config [baseline] (691.234 µs) : 0, 691
Remote Config [candidate] (692.382 µs) : 0, 692
Telemetry [baseline] (13.572 ms) : 0, 13572
Telemetry [candidate] (10.747 ms) : 0, 10747
section appsec
BytebuddyAgent [baseline] (734.258 ms) : 0, 734258
BytebuddyAgent [candidate] (735.226 ms) : 0, 735226
GlobalTracer [baseline] (235.66 ms) : 0, 235660
GlobalTracer [candidate] (236.418 ms) : 0, 236418
IAST [baseline] (21.475 ms) : 0, 21475
IAST [candidate] (21.786 ms) : 0, 21786
AppSec [baseline] (175.607 ms) : 0, 175607
AppSec [candidate] (175.936 ms) : 0, 175936
Remote Config [baseline] (656.875 µs) : 0, 657
Remote Config [candidate] (666.591 µs) : 0, 667
Telemetry [baseline] (8.631 ms) : 0, 8631
Telemetry [candidate] (8.364 ms) : 0, 8364
section iast
BytebuddyAgent [baseline] (839.362 ms) : 0, 839362
BytebuddyAgent [candidate] (838.538 ms) : 0, 838538
GlobalTracer [baseline] (230.319 ms) : 0, 230319
GlobalTracer [candidate] (230.076 ms) : 0, 230076
IAST [baseline] (22.902 ms) : 0, 22902
IAST [candidate] (22.788 ms) : 0, 22788
AppSec [baseline] (55.897 ms) : 0, 55897
AppSec [candidate] (56.298 ms) : 0, 56298
Remote Config [baseline] (599.233 µs) : 0, 599
Remote Config [candidate] (604.818 µs) : 0, 605
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (8.67 ms) : 0, 8670
section profiling
BytebuddyAgent [baseline] (710.719 ms) : 0, 710719
BytebuddyAgent [candidate] (709.306 ms) : 0, 709306
GlobalTracer [baseline] (349.977 ms) : 0, 349977
GlobalTracer [candidate] (350.146 ms) : 0, 350146
AppSec [baseline] (54.547 ms) : 0, 54547
AppSec [candidate] (53.553 ms) : 0, 53553
Remote Config [baseline] (676.346 µs) : 0, 676
Remote Config [candidate] (665.606 µs) : 0, 666
Telemetry [baseline] (9.063 ms) : 0, 9063
Telemetry [candidate] (8.971 ms) : 0, 8971
ProfilingAgent [baseline] (96.877 ms) : 0, 96877
ProfilingAgent [candidate] (96.204 ms) : 0, 96204
Profiling [baseline] (96.901 ms) : 0, 96901
Profiling [candidate] (96.228 ms) : 0, 96228

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050164
Total [baseline] (8.721 s) : 0, 8720722
Agent [candidate] (1.039 s) : 0, 1039289
Total [candidate] (8.702 s) : 0, 8702058
section iast
Agent [baseline] (1.178 s) : 0, 1177829
Total [baseline] (9.253 s) : 0, 9253127
Agent [candidate] (1.173 s) : 0, 1173216
Total [candidate] (9.245 s) : 0, 9244924
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1176811
Total [baseline] (9.222 s) : 0, 9221799
Agent [candidate] (1.174 s) : 0, 1174060
Total [candidate] (9.214 s) : 0, 9214197
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172693
Total [baseline] (9.27 s) : 0, 9269924
Agent [candidate] (1.18 s) : 0, 1180138
Total [candidate] (9.261 s) : 0, 9261337

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.178 s	127.665 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.177 s	126.647 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.173 s	122.529 ms (11.7%)
Total	tracing	8.721 s	-
Total	iast	9.253 s	532.405 ms (6.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.222 s	501.077 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.27 s	549.201 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	iast	1.173 s	133.927 ms (12.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	134.771 ms (13.0%)
Agent	iast_TELEMETRY_OFF	1.18 s	140.848 ms (13.6%)
Total	tracing	8.702 s	-
Total	iast	9.245 s	542.866 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.214 s	512.139 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.261 s	559.279 ms (6.4%)

gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.021 ms) : 0, 726021
BytebuddyAgent [candidate] (717.533 ms) : 0, 717533
GlobalTracer [baseline] (241.58 ms) : 0, 241580
GlobalTracer [candidate] (240.338 ms) : 0, 240338
AppSec [baseline] (55.139 ms) : 0, 55139
AppSec [candidate] (54.738 ms) : 0, 54738
Remote Config [baseline] (705.761 µs) : 0, 706
Remote Config [candidate] (687.883 µs) : 0, 688
Telemetry [baseline] (11.378 ms) : 0, 11378
Telemetry [candidate] (10.795 ms) : 0, 10795
section iast
BytebuddyAgent [baseline] (842.921 ms) : 0, 842921
BytebuddyAgent [candidate] (838.835 ms) : 0, 838835
GlobalTracer [baseline] (230.584 ms) : 0, 230584
GlobalTracer [candidate] (230.294 ms) : 0, 230294
AppSec [baseline] (56.482 ms) : 0, 56482
AppSec [candidate] (56.656 ms) : 0, 56656
Remote Config [baseline] (603.132 µs) : 0, 603
Remote Config [candidate] (620.812 µs) : 0, 621
Telemetry [baseline] (8.782 ms) : 0, 8782
Telemetry [candidate] (8.784 ms) : 0, 8784
IAST [baseline] (23.132 ms) : 0, 23132
IAST [candidate] (22.782 ms) : 0, 22782
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.868 ms) : 0, 840868
BytebuddyAgent [candidate] (839.079 ms) : 0, 839079
GlobalTracer [baseline] (231.885 ms) : 0, 231885
GlobalTracer [candidate] (230.563 ms) : 0, 230563
AppSec [baseline] (56.485 ms) : 0, 56485
AppSec [candidate] (56.791 ms) : 0, 56791
Remote Config [baseline] (607.636 µs) : 0, 608
Remote Config [candidate] (609.409 µs) : 0, 609
Telemetry [baseline] (8.743 ms) : 0, 8743
Telemetry [candidate] (8.775 ms) : 0, 8775
IAST [baseline] (22.92 ms) : 0, 22920
IAST [candidate] (22.957 ms) : 0, 22957
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.44 ms) : 0, 837440
BytebuddyAgent [candidate] (844.793 ms) : 0, 844793
GlobalTracer [baseline] (231.901 ms) : 0, 231901
GlobalTracer [candidate] (231.555 ms) : 0, 231555
AppSec [baseline] (56.365 ms) : 0, 56365
AppSec [candidate] (56.476 ms) : 0, 56476
Remote Config [baseline] (613.014 µs) : 0, 613
Remote Config [candidate] (610.68 µs) : 0, 611
Telemetry [baseline] (8.669 ms) : 0, 8669
Telemetry [candidate] (8.676 ms) : 0, 8676
IAST [baseline] (22.406 ms) : 0, 22406
IAST [candidate] (22.551 ms) : 0, 22551

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-03-18T20:09:29	2025-03-18T20:17:14
git_branch	master	mhlidd/config_consistency
git_commit_date	1742305462	1742327756
git_commit_sha	`ffa2073`	`884e147`
release_version	1.48.0-SNAPSHOT~ffa2073a5c	1.48.0-SNAPSHOT~884e147c0b
start_time	2025-03-18T20:09:15	2025-03-18T20:16:59

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1742329430	1742329430
ci_job_id	853810567	853810567
ci_pipeline_id	59243301	59243301
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-psmztocj-project-304-concurrent-1-4sdofmnk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-psmztocj-project-304-concurrent-1-4sdofmnk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.622 µs) : 362, 401
.   : milestone, 382,
iast (512.547 µs) : 491, 534
.   : milestone, 513,
iast_FULL (732.271 µs) : 710, 754
.   : milestone, 732,
iast_GLOBAL (572.628 µs) : 550, 596
.   : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (511.849 µs) : 490, 534
.   : milestone, 512,
iast_INACTIVE (466.183 µs) : 443, 489
.   : milestone, 466,
iast_TELEMETRY_OFF (502.137 µs) : 479, 525
.   : milestone, 502,
tracing (456.896 µs) : 436, 478
.   : milestone, 457,
section candidate
no_agent (380.431 µs) : 360, 401
.   : milestone, 380,
iast (518.93 µs) : 497, 541
.   : milestone, 519,
iast_FULL (732.022 µs) : 710, 754
.   : milestone, 732,
iast_GLOBAL (556.289 µs) : 534, 579
.   : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (513.711 µs) : 492, 536
.   : milestone, 514,
iast_INACTIVE (465.316 µs) : 444, 487
.   : milestone, 465,
iast_TELEMETRY_OFF (504.231 µs) : 482, 526
.   : milestone, 504,
tracing (458.642 µs) : 438, 479
.   : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.622 µs [362.029 µs, 401.215 µs]	-
iast	512.547 µs [490.6 µs, 534.495 µs]	130.925 µs (34.3%)
iast_FULL	732.271 µs [710.397 µs, 754.144 µs]	350.648 µs (91.9%)
iast_GLOBAL	572.628 µs [549.54 µs, 595.716 µs]	191.006 µs (50.1%)
iast_HARDCODED_SECRET_DISABLED	511.849 µs [490.153 µs, 533.546 µs]	130.227 µs (34.1%)
iast_INACTIVE	466.183 µs [443.055 µs, 489.31 µs]	84.56 µs (22.2%)
iast_TELEMETRY_OFF	502.137 µs [479.235 µs, 525.038 µs]	120.515 µs (31.6%)
tracing	456.896 µs [436.285 µs, 477.507 µs]	75.274 µs (19.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.431 µs [359.917 µs, 400.945 µs]	-
iast	518.93 µs [496.853 µs, 541.008 µs]	138.5 µs (36.4%)
iast_FULL	732.022 µs [710.167 µs, 753.876 µs]	351.591 µs (92.4%)
iast_GLOBAL	556.289 µs [533.71 µs, 578.869 µs]	175.859 µs (46.2%)
iast_HARDCODED_SECRET_DISABLED	513.711 µs [491.79 µs, 535.632 µs]	133.281 µs (35.0%)
iast_INACTIVE	465.316 µs [443.85 µs, 486.783 µs]	84.886 µs (22.3%)
iast_TELEMETRY_OFF	504.231 µs [482.323 µs, 526.139 µs]	123.801 µs (32.5%)
tracing	458.642 µs [437.927 µs, 479.358 µs]	78.212 µs (20.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1378
.   : milestone, 1359,
appsec (1.728 ms) : 1704, 1751
.   : milestone, 1728,
appsec_no_iast (1.748 ms) : 1724, 1772
.   : milestone, 1748,
code_origins (1.669 ms) : 1642, 1696
.   : milestone, 1669,
iast (1.507 ms) : 1482, 1532
.   : milestone, 1507,
profiling (1.521 ms) : 1498, 1544
.   : milestone, 1521,
tracing (1.478 ms) : 1453, 1502
.   : milestone, 1478,
section candidate
no_agent (1.359 ms) : 1340, 1379
.   : milestone, 1359,
appsec (1.74 ms) : 1717, 1763
.   : milestone, 1740,
appsec_no_iast (1.724 ms) : 1699, 1749
.   : milestone, 1724,
code_origins (1.679 ms) : 1651, 1707
.   : milestone, 1679,
iast (1.494 ms) : 1469, 1519
.   : milestone, 1494,
profiling (1.514 ms) : 1491, 1538
.   : milestone, 1514,
tracing (1.504 ms) : 1479, 1528
.   : milestone, 1504,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.34 ms, 1.378 ms]	-
appsec	1.728 ms [1.704 ms, 1.751 ms]	368.731 µs (27.1%)
appsec_no_iast	1.748 ms [1.724 ms, 1.772 ms]	389.363 µs (28.7%)
code_origins	1.669 ms [1.642 ms, 1.696 ms]	310.321 µs (22.8%)
iast	1.507 ms [1.482 ms, 1.532 ms]	147.993 µs (10.9%)
profiling	1.521 ms [1.498 ms, 1.544 ms]	162.172 µs (11.9%)
tracing	1.478 ms [1.453 ms, 1.502 ms]	119.117 µs (8.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.34 ms, 1.379 ms]	-
appsec	1.74 ms [1.717 ms, 1.763 ms]	381.038 µs (28.0%)
appsec_no_iast	1.724 ms [1.699 ms, 1.749 ms]	365.255 µs (26.9%)
code_origins	1.679 ms [1.651 ms, 1.707 ms]	319.525 µs (23.5%)
iast	1.494 ms [1.469 ms, 1.519 ms]	134.765 µs (9.9%)
profiling	1.514 ms [1.491 ms, 1.538 ms]	155.211 µs (11.4%)
tracing	1.504 ms [1.479 ms, 1.528 ms]	144.508 µs (10.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/config_consistency
git_commit_date	1742305462	1742327756
git_commit_sha	`ffa2073`	`884e147`
release_version	1.48.0-SNAPSHOT~ffa2073a5c	1.48.0-SNAPSHOT~884e147c0b

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1742329961	1742329961
ci_job_id	853810568	853810568
ci_pipeline_id	59243301	59243301
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-psmztocj-project-304-concurrent-2-51ebmpzx 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-psmztocj-project-304-concurrent-2-51ebmpzx 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.347 ms) : 2303, 2391
.   : milestone, 2347,
iast (2.117 ms) : 2061, 2173
.   : milestone, 2117,
iast_GLOBAL (2.159 ms) : 2103, 2215
.   : milestone, 2159,
profiling (1.992 ms) : 1947, 2038
.   : milestone, 1992,
tracing (1.95 ms) : 1908, 1993
.   : milestone, 1950,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.337 ms) : 2293, 2381
.   : milestone, 2337,
iast (2.12 ms) : 2064, 2176
.   : milestone, 2120,
iast_GLOBAL (2.157 ms) : 2101, 2214
.   : milestone, 2157,
profiling (1.975 ms) : 1931, 2019
.   : milestone, 1975,
tracing (1.952 ms) : 1909, 1995
.   : milestone, 1952,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.347 ms [2.303 ms, 2.391 ms]	873.601 µs (59.3%)
iast	2.117 ms [2.061 ms, 2.173 ms]	643.252 µs (43.7%)
iast_GLOBAL	2.159 ms [2.103 ms, 2.215 ms]	685.389 µs (46.5%)
profiling	1.992 ms [1.947 ms, 2.038 ms]	518.806 µs (35.2%)
tracing	1.95 ms [1.908 ms, 1.993 ms]	476.655 µs (32.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.337 ms [2.293 ms, 2.381 ms]	866.328 µs (58.9%)
iast	2.12 ms [2.064 ms, 2.176 ms]	649.351 µs (44.2%)
iast_GLOBAL	2.157 ms [2.101 ms, 2.214 ms]	686.893 µs (46.7%)
profiling	1.975 ms [1.931 ms, 2.019 ms]	504.819 µs (34.3%)
tracing	1.952 ms [1.909 ms, 1.995 ms]	481.28 µs (32.7%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~884e147c0b, baseline=1.48.0-SNAPSHOT~ffa2073a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.473 s) : 15473000, 15473000
.   : milestone, 15473000,
appsec (15.213 s) : 15213000, 15213000
.   : milestone, 15213000,
iast (18.541 s) : 18541000, 18541000
.   : milestone, 18541000,
iast_GLOBAL (18.073 s) : 18073000, 18073000
.   : milestone, 18073000,
profiling (15.154 s) : 15154000, 15154000
.   : milestone, 15154000,
tracing (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
appsec (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
iast (18.729 s) : 18729000, 18729000
.   : milestone, 18729000,
iast_GLOBAL (18.278 s) : 18278000, 18278000
.   : milestone, 18278000,
profiling (15.341 s) : 15341000, 15341000
.   : milestone, 15341000,
tracing (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.473 s [15.473 s, 15.473 s]	-
appsec	15.213 s [15.213 s, 15.213 s]	-260.0 ms (-1.7%)
iast	18.541 s [18.541 s, 18.541 s]	3.068 s (19.8%)
iast_GLOBAL	18.073 s [18.073 s, 18.073 s]	2.6 s (16.8%)
profiling	15.154 s [15.154 s, 15.154 s]	-319.0 ms (-2.1%)
tracing	14.993 s [14.993 s, 14.993 s]	-480.0 ms (-3.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.015 s [15.015 s, 15.015 s]	-
appsec	15.002 s [15.002 s, 15.002 s]	-13.0 ms (-0.1%)
iast	18.729 s [18.729 s, 18.729 s]	3.714 s (24.7%)
iast_GLOBAL	18.278 s [18.278 s, 18.278 s]	3.263 s (21.7%)
profiling	15.341 s [15.341 s, 15.341 s]	326.0 ms (2.2%)
tracing	14.912 s [14.912 s, 14.912 s]	-103.0 ms (-0.7%)

github-actions · 2025-03-04T21:06:36Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

mcculls · 2025-03-11T11:26:02Z

...ng/src/main/groovy/datadog/trace/agent/test/log/injection/LogContextInjectionTestBase.groovy

@@ -34,6 +34,10 @@ abstract class LogContextInjectionTestBase extends AgentTestRunner {

  abstract Map<String, Object> getMap()

+  def setup() {
+    injectSysConfig("logs.injection.enabled", "true")


~~this should already be the default? https://github.com/DataDog/dd-trace-java/blob/master/dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java#L105~~

never mind - I see the default is being changed below

this will be a breaking change for a lot of customers, is there a plan to mitigate this?

Yes, I can add it under the DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED flag.

This change could be dropped, now we're only changing the default when enabling breaking changes

internal-api/src/main/java/datadog/trace/api/Config.java

mcculls · 2025-03-11T11:45:16Z

Main question I have is around changing the default value of DD_LOGS_INJECTION to false

This would constitute a breaking change - the RFC says this should be mitigated with DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED but I don't see that being used here, it only introduces the flag.

I'd suggest creating a PR to introduce DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED which will be trivial to merge.

Then a second PR to make the logging config changes, which uses DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED to avoid causing a breaking change for existing users. (At least until the next major release)

mhlidd · 2025-03-11T20:44:14Z

internal-api/src/main/java/datadog/trace/api/Config.java

+    if (experimentalFeaturesEnabled.contains(
+        propertyNameToEnvironmentVariableName(LOGS_INJECTION))) {
+      logsInjectionEnabled =
+          configProvider.getBoolean(
+              LOGS_INJECTION_ENABLED, DEFAULT_LOGS_INJECTION_ENABLED, LOGS_INJECTION);
+    } else {
+      logsInjectionEnabled =
+          configProvider.getBoolean(LOGS_INJECTION_ENABLED, false, LOGS_INJECTION);
+    }


@mcculls Is this the best way to check if the breaking change version should be used?

Hi @mhlidd - TBH I expected this to be the reverse, i.e. keep the log injection default as it is and only set it to false when LOGS_INJECTION_ENABLED is added to DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED

In other words, an existing user on v1.47.0 should not find log injection suddenly turned off when upgrading to v1.48.0. If they were upgrading to v2.0.0 then that may be acceptable, but not for a minor release.

Therefore I expected to see the default for LOGS_INJECTION_ENABLED to stay the same, and only change if LOGS_INJECTION_ENABLED was added to DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED.

Could you clarify the expectation with the RFC authors about how such a change should be included in a minor release.

@mcculls Thanks for catching this mistake I made 😅. You're right, the default behavior for LOGS_INJECTION_ENABLED should remain the same (default value is true). Only if it is under the feature flag should the default value be changed to false. Let me update with that change right now!

@mcculls After talking to the team, we will move towards enabling DD_LOGS_INJECTION=true by default in Q2. That will be an easy rollback task for when the team decides to make that change.

dd-smoke-tests/src/main/groovy/datadog/smoketest/AbstractSmokeTest.groovy

dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java

dd-trace-ot/correlation-id-injection/src/test/groovy/CorrelationIdInjectorTest.groovy

internal-api/src/main/java/datadog/trace/api/Config.java

mcculls

Just a minor suggestion about postponing the update to DEFAULT_LOGS_INJECTION_ENABLED until we get round to preparing for 2.x - otherwise looks good

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | org.flywaydb.flyway | plugin | misk/gradle/libs.versions.toml | gradle | minor | `11.6.0` -> `11.7.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.15.0` -> `2.16.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | --- ### Release Notes <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.11.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3110) *2025-04-09* - Fix: Clear the deflater's byte array reference - New: Faster implementation of `String.decodeHex()` on Kotlin/JS. - New: Declare `EXACTLY_ONCE` execution for blocks like `Closeable.use {}` and `FileSystem.read {}`. - Upgrade: \[Kotlin 2.1.20]\[kotlin\_2\_1\_20]. </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.16.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2160) - \[Feat]: support `com.android.test` projects. - \[Feat]: support typesafe project accessors with opt-in. ```kotlin dependencyAnalysis { useTypesafeProjectAccessors(true) // false by default } ``` </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.48.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.1): 1.48.1 ### Components #### Tracer internal logging - 🐛 Remove print line causing unnecessary logs ([#8687](DataDog/dd-trace-java#8687) - [@sarahchen6](https://github.com/sarahchen6)) ### [`v1.48.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.0): 1.48.0 ### Known Bugs > \[!NOTE] > If you are experiencing issues with spamming timeout logs, please update to the [latest version](https://github.com/DataDog/dd-trace-java/releases/latest) or set [JDK_SOCKET_ENABLED](https://github.com/DataDog/dd-trace-java/blob/33fc3c9a9b7cda3beda88b8b3e5224ae2b10764a/dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java#L98) to false. ### Components #### Application Security Management (IAST) - ✨ Fix vulnerability location org.jose4j.lang.HashUtil ([#8610](DataDog/dd-trace-java#8610) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness in oracle.ucp.util.OpaqueString ([#8609](DataDog/dd-trace-java#8609) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak hash false positive in oracle.security.o5logon.O5Logon ([#8608](DataDog/dd-trace-java#8608) - [@jandro996](https://github.com/jandro996)) - 🐛 Prevent before callsites targeting constructors in super calls ([#8549](DataDog/dd-trace-java#8549) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Application Security Management (WAF) - ✨ Update login events public SDK to V2 ([#8620](DataDog/dd-trace-java#8620) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#8573](DataDog/dd-trace-java#8573) - [@jandro996](https://github.com/jandro996)) - ✨ Improve detection of missing request end events ([#8510](DataDog/dd-trace-java#8510) - [@smola](https://github.com/smola)) - 🧹 Remove remote configuration for API Security sampling rate ([#8486](DataDog/dd-trace-java#8486) - [@smola](https://github.com/smola)) - ✨ Add setUser to user monitoring SDK ([#8482](DataDog/dd-trace-java#8482) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add missing address for signup event ([#8469](DataDog/dd-trace-java#8469) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Allow login events SDK to be used with appsec disabled ([#8464](DataDog/dd-trace-java#8464) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for endpoint discovery in spring mvc ([#8352](DataDog/dd-trace-java#8352) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ New API Security sampling algorithm ([#8178](DataDog/dd-trace-java#8178) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Build & Tooling - ✨ Add buffer size customizability to JDK UDS support ([#8629](DataDog/dd-trace-java#8629) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Add JDK built-in support for UDS on Java 16+ ([#8314](DataDog/dd-trace-java#8314) - [@sarahchen6](https://github.com/sarahchen6)) #### Configuration at Runtime - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#8573](DataDog/dd-trace-java#8573) - [@jandro996](https://github.com/jandro996)) #### Continuous Integration Visibility - 🐛 Prevent double reporting of Scalatest events when using SBT with test forking ([#8682](DataDog/dd-trace-java#8682) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Shutdown CI Visibility test event handlers before tracer ([#8677](DataDog/dd-trace-java#8677) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Do not apply JUnit 4 instrumentation to MUnit runners ([#8675](DataDog/dd-trace-java#8675), [#8683](DataDog/dd-trace-java#8683) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Remove error log when source path resolution fails on isModified check ([#8663](DataDog/dd-trace-java#8663) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement tests reordering for JUnit 4 ([#8650](DataDog/dd-trace-java#8650) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Set default Attempt to Fix retries if none provided from the backend ([#8615](DataDog/dd-trace-java#8615) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Allow to manually set PR info ([#8566](DataDog/dd-trace-java#8566) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Test Optimization init when repo root cannot be determined ([#8533](DataDog/dd-trace-java#8533) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add capabilities tagging ([#8499](DataDog/dd-trace-java#8499), [#8540](DataDog/dd-trace-java#8540) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - 🐛 Remove dependency on bash from crash/oome uploder scripts ([#8652](DataDog/dd-trace-java#8652) - [@jbachorik](https://github.com/jbachorik)) #### Data Streams Monitoring - ✨ e2e pipeline configuration when data jobs is enabled ([#8553](DataDog/dd-trace-java#8553) - [@kr-igor](https://github.com/kr-igor)) #### Dynamic Instrumentation - 🐛 Fix In-Product when config is empty ([#8679](DataDog/dd-trace-java#8679) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add support for filtering shaded third-party libs ([#8612](DataDog/dd-trace-java#8612) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add In-Product Enablement ([#8587](DataDog/dd-trace-java#8587) - [@jpbempel](https://github.com/jpbempel)) - ✨⚡ Reduce footprint of SourceFile tracking ([#8524](DataDog/dd-trace-java#8524) - [@jpbempel](https://github.com/jpbempel)) - ✨⚡ Optimize the SourceFile tracking ([#8520](DataDog/dd-trace-java#8520) - [@jpbempel](https://github.com/jpbempel)) #### OpenTracing - 🧹 Remove activeScope() use in OpenTracing shim ([#8478](DataDog/dd-trace-java#8478) - [@mcculls](https://github.com/mcculls)) #### Profiling - ✨ Add profiler env check command to AgentCLI ([#8671](DataDog/dd-trace-java#8671) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.23.0 ([#8668](DataDog/dd-trace-java#8668) - [@jbachorik](https://github.com/jbachorik)) - Fix a crash related to ElfParser::loadSymbolTable ([#191](DataDog/dd-trace-java#191)) by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#192 - Unwind String.indexOf intrinsic on AArch64 by [@MattAlp](https://github.com/MattAlp) in DataDog/java-profiler#193 - Fix Java 24 support by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#194 - A set of fixes related to clang, aarch64 and musl pecularities of vmstructs stack unwinder by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#199 - 🐛 Remove process information from JFR recording ([#8661](DataDog/dd-trace-java#8661) - [@r1viollet](https://github.com/r1viollet)) - 🐛 Make TempLocationManager USER aware ([#8605](DataDog/dd-trace-java#8605) - [@jbachorik](https://github.com/jbachorik)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#8561](DataDog/dd-trace-java#8561) - [@wmouchere](https://github.com/wmouchere)) #### Telemetry - 🐛 Fix appsec.rasp.error and appsec.waf.error telemetry metrics ([#8624](DataDog/dd-trace-java#8624) - [@jandro996](https://github.com/jandro996)) - ✨ Create metric: appsec.rasp.rule.skipped ([#8618](DataDog/dd-trace-java#8618) - [@jandro996](https://github.com/jandro996)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#8561](DataDog/dd-trace-java#8561) - [@wmouchere](https://github.com/wmouchere)) #### Testing - 🧹 Simplify ssi tests one-pipeline ([#8558](DataDog/dd-trace-java#8558) - [@robertomonteromiguel](https://github.com/robertomonteromiguel)) - ✨ Add smoke tests for java's concurrent API ([#8438](DataDog/dd-trace-java#8438) - [@sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - ✨ Adding Support for `TRACE_PROPAGATION_BEHAVIOR_EXTRACT` ([#8535](DataDog/dd-trace-java#8535) - [@mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Ensure shaded helpers have unique names ([#8559](DataDog/dd-trace-java#8559) - [@amarziali](https://github.com/amarziali)) - ✨ Support common config sources for user-provided git info ([#8547](DataDog/dd-trace-java#8547) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Make the default config sources more robust when a security manager is installed ([#8544](DataDog/dd-trace-java#8544) - [@mcculls](https://github.com/mcculls)) - ✨ Support targeting services with configurations in stable configuration file ([#8526](DataDog/dd-trace-java#8526) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` ([#8296](DataDog/dd-trace-java#8296) - [@mhlidd](https://github.com/mhlidd)) #### Tracer internal logging - 🐛 Add missing debug log for the cloudPayloadTaggingServices config ([#8600](DataDog/dd-trace-java#8600) - [@ygree](https://github.com/ygree)) - ✨ Add the possibility to output the logs of the Java tracer in JSON ([#8083](DataDog/dd-trace-java#8083) - [@cecile75](https://github.com/cecile75)) #### Tracer public API - ✨ Introducing `DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED` Config ([#8536](DataDog/dd-trace-java#8536) - [@mhlidd](https://github.com/mhlidd)) - ✨ Config Consistency Round 2 ([#8489](DataDog/dd-trace-java#8489) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### - 🐛 Fix NPE in getMdcCopy of LoggingEventInstrumentation ([#8599](DataDog/dd-trace-java#8599) - [@ygree](https://github.com/ygree)) #### Apache Spark instrumentation - ✨ Instrument Runtime.exit() to finish spark application spans ([#8572](DataDog/dd-trace-java#8572) - [@paul-laffon-dd](https://github.com/paul-laffon-dd)) - ✨ Configure OpenLineage if present in Spark instrumentation ([#8541](DataDog/dd-trace-java#8541) - [@mobuchowski](https://github.com/mobuchowski)) #### Armeria Instrumentation - ✨ Support armeria grpc 1.32.3 ([#8606](DataDog/dd-trace-java#8606) - [@github-actions](https://github.com/github-actions)\[bot]) #### AWS DynamoDB Instrumentation - ✨ Create DynamoDB instrumentation + add span pointers for `updateItem` and `deleteItem` ([#8490](DataDog/dd-trace-java#8490) - [@nhulston](https://github.com/nhulston)) #### AWS SDK instrumentation - ✨ Add DynamoDB in DEFAULT_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES ([#8595](DataDog/dd-trace-java#8595) - [@joeyzhao2018](https://github.com/joeyzhao2018)) #### Azure Functions instrumentation - ✨ Enable tracer computed trace metrics by default for Azure Functions ([#8518](DataDog/dd-trace-java#8518) - [@duncanpharvey](https://github.com/duncanpharvey)) - 💡 Add azure-functions instrumentation ([#8432](DataDog/dd-trace-java#8432) - [@duncanpharvey](https://github.com/duncanpharvey)) #### Core Java language instrumentation - 🐛 Fix ForkJoinPool.execute() instrumentation on Java 21+ ([#8560](DataDog/dd-trace-java#8560) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Eclipse Vert.x instrumentation - ✨ Add vertx postgresql client instrumentation ([#8471](DataDog/dd-trace-java#8471) - [@vandonr](https://github.com/vandonr) - thanks for the contribution!) #### Kafka instrumentation - ✨ Support and test kafka-clients 4 ([#8581](DataDog/dd-trace-java#8581) - [@amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - ✨ Avoid disconnected traces when using Kotlin flowOn ([#8651](DataDog/dd-trace-java#8651) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🧹 Migrate OtelContext wrapper to new internal Context API ([#8645](DataDog/dd-trace-java#8645) - [@mcculls](https://github.com/mcculls)) #### Spring instrumentation - 🐛 Support CompletableFuture on spring webmvc controllers ([#8659](DataDog/dd-trace-java#8659) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for endpoint discovery in spring mvc ([#8352](DataDog/dd-trace-java#8352) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### WebSocket Instrumentation - ✨ Instrument Jetty websocket pojo ([#8562](DataDog/dd-trace-java#8562) - [@amarziali](https://github.com/amarziali)) - 💡 Instrument Java Websocket API (JSR356) ([#8440](DataDog/dd-trace-java#8440) - [@amarziali](https://github.com/amarziali)) #### All other instrumentations - ✨ Introduce cache for peer.hostname lookup ([#8601](DataDog/dd-trace-java#8601) - [@mcculls](https://github.com/mcculls)) - ✨ Support pekko http 1.1 ([#8532](DataDog/dd-trace-java#8532) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 331314f71acaced3adc75ea5d7e855c248d593fc

trigger ci

2dfeef7

mhlidd added 5 commits March 3, 2025 18:01

fixing tests

cb696e8

fixing smoke test

26a26b3

running CI

4281882

fixing more smoke tests

9aae508

cleanup

f0b15b4

mhlidd marked this pull request as ready for review March 4, 2025 21:06

mhlidd requested a review from a team as a code owner March 4, 2025 21:06

mhlidd requested review from manuel-alvarez-alvarez and mcculls March 4, 2025 21:06

mhlidd added comp: api Tracer public API type: enhancement labels Mar 4, 2025

mhlidd marked this pull request as draft March 4, 2025 21:18

mhlidd added 2 commits March 5, 2025 11:15

testing islogging128bittraceidenabled migration to config

b24d13b

fixing small error

00ab390

This was referenced Mar 5, 2025

Update 128 bit logging enabled tests and disable stable config tests DataDog/system-tests#4251

Merged

Update system-tests to 590162e1f5223cbbcd2876fdb820837cb13a85e1 #8515

Merged

mhlidd added 2 commits March 6, 2025 10:16

adding to toString

48a8059

Merge branch 'master' into mhlidd/config_consistency

505f88e

mhlidd marked this pull request as ready for review March 6, 2025 16:00

mhlidd requested a review from a team as a code owner March 6, 2025 16:00

updating experimental features from list to set

da164b0

mcculls reviewed Mar 11, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/Config.java Outdated Show resolved Hide resolved

mcculls reviewed Mar 11, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/Config.java Outdated Show resolved Hide resolved

Merge branch 'master' into mhlidd/config_consistency

e6af653

mhlidd mentioned this pull request Mar 11, 2025

Introducing DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED Config #8536

Merged

mhlidd added 2 commits March 11, 2025 16:29

Merge branch 'master' into mhlidd/config_consistency

0b0ad8a

updating PR comments

8675886

mhlidd commented Mar 11, 2025

View reviewed changes

mhlidd requested a review from mcculls March 11, 2025 20:44

mhlidd added 5 commits March 12, 2025 11:28

Adding test to verify behavior for configs under feature falg

8c7027b

Merge branch 'master' into mhlidd/config_consistency

23038a2

updating test

6dc399a

updating config value when not under breaking_changed feature flag

df2dffb

Merge branch 'master' into mhlidd/config_consistency

335d316

mcculls reviewed Mar 17, 2025

View reviewed changes

dd-smoke-tests/src/main/groovy/datadog/smoketest/AbstractSmokeTest.groovy Outdated Show resolved Hide resolved

mcculls reviewed Mar 17, 2025

View reviewed changes

dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java Outdated Show resolved Hide resolved

mcculls reviewed Mar 17, 2025

View reviewed changes

dd-trace-ot/correlation-id-injection/src/test/groovy/CorrelationIdInjectorTest.groovy Outdated Show resolved Hide resolved

mcculls reviewed Mar 17, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/Config.java Outdated Show resolved Hide resolved

mcculls approved these changes Mar 17, 2025

View reviewed changes

mhlidd added 3 commits March 17, 2025 15:25

cleanup and nit responses

35dc923

nit pt 2

914f47a

Merge branch 'master' into mhlidd/config_consistency

a53ff2e

manuel-alvarez-alvarez approved these changes Mar 18, 2025

View reviewed changes

Merge branch 'master' into mhlidd/config_consistency

884e147

mhlidd merged commit 3c989a4 into master Mar 19, 2025
271 checks passed

mhlidd deleted the mhlidd/config_consistency branch March 19, 2025 17:55

github-actions bot added this to the 1.48.0 milestone Mar 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Config Consistency Round 2 #8489

Config Consistency Round 2 #8489

Uh oh!

mhlidd commented Mar 3, 2025 •

edited by jira bot

Loading

Uh oh!

pr-commenter bot commented Mar 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

mcculls Mar 11, 2025 •

edited

Loading

Uh oh!

mhlidd Mar 11, 2025

Uh oh!

mcculls Mar 17, 2025

Uh oh!

Uh oh!

Uh oh!

mcculls commented Mar 11, 2025

Uh oh!

mhlidd Mar 11, 2025

Uh oh!

mcculls Mar 17, 2025

Uh oh!

mhlidd Mar 17, 2025

Uh oh!

mhlidd Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcculls left a comment

Uh oh!

Uh oh!

Uh oh!

Config Consistency Round 2 #8489

Config Consistency Round 2 #8489

Uh oh!

Conversation

mhlidd commented Mar 3, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

mcculls Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhlidd Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcculls commented Mar 11, 2025

Uh oh!

mhlidd Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

mcculls Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

mhlidd Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

mhlidd Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mhlidd commented Mar 3, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Mar 3, 2025 •

edited

Loading

mcculls Mar 11, 2025 •

edited

Loading