-
Notifications
You must be signed in to change notification settings - Fork 312
Add In-Product Enablement (#8461) #8501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the ability to start and stop Debugger features: - Dynamic Instrumentation - Exception Replay - Code Origin - Distributed Debugger dynamically based on RemoteConfig record: APM_TRACING DebuggerAgent is now run every time at startup to have the base of some feature ready and be able to start the minimum required foe each feature. Ability to stop also the feature at any time to uninstall probes. Add smoke tests
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.135 s) : 0, 1135250
Total [baseline] (11.541 s) : 0, 11541085
Agent [candidate] (1.136 s) : 0, 1136067
Total [candidate] (11.476 s) : 0, 11475902
section appsec
Agent [baseline] (1.275 s) : 0, 1274937
Total [baseline] (11.64 s) : 0, 11639813
Agent [candidate] (1.27 s) : 0, 1270224
Total [candidate] (11.736 s) : 0, 11736380
section iast
Agent [baseline] (1.275 s) : 0, 1274551
Total [baseline] (11.986 s) : 0, 11986273
Agent [candidate] (1.26 s) : 0, 1260297
Total [candidate] (11.95 s) : 0, 11950149
section profiling
Agent [baseline] (1.388 s) : 0, 1387579
Total [baseline] (11.834 s) : 0, 11833937
Agent [candidate] (1.383 s) : 0, 1383061
Total [candidate] (11.839 s) : 0, 11839293
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.77 ms) : 0, 716770
BytebuddyAgent [candidate] (717.611 ms) : 0, 717611
GlobalTracer [baseline] (239.631 ms) : 0, 239631
GlobalTracer [candidate] (239.707 ms) : 0, 239707
AppSec [baseline] (55.923 ms) : 0, 55923
AppSec [candidate] (55.696 ms) : 0, 55696
Debugger [baseline] (94.985 ms) : 0, 94985
Debugger [candidate] (95.005 ms) : 0, 95005
Remote Config [baseline] (580.731 µs) : 0, 581
Remote Config [candidate] (583.303 µs) : 0, 583
Telemetry [baseline] (12.329 ms) : 0, 12329
Telemetry [candidate] (12.505 ms) : 0, 12505
section appsec
BytebuddyAgent [baseline] (736.289 ms) : 0, 736289
BytebuddyAgent [candidate] (733.362 ms) : 0, 733362
GlobalTracer [baseline] (237.358 ms) : 0, 237358
GlobalTracer [candidate] (235.933 ms) : 0, 235933
AppSec [baseline] (177.976 ms) : 0, 177976
AppSec [candidate] (177.362 ms) : 0, 177362
Debugger [baseline] (84.616 ms) : 0, 84616
Debugger [candidate] (84.611 ms) : 0, 84611
Remote Config [baseline] (635.379 µs) : 0, 635
Remote Config [candidate] (634.147 µs) : 0, 634
Telemetry [baseline] (12.434 ms) : 0, 12434
Telemetry [candidate] (12.405 ms) : 0, 12405
IAST [baseline] (21.273 ms) : 0, 21273
IAST [candidate] (21.797 ms) : 0, 21797
section iast
BytebuddyAgent [baseline] (846.937 ms) : 0, 846937
BytebuddyAgent [candidate] (837.789 ms) : 0, 837789
GlobalTracer [baseline] (231.698 ms) : 0, 231698
GlobalTracer [candidate] (230.275 ms) : 0, 230275
AppSec [baseline] (57.776 ms) : 0, 57776
AppSec [candidate] (57.389 ms) : 0, 57389
Debugger [baseline] (84.182 ms) : 0, 84182
Debugger [candidate] (84.317 ms) : 0, 84317
Remote Config [baseline] (532.083 µs) : 0, 532
Remote Config [candidate] (522.141 µs) : 0, 522
Telemetry [baseline] (15.317 ms) : 0, 15317
Telemetry [candidate] (12.194 ms) : 0, 12194
IAST [baseline] (23.016 ms) : 0, 23016
IAST [candidate] (22.798 ms) : 0, 22798
section profiling
BytebuddyAgent [baseline] (713.378 ms) : 0, 713378
BytebuddyAgent [candidate] (711.212 ms) : 0, 711212
GlobalTracer [baseline] (352.524 ms) : 0, 352524
GlobalTracer [candidate] (351.353 ms) : 0, 351353
AppSec [baseline] (55.855 ms) : 0, 55855
AppSec [candidate] (54.708 ms) : 0, 54708
Debugger [baseline] (88.569 ms) : 0, 88569
Debugger [candidate] (88.558 ms) : 0, 88558
Remote Config [baseline] (619.185 µs) : 0, 619
Remote Config [candidate] (617.626 µs) : 0, 618
Telemetry [baseline] (12.722 ms) : 0, 12722
Telemetry [candidate] (12.666 ms) : 0, 12666
ProfilingAgent [baseline] (123.323 ms) : 0, 123323
ProfilingAgent [candidate] (123.375 ms) : 0, 123375
Profiling [baseline] (123.345 ms) : 0, 123345
Profiling [candidate] (123.396 ms) : 0, 123396
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.155 s) : 0, 1154834
Total [baseline] (9.322 s) : 0, 9322167
Agent [candidate] (1.144 s) : 0, 1143749
Total [candidate] (9.27 s) : 0, 9269585
section iast
Agent [baseline] (1.26 s) : 0, 1259504
Total [baseline] (9.874 s) : 0, 9873882
Agent [candidate] (1.26 s) : 0, 1259549
Total [candidate] (9.903 s) : 0, 9902884
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.258 s) : 0, 1258118
Total [baseline] (9.859 s) : 0, 9858991
Agent [candidate] (1.259 s) : 0, 1259190
Total [candidate] (9.856 s) : 0, 9855673
section iast_TELEMETRY_OFF
Agent [baseline] (1.262 s) : 0, 1261852
Total [baseline] (9.868 s) : 0, 9868384
Agent [candidate] (1.26 s) : 0, 1260444
Total [candidate] (9.957 s) : 0, 9956781
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (729.424 ms) : 0, 729424
BytebuddyAgent [candidate] (722.978 ms) : 0, 722978
GlobalTracer [baseline] (244.053 ms) : 0, 244053
GlobalTracer [candidate] (240.768 ms) : 0, 240768
AppSec [baseline] (56.554 ms) : 0, 56554
AppSec [candidate] (55.75 ms) : 0, 55750
Debugger [baseline] (96.46 ms) : 0, 96460
Debugger [candidate] (96.191 ms) : 0, 96191
Remote Config [baseline] (590.846 µs) : 0, 591
Remote Config [candidate] (579.328 µs) : 0, 579
Telemetry [baseline] (12.634 ms) : 0, 12634
Telemetry [candidate] (12.434 ms) : 0, 12434
section iast
BytebuddyAgent [baseline] (835.311 ms) : 0, 835311
BytebuddyAgent [candidate] (837.31 ms) : 0, 837310
GlobalTracer [baseline] (230.452 ms) : 0, 230452
GlobalTracer [candidate] (230.523 ms) : 0, 230523
IAST [baseline] (22.848 ms) : 0, 22848
IAST [candidate] (22.722 ms) : 0, 22722
AppSec [baseline] (56.98 ms) : 0, 56980
AppSec [candidate] (57.301 ms) : 0, 57301
Debugger [baseline] (83.44 ms) : 0, 83440
Debugger [candidate] (83.924 ms) : 0, 83924
Remote Config [baseline] (515.733 µs) : 0, 516
Remote Config [candidate] (531.674 µs) : 0, 532
Telemetry [baseline] (14.968 ms) : 0, 14968
Telemetry [candidate] (12.165 ms) : 0, 12165
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.173 ms) : 0, 835173
BytebuddyAgent [candidate] (837.05 ms) : 0, 837050
GlobalTracer [baseline] (230.537 ms) : 0, 230537
GlobalTracer [candidate] (230.503 ms) : 0, 230503
IAST [baseline] (22.814 ms) : 0, 22814
IAST [candidate] (22.88 ms) : 0, 22880
AppSec [baseline] (57.167 ms) : 0, 57167
AppSec [candidate] (57.583 ms) : 0, 57583
Debugger [baseline] (83.458 ms) : 0, 83458
Debugger [candidate] (83.269 ms) : 0, 83269
Remote Config [baseline] (517.438 µs) : 0, 517
Remote Config [candidate] (519.364 µs) : 0, 519
Telemetry [baseline] (13.466 ms) : 0, 13466
Telemetry [candidate] (12.365 ms) : 0, 12365
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.337 ms) : 0, 839337
BytebuddyAgent [candidate] (838.75 ms) : 0, 838750
GlobalTracer [baseline] (231.323 ms) : 0, 231323
GlobalTracer [candidate] (230.465 ms) : 0, 230465
IAST [baseline] (23.328 ms) : 0, 23328
IAST [candidate] (23.923 ms) : 0, 23923
AppSec [baseline] (56.29 ms) : 0, 56290
AppSec [candidate] (55.71 ms) : 0, 55710
Debugger [baseline] (83.85 ms) : 0, 83850
Debugger [candidate] (83.757 ms) : 0, 83757
Remote Config [baseline] (528.108 µs) : 0, 528
Remote Config [candidate] (519.989 µs) : 0, 520
Telemetry [baseline] (12.127 ms) : 0, 12127
Telemetry [candidate] (12.211 ms) : 0, 12211
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1377
. : milestone, 1358,
appsec (1.723 ms) : 1698, 1747
. : milestone, 1723,
appsec_no_iast (1.73 ms) : 1706, 1753
. : milestone, 1730,
code_origins (1.686 ms) : 1654, 1719
. : milestone, 1686,
iast (1.516 ms) : 1491, 1542
. : milestone, 1516,
profiling (1.555 ms) : 1526, 1583
. : milestone, 1555,
tracing (1.48 ms) : 1456, 1504
. : milestone, 1480,
section candidate
no_agent (1.348 ms) : 1328, 1368
. : milestone, 1348,
appsec (1.719 ms) : 1694, 1744
. : milestone, 1719,
appsec_no_iast (1.724 ms) : 1701, 1747
. : milestone, 1724,
code_origins (1.694 ms) : 1662, 1727
. : milestone, 1694,
iast (1.516 ms) : 1492, 1541
. : milestone, 1516,
profiling (1.499 ms) : 1475, 1523
. : milestone, 1499,
tracing (1.476 ms) : 1452, 1501
. : milestone, 1476,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (384.098 µs) : 364, 404
. : milestone, 384,
iast (509.154 µs) : 488, 531
. : milestone, 509,
iast_FULL (731.836 µs) : 710, 754
. : milestone, 732,
iast_GLOBAL (561.752 µs) : 539, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (520.719 µs) : 498, 543
. : milestone, 521,
iast_INACTIVE (462.494 µs) : 441, 484
. : milestone, 462,
iast_TELEMETRY_OFF (496.998 µs) : 475, 519
. : milestone, 497,
tracing (456.319 µs) : 435, 478
. : milestone, 456,
section candidate
no_agent (381.262 µs) : 361, 401
. : milestone, 381,
iast (512.438 µs) : 491, 534
. : milestone, 512,
iast_FULL (726.067 µs) : 703, 749
. : milestone, 726,
iast_GLOBAL (558.351 µs) : 536, 581
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (514.555 µs) : 493, 536
. : milestone, 515,
iast_INACTIVE (461.425 µs) : 440, 483
. : milestone, 461,
iast_TELEMETRY_OFF (498.701 µs) : 476, 521
. : milestone, 499,
tracing (462.401 µs) : 441, 484
. : milestone, 462,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
appsec (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
iast (18.715 s) : 18715000, 18715000
. : milestone, 18715000,
iast_GLOBAL (18.179 s) : 18179000, 18179000
. : milestone, 18179000,
profiling (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
tracing (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
section candidate
no_agent (15.452 s) : 15452000, 15452000
. : milestone, 15452000,
appsec (14.889 s) : 14889000, 14889000
. : milestone, 14889000,
iast (19.042 s) : 19042000, 19042000
. : milestone, 19042000,
iast_GLOBAL (18.205 s) : 18205000, 18205000
. : milestone, 18205000,
profiling (15.656 s) : 15656000, 15656000
. : milestone, 15656000,
tracing (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~dceca289e9, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.349 ms) : 2305, 2392
. : milestone, 2349,
iast (2.125 ms) : 2070, 2180
. : milestone, 2125,
iast_GLOBAL (2.169 ms) : 2113, 2224
. : milestone, 2169,
profiling (1.998 ms) : 1953, 2043
. : milestone, 1998,
tracing (1.953 ms) : 1911, 1995
. : milestone, 1953,
section candidate
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (2.342 ms) : 2299, 2386
. : milestone, 2342,
iast (2.123 ms) : 2068, 2179
. : milestone, 2123,
iast_GLOBAL (2.165 ms) : 2110, 2221
. : milestone, 2165,
profiling (2.463 ms) : 2280, 2647
. : milestone, 2463,
tracing (1.953 ms) : 1911, 1995
. : milestone, 1953,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the ability to start and stop Debugger features:
Ability to stop also the feature at any time to uninstall probes. Add smoke tests
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]