-
Notifications
You must be signed in to change notification settings - Fork 303
Enable API Security by default #8511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
smola
wants to merge
1
commit into
master
Choose a base branch
from
smola/enable-api-security-by-default
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 54 metrics, 15 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019525
Total [baseline] (8.647 s) : 0, 8647196
Agent [candidate] (1.026 s) : 0, 1025542
Total [candidate] (8.666 s) : 0, 8665559
section iast
Agent [baseline] (1.148 s) : 0, 1148302
Total [baseline] (9.241 s) : 0, 9241135
Agent [candidate] (1.151 s) : 0, 1151088
Total [candidate] (9.237 s) : 0, 9237498
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.151 s) : 0, 1151050
Total [baseline] (9.262 s) : 0, 9261849
Agent [candidate] (1.151 s) : 0, 1151472
Total [candidate] (9.22 s) : 0, 9220137
section iast_TELEMETRY_OFF
Agent [baseline] (1.153 s) : 0, 1153099
Total [baseline] (9.221 s) : 0, 9220658
Agent [candidate] (1.154 s) : 0, 1154004
Total [candidate] (9.277 s) : 0, 9276635
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.95 ms) : 0, 682950
BytebuddyAgent [candidate] (683.525 ms) : 0, 683525
GlobalTracer [baseline] (239.912 ms) : 0, 239912
GlobalTracer [candidate] (240.701 ms) : 0, 240701
AppSec [baseline] (55.014 ms) : 0, 55014
AppSec [candidate] (61.096 ms) : 0, 61096
Debugger [baseline] (6.849 ms) : 0, 6849
Debugger [candidate] (6.126 ms) : 0, 6126
Remote Config [baseline] (707.317 µs) : 0, 707
Remote Config [candidate] (710.771 µs) : 0, 711
Telemetry [baseline] (10.501 ms) : 0, 10501
Telemetry [candidate] (9.872 ms) : 0, 9872
section iast
BytebuddyAgent [baseline] (801.706 ms) : 0, 801706
BytebuddyAgent [candidate] (800.653 ms) : 0, 800653
GlobalTracer [baseline] (230.503 ms) : 0, 230503
GlobalTracer [candidate] (230.512 ms) : 0, 230512
IAST [baseline] (28.871 ms) : 0, 28871
IAST [candidate] (26.965 ms) : 0, 26965
AppSec [baseline] (49.275 ms) : 0, 49275
AppSec [candidate] (55.014 ms) : 0, 55014
Debugger [baseline] (5.919 ms) : 0, 5919
Debugger [candidate] (5.986 ms) : 0, 5986
Remote Config [baseline] (593.549 µs) : 0, 594
Remote Config [candidate] (585.507 µs) : 0, 586
Telemetry [baseline] (7.884 ms) : 0, 7884
Telemetry [candidate] (7.861 ms) : 0, 7861
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.537 ms) : 0, 802537
BytebuddyAgent [candidate] (801.219 ms) : 0, 801219
GlobalTracer [baseline] (230.93 ms) : 0, 230930
GlobalTracer [candidate] (230.241 ms) : 0, 230241
IAST [baseline] (28.616 ms) : 0, 28616
IAST [candidate] (26.201 ms) : 0, 26201
AppSec [baseline] (50.872 ms) : 0, 50872
AppSec [candidate] (55.701 ms) : 0, 55701
Debugger [baseline] (5.954 ms) : 0, 5954
Debugger [candidate] (6.003 ms) : 0, 6003
Remote Config [baseline] (602.211 µs) : 0, 602
Remote Config [candidate] (591.181 µs) : 0, 591
Telemetry [baseline] (7.951 ms) : 0, 7951
Telemetry [candidate] (7.863 ms) : 0, 7863
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.813 ms) : 0, 804813
BytebuddyAgent [candidate] (803.509 ms) : 0, 803509
GlobalTracer [baseline] (231.72 ms) : 0, 231720
GlobalTracer [candidate] (231.343 ms) : 0, 231343
IAST [baseline] (24.088 ms) : 0, 24088
IAST [candidate] (24.639 ms) : 0, 24639
AppSec [baseline] (54.39 ms) : 0, 54390
AppSec [candidate] (56.268 ms) : 0, 56268
Debugger [baseline] (6.018 ms) : 0, 6018
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (621.266 µs) : 0, 621
Remote Config [candidate] (601.255 µs) : 0, 601
Telemetry [baseline] (7.737 ms) : 0, 7737
Telemetry [candidate] (7.854 ms) : 0, 7854
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019807
Total [baseline] (10.533 s) : 0, 10533054
Agent [candidate] (1.03 s) : 0, 1030427
Total [candidate] (10.483 s) : 0, 10483397
section appsec
Agent [baseline] (1.174 s) : 0, 1173656
Total [baseline] (10.795 s) : 0, 10795495
Agent [candidate] (1.168 s) : 0, 1167960
Total [candidate] (10.711 s) : 0, 10711355
section iast
Agent [baseline] (1.151 s) : 0, 1150903
Total [baseline] (10.868 s) : 0, 10868471
Agent [candidate] (1.169 s) : 0, 1168736
Total [candidate] (10.928 s) : 0, 10927936
section profiling
Agent [baseline] (1.293 s) : 0, 1293490
Total [baseline] (10.857 s) : 0, 10857367
Agent [candidate] (1.286 s) : 0, 1285627
Total [candidate] (10.858 s) : 0, 10858303
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.677 ms) : 0, 682677
BytebuddyAgent [candidate] (687.029 ms) : 0, 687029
GlobalTracer [baseline] (240.01 ms) : 0, 240010
GlobalTracer [candidate] (241.711 ms) : 0, 241711
AppSec [baseline] (54.371 ms) : 0, 54371
AppSec [candidate] (61.322 ms) : 0, 61322
Debugger [baseline] (7.779 ms) : 0, 7779
Debugger [candidate] (6.135 ms) : 0, 6135
Remote Config [baseline] (707.141 µs) : 0, 707
Remote Config [candidate] (704.729 µs) : 0, 705
Telemetry [baseline] (10.62 ms) : 0, 10620
Telemetry [candidate] (9.764 ms) : 0, 9764
section appsec
BytebuddyAgent [baseline] (709.716 ms) : 0, 709716
BytebuddyAgent [candidate] (702.787 ms) : 0, 702787
GlobalTracer [baseline] (238.545 ms) : 0, 238545
GlobalTracer [candidate] (237.729 ms) : 0, 237729
IAST [baseline] (21.811 ms) : 0, 21811
IAST [candidate] (21.59 ms) : 0, 21590
AppSec [baseline] (176.156 ms) : 0, 176156
AppSec [candidate] (179.049 ms) : 0, 179049
Debugger [baseline] (5.993 ms) : 0, 5993
Debugger [candidate] (5.909 ms) : 0, 5909
Remote Config [baseline] (627.98 µs) : 0, 628
Remote Config [candidate] (622.687 µs) : 0, 623
Telemetry [baseline] (7.861 ms) : 0, 7861
Telemetry [candidate] (7.373 ms) : 0, 7373
section iast
BytebuddyAgent [baseline] (803.431 ms) : 0, 803431
BytebuddyAgent [candidate] (814.641 ms) : 0, 814641
GlobalTracer [baseline] (231.058 ms) : 0, 231058
GlobalTracer [candidate] (233.831 ms) : 0, 233831
IAST [baseline] (27.342 ms) : 0, 27342
IAST [candidate] (28.676 ms) : 0, 28676
AppSec [baseline] (51.124 ms) : 0, 51124
AppSec [candidate] (52.542 ms) : 0, 52542
Debugger [baseline] (5.907 ms) : 0, 5907
Debugger [candidate] (6.016 ms) : 0, 6016
Remote Config [baseline] (592.902 µs) : 0, 593
Remote Config [candidate] (585.621 µs) : 0, 586
Telemetry [baseline] (7.861 ms) : 0, 7861
Telemetry [candidate] (7.87 ms) : 0, 7870
section profiling
BytebuddyAgent [baseline] (682.743 ms) : 0, 682743
BytebuddyAgent [candidate] (675.223 ms) : 0, 675223
GlobalTracer [baseline] (376.921 ms) : 0, 376921
GlobalTracer [candidate] (376.037 ms) : 0, 376037
AppSec [baseline] (62.399 ms) : 0, 62399
AppSec [candidate] (64.75 ms) : 0, 64750
Debugger [baseline] (6.406 ms) : 0, 6406
Debugger [candidate] (6.334 ms) : 0, 6334
Remote Config [baseline] (666.519 µs) : 0, 667
Remote Config [candidate] (674.074 µs) : 0, 674
Telemetry [baseline] (8.316 ms) : 0, 8316
Telemetry [candidate] (8.155 ms) : 0, 8155
ProfilingAgent [baseline] (104.465 ms) : 0, 104465
ProfilingAgent [candidate] (103.551 ms) : 0, 103551
Profiling [baseline] (104.49 ms) : 0, 104490
Profiling [candidate] (103.575 ms) : 0, 103575
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section baseline
no_agent (1.367 ms) : 1347, 1387
. : milestone, 1367,
appsec (1.742 ms) : 1719, 1766
. : milestone, 1742,
appsec_no_iast (1.745 ms) : 1721, 1768
. : milestone, 1745,
code_origins (1.695 ms) : 1668, 1722
. : milestone, 1695,
iast (1.536 ms) : 1511, 1560
. : milestone, 1536,
profiling (1.528 ms) : 1505, 1551
. : milestone, 1528,
tracing (1.512 ms) : 1487, 1537
. : milestone, 1512,
section candidate
no_agent (1.36 ms) : 1341, 1379
. : milestone, 1360,
appsec (1.737 ms) : 1714, 1761
. : milestone, 1737,
appsec_no_iast (1.749 ms) : 1725, 1773
. : milestone, 1749,
code_origins (1.691 ms) : 1664, 1718
. : milestone, 1691,
iast (1.535 ms) : 1511, 1559
. : milestone, 1535,
profiling (1.531 ms) : 1508, 1555
. : milestone, 1531,
tracing (1.498 ms) : 1475, 1521
. : milestone, 1498,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section baseline
no_agent (386.887 µs) : 367, 407
. : milestone, 387,
iast (528.314 µs) : 506, 550
. : milestone, 528,
iast_FULL (743.006 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (571.304 µs) : 549, 593
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (527.773 µs) : 505, 551
. : milestone, 528,
iast_INACTIVE (470.907 µs) : 448, 493
. : milestone, 471,
iast_TELEMETRY_OFF (520.895 µs) : 498, 544
. : milestone, 521,
tracing (463.086 µs) : 441, 485
. : milestone, 463,
section candidate
no_agent (388.784 µs) : 369, 408
. : milestone, 389,
iast (523.94 µs) : 502, 546
. : milestone, 524,
iast_FULL (741.722 µs) : 720, 764
. : milestone, 742,
iast_GLOBAL (567.608 µs) : 546, 589
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (531.778 µs) : 510, 554
. : milestone, 532,
iast_INACTIVE (476.712 µs) : 454, 500
. : milestone, 477,
iast_TELEMETRY_OFF (518.589 µs) : 495, 542
. : milestone, 519,
tracing (467.664 µs) : 445, 490
. : milestone, 468,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section baseline
no_agent (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
appsec (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
iast (19.201 s) : 19201000, 19201000
. : milestone, 19201000,
iast_GLOBAL (18.292 s) : 18292000, 18292000
. : milestone, 18292000,
profiling (15.154 s) : 15154000, 15154000
. : milestone, 15154000,
tracing (14.749 s) : 14749000, 14749000
. : milestone, 14749000,
section candidate
no_agent (15.476 s) : 15476000, 15476000
. : milestone, 15476000,
appsec (15.163 s) : 15163000, 15163000
. : milestone, 15163000,
iast (19.036 s) : 19036000, 19036000
. : milestone, 19036000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
profiling (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
tracing (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~82de3c8d763, baseline=1.50.0-SNAPSHOT~f21ec9ed7b
dateFormat X
axisFormat %s
section baseline
no_agent (1.488 ms) : 1476, 1500
. : milestone, 1488,
appsec (2.432 ms) : 2383, 2482
. : milestone, 2432,
iast (2.217 ms) : 2154, 2279
. : milestone, 2217,
iast_GLOBAL (2.247 ms) : 2185, 2310
. : milestone, 2247,
profiling (2.051 ms) : 2001, 2101
. : milestone, 2051,
tracing (2.027 ms) : 1979, 2075
. : milestone, 2027,
section candidate
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (2.417 ms) : 2368, 2467
. : milestone, 2417,
iast (2.197 ms) : 2135, 2259
. : milestone, 2197,
iast_GLOBAL (2.246 ms) : 2184, 2309
. : milestone, 2246,
profiling (2.043 ms) : 1993, 2093
. : milestone, 2043,
tracing (2.027 ms) : 1979, 2076
. : milestone, 2027,
|
70381c5
to
82de3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]