Skip to content

Conversation

amarziali
Copy link
Contributor

What Does This Do

Excludes jackson afterburner classes from instrumentations. See https://github.com/search?q=org%3AFasterXML+4Jackson+repo%3AFasterXML%2Fjackson-module-afterburner&type=code

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added type: enhancement Enhancements and improvements comp: core Tracer core labels Apr 29, 2025
@amarziali amarziali requested a review from a team as a code owner April 29, 2025 09:58
1 $Access4JacksonDeserializer*
1 $Access4JacksonSerializer*
1 $Creator4JacksonDeserializer*
1 $Creator4JacksonSerializer*
Copy link
Contributor

@bric3 bric3 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: There's no $Creator4JacksonSerializer ;)

Also, there are possibly these hibernate ones:

  • $HibernateInstantiator$
  • $HibernateProxy$
  • $HibernateAccessOptimizer$

see #8678 (comment) and #8678 (comment)

On another note, we wondered if we wanted to have a toggle for these classes (Maybe added as another trie ?).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On another note, we wondered if we wanted to have a toggle for these classes (Maybe added as another trie ?).

Rather than introduce another trie, you could take the same approach as in ignored_class_name.trie and use a different number for ignores that can be toggled

i.e. 0 == force allow, 1 == force ignore, 2 == optional ignore, etc...

You could have as many extra values as you want for different categories

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes as @mcculls proposes there is no need to add another trie but just having a different result.
Thanks @bric3 for the note :) let me remove the exceeding one and add the hibernate ones. Did you have a precise use case for having different trie result values?

@pr-commenter
Copy link

pr-commenter bot commented Apr 29, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/afterburner
git_commit_date 1745919592 1745928008
git_commit_sha 0698839 60a1d58
release_version 1.49.0-SNAPSHOT~069883952e 1.49.0-SNAPSHOT~60a1d58c11
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745931043 1745931043
ci_job_id 916524269 916524269
ci_pipeline_id 63594069 63594069
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-4hrjjdkh-project-304-concurrent-0-joszwnxy 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-4hrjjdkh-project-304-concurrent-0-joszwnxy 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.011 s) : 0, 1010670
Total [baseline] (8.631 s) : 0, 8630961
Agent [candidate] (1.004 s) : 0, 1004434
Total [candidate] (8.612 s) : 0, 8612242
section iast
Agent [baseline] (1.144 s) : 0, 1144322
Total [baseline] (9.218 s) : 0, 9217785
Agent [candidate] (1.139 s) : 0, 1139305
Total [candidate] (9.194 s) : 0, 9193732
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.139 s) : 0, 1138943
Total [baseline] (9.17 s) : 0, 9169507
Agent [candidate] (1.142 s) : 0, 1142202
Total [candidate] (9.177 s) : 0, 9177271
section iast_TELEMETRY_OFF
Agent [baseline] (1.13 s) : 0, 1129508
Total [baseline] (9.177 s) : 0, 9176807
Agent [candidate] (1.13 s) : 0, 1130271
Total [candidate] (9.197 s) : 0, 9196678
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.011 s -
Agent iast 1.144 s 133.652 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.139 s 128.273 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.13 s 118.838 ms (11.8%)
Total tracing 8.631 s -
Total iast 9.218 s 586.824 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.17 s 538.546 ms (6.2%)
Total iast_TELEMETRY_OFF 9.177 s 545.846 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.004 s -
Agent iast 1.139 s 134.872 ms (13.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.142 s 137.768 ms (13.7%)
Agent iast_TELEMETRY_OFF 1.13 s 125.838 ms (12.5%)
Total tracing 8.612 s -
Total iast 9.194 s 581.49 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.177 s 565.029 ms (6.6%)
Total iast_TELEMETRY_OFF 9.197 s 584.436 ms (6.8%)
gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.52 ms) : 0, 673520
BytebuddyAgent [candidate] (668.668 ms) : 0, 668668
GlobalTracer [baseline] (240.454 ms) : 0, 240454
GlobalTracer [candidate] (239.823 ms) : 0, 239823
AppSec [baseline] (54.652 ms) : 0, 54652
AppSec [candidate] (54.264 ms) : 0, 54264
Debugger [baseline] (7.586 ms) : 0, 7586
Debugger [candidate] (7.596 ms) : 0, 7596
Remote Config [baseline] (698.484 µs) : 0, 698
Remote Config [candidate] (707.25 µs) : 0, 707
Telemetry [baseline] (10.157 ms) : 0, 10157
Telemetry [candidate] (9.999 ms) : 0, 9999
section iast
BytebuddyAgent [baseline] (796.809 ms) : 0, 796809
BytebuddyAgent [candidate] (792.823 ms) : 0, 792823
GlobalTracer [baseline] (230.8 ms) : 0, 230800
GlobalTracer [candidate] (229.591 ms) : 0, 229591
IAST [baseline] (22.763 ms) : 0, 22763
IAST [candidate] (22.682 ms) : 0, 22682
AppSec [baseline] (55.883 ms) : 0, 55883
AppSec [candidate] (56.377 ms) : 0, 56377
Debugger [baseline] (5.941 ms) : 0, 5941
Debugger [candidate] (5.875 ms) : 0, 5875
Remote Config [baseline] (607.714 µs) : 0, 608
Remote Config [candidate] (579.888 µs) : 0, 580
Telemetry [baseline] (7.998 ms) : 0, 7998
Telemetry [candidate] (7.893 ms) : 0, 7893
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.168 ms) : 0, 790168
BytebuddyAgent [candidate] (793.816 ms) : 0, 793816
GlobalTracer [baseline] (231.306 ms) : 0, 231306
GlobalTracer [candidate] (230.625 ms) : 0, 230625
IAST [baseline] (23.034 ms) : 0, 23034
IAST [candidate] (22.995 ms) : 0, 22995
AppSec [baseline] (56.525 ms) : 0, 56525
AppSec [candidate] (56.799 ms) : 0, 56799
Debugger [baseline] (5.938 ms) : 0, 5938
Debugger [candidate] (5.918 ms) : 0, 5918
Remote Config [baseline] (609.188 µs) : 0, 609
Remote Config [candidate] (598.431 µs) : 0, 598
Telemetry [baseline] (7.976 ms) : 0, 7976
Telemetry [candidate] (7.939 ms) : 0, 7939
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.46 ms) : 0, 784460
BytebuddyAgent [candidate] (784.802 ms) : 0, 784802
GlobalTracer [baseline] (229.13 ms) : 0, 229130
GlobalTracer [candidate] (229.431 ms) : 0, 229431
IAST [baseline] (22.268 ms) : 0, 22268
IAST [candidate] (22.176 ms) : 0, 22176
AppSec [baseline] (56.101 ms) : 0, 56101
AppSec [candidate] (56.327 ms) : 0, 56327
Debugger [baseline] (5.872 ms) : 0, 5872
Debugger [candidate] (5.867 ms) : 0, 5867
Remote Config [baseline] (593.637 µs) : 0, 594
Remote Config [candidate] (601.764 µs) : 0, 602
Telemetry [baseline] (7.756 ms) : 0, 7756
Telemetry [candidate] (7.697 ms) : 0, 7697
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.013 s) : 0, 1013170
Total [baseline] (10.52 s) : 0, 10519896
Agent [candidate] (1.014 s) : 0, 1014486
Total [candidate] (10.534 s) : 0, 10533653
section appsec
Agent [baseline] (1.147 s) : 0, 1146642
Total [baseline] (10.68 s) : 0, 10680235
Agent [candidate] (1.153 s) : 0, 1152903
Total [candidate] (10.671 s) : 0, 10670794
section iast
Agent [baseline] (1.143 s) : 0, 1143398
Total [baseline] (10.986 s) : 0, 10986012
Agent [candidate] (1.138 s) : 0, 1138473
Total [candidate] (10.915 s) : 0, 10914920
section profiling
Agent [baseline] (1.255 s) : 0, 1254855
Total [baseline] (10.837 s) : 0, 10837107
Agent [candidate] (1.254 s) : 0, 1254060
Total [candidate] (10.829 s) : 0, 10829275
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.013 s -
Agent appsec 1.147 s 133.472 ms (13.2%)
Agent iast 1.143 s 130.228 ms (12.9%)
Agent profiling 1.255 s 241.685 ms (23.9%)
Total tracing 10.52 s -
Total appsec 10.68 s 160.34 ms (1.5%)
Total iast 10.986 s 466.116 ms (4.4%)
Total profiling 10.837 s 317.211 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.153 s 138.417 ms (13.6%)
Agent iast 1.138 s 123.987 ms (12.2%)
Agent profiling 1.254 s 239.574 ms (23.6%)
Total tracing 10.534 s -
Total appsec 10.671 s 137.14 ms (1.3%)
Total iast 10.915 s 381.266 ms (3.6%)
Total profiling 10.829 s 295.622 ms (2.8%)
gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.61 ms) : 0, 675610
BytebuddyAgent [candidate] (675.643 ms) : 0, 675643
GlobalTracer [baseline] (241.32 ms) : 0, 241320
GlobalTracer [candidate] (241.575 ms) : 0, 241575
AppSec [baseline] (54.999 ms) : 0, 54999
AppSec [candidate] (55.017 ms) : 0, 55017
Debugger [baseline] (6.182 ms) : 0, 6182
Debugger [candidate] (6.201 ms) : 0, 6201
Remote Config [baseline] (721.686 µs) : 0, 722
Remote Config [candidate] (719.779 µs) : 0, 720
Telemetry [baseline] (10.703 ms) : 0, 10703
Telemetry [candidate] (11.732 ms) : 0, 11732
section appsec
BytebuddyAgent [baseline] (686.289 ms) : 0, 686289
BytebuddyAgent [candidate] (690.801 ms) : 0, 690801
GlobalTracer [baseline] (236.057 ms) : 0, 236057
GlobalTracer [candidate] (237.222 ms) : 0, 237222
IAST [baseline] (21.762 ms) : 0, 21762
IAST [candidate] (21.658 ms) : 0, 21658
AppSec [baseline] (175.768 ms) : 0, 175768
AppSec [candidate] (176.271 ms) : 0, 176271
Debugger [baseline] (5.862 ms) : 0, 5862
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (636.823 µs) : 0, 637
Remote Config [candidate] (642.359 µs) : 0, 642
Telemetry [baseline] (7.811 ms) : 0, 7811
Telemetry [candidate] (7.833 ms) : 0, 7833
section iast
BytebuddyAgent [baseline] (794.07 ms) : 0, 794070
BytebuddyAgent [candidate] (789.072 ms) : 0, 789072
GlobalTracer [baseline] (231.425 ms) : 0, 231425
GlobalTracer [candidate] (231.365 ms) : 0, 231365
IAST [baseline] (22.924 ms) : 0, 22924
IAST [candidate] (23.013 ms) : 0, 23013
AppSec [baseline] (56.979 ms) : 0, 56979
AppSec [candidate] (56.956 ms) : 0, 56956
Debugger [baseline] (5.996 ms) : 0, 5996
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (611.214 µs) : 0, 611
Remote Config [candidate] (614.897 µs) : 0, 615
Telemetry [baseline] (8.017 ms) : 0, 8017
Telemetry [candidate] (8.077 ms) : 0, 8077
section profiling
BytebuddyAgent [baseline] (662.375 ms) : 0, 662375
BytebuddyAgent [candidate] (663.75 ms) : 0, 663750
GlobalTracer [baseline] (375.636 ms) : 0, 375636
GlobalTracer [candidate] (375.249 ms) : 0, 375249
AppSec [baseline] (54.282 ms) : 0, 54282
AppSec [candidate] (53.48 ms) : 0, 53480
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (6.104 ms) : 0, 6104
Remote Config [baseline] (647.154 µs) : 0, 647
Remote Config [candidate] (636.116 µs) : 0, 636
Telemetry [baseline] (8.166 ms) : 0, 8166
Telemetry [candidate] (8.145 ms) : 0, 8145
ProfilingAgent [baseline] (97.496 ms) : 0, 97496
ProfilingAgent [candidate] (96.393 ms) : 0, 96393
Profiling [baseline] (97.52 ms) : 0, 97520
Profiling [candidate] (96.417 ms) : 0, 96417
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-29T12:21:06 2025-04-29T12:28:51
git_branch master andrea.marziali/afterburner
git_commit_date 1745919592 1745928008
git_commit_sha 0698839 60a1d58
release_version 1.49.0-SNAPSHOT~069883952e 1.49.0-SNAPSHOT~60a1d58c11
start_time 2025-04-29T12:20:51 2025-04-29T12:28:37
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745930131 1745930131
ci_job_id 916524270 916524270
ci_pipeline_id 63594069 63594069
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-fqkx7oxa-project-304-concurrent-0-4am4i7ug 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-fqkx7oxa-project-304-concurrent-0-4am4i7ug 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+62.135µs; +114.213µs] or [+4.086%; +7.511%]
unstable
[-761.748op/s; +322.187op/s] or [-24.757%; +10.471%]
1.609ms 2857.143op/s 1.521ms 3076.923op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1369
.   : milestone, 1350,
appsec (1.734 ms) : 1710, 1758
.   : milestone, 1734,
appsec_no_iast (1.744 ms) : 1720, 1768
.   : milestone, 1744,
code_origins (1.694 ms) : 1668, 1721
.   : milestone, 1694,
iast (1.535 ms) : 1512, 1559
.   : milestone, 1535,
profiling (1.521 ms) : 1497, 1544
.   : milestone, 1521,
tracing (1.504 ms) : 1480, 1529
.   : milestone, 1504,
section candidate
no_agent (1.352 ms) : 1332, 1372
.   : milestone, 1352,
appsec (1.737 ms) : 1713, 1761
.   : milestone, 1737,
appsec_no_iast (1.739 ms) : 1715, 1762
.   : milestone, 1739,
code_origins (1.686 ms) : 1659, 1712
.   : milestone, 1686,
iast (1.524 ms) : 1501, 1548
.   : milestone, 1524,
profiling (1.609 ms) : 1584, 1633
.   : milestone, 1609,
tracing (1.497 ms) : 1472, 1521
.   : milestone, 1497,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.33 ms, 1.369 ms] -
appsec 1.734 ms [1.71 ms, 1.758 ms] 384.405 µs (28.5%)
appsec_no_iast 1.744 ms [1.72 ms, 1.768 ms] 394.424 µs (29.2%)
code_origins 1.694 ms [1.668 ms, 1.721 ms] 344.791 µs (25.5%)
iast 1.535 ms [1.512 ms, 1.559 ms] 185.837 µs (13.8%)
profiling 1.521 ms [1.497 ms, 1.544 ms] 171.041 µs (12.7%)
tracing 1.504 ms [1.48 ms, 1.529 ms] 154.612 µs (11.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.332 ms, 1.372 ms] -
appsec 1.737 ms [1.713 ms, 1.761 ms] 385.029 µs (28.5%)
appsec_no_iast 1.739 ms [1.715 ms, 1.762 ms] 386.426 µs (28.6%)
code_origins 1.686 ms [1.659 ms, 1.712 ms] 333.5 µs (24.7%)
iast 1.524 ms [1.501 ms, 1.548 ms] 172.042 µs (12.7%)
profiling 1.609 ms [1.584 ms, 1.633 ms] 256.646 µs (19.0%)
tracing 1.497 ms [1.472 ms, 1.521 ms] 144.395 µs (10.7%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (385.026 µs) : 365, 405
.   : milestone, 385,
iast (521.07 µs) : 498, 544
.   : milestone, 521,
iast_FULL (738.951 µs) : 715, 763
.   : milestone, 739,
iast_GLOBAL (582.991 µs) : 559, 607
.   : milestone, 583,
iast_HARDCODED_SECRET_DISABLED (525.11 µs) : 501, 549
.   : milestone, 525,
iast_INACTIVE (473.802 µs) : 451, 497
.   : milestone, 474,
iast_TELEMETRY_OFF (509.477 µs) : 486, 533
.   : milestone, 509,
tracing (463.786 µs) : 442, 486
.   : milestone, 464,
section candidate
no_agent (383.955 µs) : 364, 404
.   : milestone, 384,
iast (518.377 µs) : 495, 542
.   : milestone, 518,
iast_FULL (732.288 µs) : 709, 756
.   : milestone, 732,
iast_GLOBAL (566.432 µs) : 544, 589
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (525.589 µs) : 503, 548
.   : milestone, 526,
iast_INACTIVE (467.117 µs) : 444, 490
.   : milestone, 467,
iast_TELEMETRY_OFF (528.13 µs) : 505, 552
.   : milestone, 528,
tracing (460.055 µs) : 439, 482
.   : milestone, 460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.026 µs [365.344 µs, 404.708 µs] -
iast 521.07 µs [498.212 µs, 543.929 µs] 136.044 µs (35.3%)
iast_FULL 738.951 µs [715.37 µs, 762.532 µs] 353.925 µs (91.9%)
iast_GLOBAL 582.991 µs [559.031 µs, 606.95 µs] 197.965 µs (51.4%)
iast_HARDCODED_SECRET_DISABLED 525.11 µs [501.417 µs, 548.804 µs] 140.084 µs (36.4%)
iast_INACTIVE 473.802 µs [450.668 µs, 496.935 µs] 88.776 µs (23.1%)
iast_TELEMETRY_OFF 509.477 µs [486.092 µs, 532.862 µs] 124.451 µs (32.3%)
tracing 463.786 µs [441.824 µs, 485.748 µs] 78.76 µs (20.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.955 µs [364.152 µs, 403.758 µs] -
iast 518.377 µs [494.915 µs, 541.84 µs] 134.422 µs (35.0%)
iast_FULL 732.288 µs [708.927 µs, 755.649 µs] 348.333 µs (90.7%)
iast_GLOBAL 566.432 µs [543.514 µs, 589.351 µs] 182.477 µs (47.5%)
iast_HARDCODED_SECRET_DISABLED 525.589 µs [503.03 µs, 548.149 µs] 141.634 µs (36.9%)
iast_INACTIVE 467.117 µs [444.436 µs, 489.797 µs] 83.162 µs (21.7%)
iast_TELEMETRY_OFF 528.13 µs [504.574 µs, 551.686 µs] 144.175 µs (37.6%)
tracing 460.055 µs [438.596 µs, 481.513 µs] 76.099 µs (19.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/afterburner
git_commit_date 1745919592 1745928008
git_commit_sha 0698839 60a1d58
release_version 1.49.0-SNAPSHOT~069883952e 1.49.0-SNAPSHOT~60a1d58c11
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1745930569 1745930569
ci_job_id 916524271 916524271
ci_pipeline_id 63594069 63594069
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-4hrjjdkh-project-304-concurrent-1-1gnf26tb 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-4hrjjdkh-project-304-concurrent-1-1gnf26tb 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
appsec (15.127 s) : 15127000, 15127000
.   : milestone, 15127000,
iast (18.468 s) : 18468000, 18468000
.   : milestone, 18468000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
.   : milestone, 17877000,
profiling (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
tracing (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
section candidate
no_agent (15.38 s) : 15380000, 15380000
.   : milestone, 15380000,
appsec (15.227 s) : 15227000, 15227000
.   : milestone, 15227000,
iast (18.414 s) : 18414000, 18414000
.   : milestone, 18414000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
.   : milestone, 17972000,
profiling (15.146 s) : 15146000, 15146000
.   : milestone, 15146000,
tracing (14.831 s) : 14831000, 14831000
.   : milestone, 14831000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.008 s [15.008 s, 15.008 s] -
appsec 15.127 s [15.127 s, 15.127 s] 119.0 ms (0.8%)
iast 18.468 s [18.468 s, 18.468 s] 3.46 s (23.1%)
iast_GLOBAL 17.877 s [17.877 s, 17.877 s] 2.869 s (19.1%)
profiling 14.957 s [14.957 s, 14.957 s] -51.0 ms (-0.3%)
tracing 14.993 s [14.993 s, 14.993 s] -15.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.38 s [15.38 s, 15.38 s] -
appsec 15.227 s [15.227 s, 15.227 s] -153.0 ms (-1.0%)
iast 18.414 s [18.414 s, 18.414 s] 3.034 s (19.7%)
iast_GLOBAL 17.972 s [17.972 s, 17.972 s] 2.592 s (16.9%)
profiling 15.146 s [15.146 s, 15.146 s] -234.0 ms (-1.5%)
tracing 14.831 s [14.831 s, 14.831 s] -549.0 ms (-3.6%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~60a1d58c11, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.372 ms) : 2325, 2419
.   : milestone, 2372,
iast (2.15 ms) : 2092, 2209
.   : milestone, 2150,
iast_GLOBAL (2.189 ms) : 2130, 2248
.   : milestone, 2189,
profiling (1.997 ms) : 1950, 2044
.   : milestone, 1997,
tracing (1.969 ms) : 1924, 2014
.   : milestone, 1969,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.38 ms) : 2333, 2427
.   : milestone, 2380,
iast (2.154 ms) : 2095, 2212
.   : milestone, 2154,
iast_GLOBAL (2.198 ms) : 2139, 2257
.   : milestone, 2198,
profiling (1.989 ms) : 1943, 2036
.   : milestone, 1989,
tracing (1.976 ms) : 1931, 2022
.   : milestone, 1976,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.372 ms [2.325 ms, 2.419 ms] 900.816 µs (61.2%)
iast 2.15 ms [2.092 ms, 2.209 ms] 679.47 µs (46.2%)
iast_GLOBAL 2.189 ms [2.13 ms, 2.248 ms] 718.554 µs (48.9%)
profiling 1.997 ms [1.95 ms, 2.044 ms] 526.277 µs (35.8%)
tracing 1.969 ms [1.924 ms, 2.014 ms] 498.003 µs (33.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.38 ms [2.333 ms, 2.427 ms] 908.068 µs (61.7%)
iast 2.154 ms [2.095 ms, 2.212 ms] 681.904 µs (46.3%)
iast_GLOBAL 2.198 ms [2.139 ms, 2.257 ms] 726.096 µs (49.3%)
profiling 1.989 ms [1.943 ms, 2.036 ms] 517.236 µs (35.1%)
tracing 1.976 ms [1.931 ms, 2.022 ms] 504.316 µs (34.3%)

@amarziali amarziali requested a review from bric3 April 29, 2025 12:00
@bric3
Copy link
Contributor

bric3 commented Apr 29, 2025

Did you have a precise use case for having different trie result values?

It's just as a "kill switch" precaution in case something unexpected happens if those classes are excluded.

@amarziali amarziali enabled auto-merge (squash) April 29, 2025 13:36
@amarziali amarziali merged commit 65f56ae into master Apr 29, 2025
456 checks passed
@amarziali amarziali deleted the andrea.marziali/afterburner branch April 29, 2025 13:52
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 29, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 7, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`3.22.2` -> `3.22.3` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.28.0` -> `2.28.1` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.48.2` -> `1.49.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.36` -> `2.31.37` |

---

### Release Notes

<details>
<summary>googleapis/java-logging
(com.google.cloud:google-cloud-logging)</summary>

###
[`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06)

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.56.3
([844f4fa](googleapis/java-logging@844f4fa))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3
([#&#8203;1801](googleapis/java-logging#1801))
([d7aa7bc](googleapis/java-logging@d7aa7bc))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1803](googleapis/java-logging#1803))
([5967ffe](googleapis/java-logging@5967ffe))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1804](googleapis/java-logging#1804))
([e9a27ec](googleapis/java-logging@e9a27ec))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06)

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0
([#&#8203;1841](googleapis/java-datastore#1841))
([ac393e6](googleapis/java-datastore@ac393e6))
- Update googleapis/sdk-platform-java action to v2.57.0
([#&#8203;1842](googleapis/java-datastore#1842))
([0745906](googleapis/java-datastore@0745906))

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0):
1.49.0

### Components

#### Configuration at Runtime

- ✨ Add process tags as list to remote config payload
([#&#8203;8705](DataDog/dd-trace-java#8705) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Continuous Integration Visibility

- 🐛 Add span propagation for Pekko scheduled tasks
([#&#8203;8765](DataDog/dd-trace-java#8765) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Update test.retry_reason to use full name of the feature
([#&#8203;8689](DataDog/dd-trace-java#8689) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🧹 Remove unused TestEventsHandler methods
([#&#8203;8674](DataDog/dd-trace-java#8674) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

#### Dynamic Instrumentation

- 🐛 Fix exclude identifiers normalization
([#&#8203;8742](DataDog/dd-trace-java#8742) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Make source file tracking asynchronous
([#&#8203;8684](DataDog/dd-trace-java#8684) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add scope filtering for symbol extraction
([#&#8203;8676](DataDog/dd-trace-java#8676) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add support for [@&#8203;key](https://github.com/key) and
[@&#8203;value](https://github.com/value) for Map filtering
([#&#8203;8669](DataDog/dd-trace-java#8669) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### Library Injection

- ✨ Add system property to force injection of the tracing
library even though multiple javaagents have been detected
([#&#8203;8697](DataDog/dd-trace-java#8697) -
[@&#8203;cecile75](https://github.com/cecile75))

#### Metrics

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))

#### Profiling

- ✨ Bump ddprof-java to 1.25.1
([#&#8203;8750](DataDog/dd-trace-java#8750) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- 🐛 Remove cleanup-on-shutdown for temporary files
([#&#8203;8746](DataDog/dd-trace-java#8746) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨⚡ Replace a regex-based SMAP parser with a hand-crafted
one
([#&#8203;8730](DataDog/dd-trace-java#8730) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Improve error reporting on profiler startup
([#&#8203;8714](DataDog/dd-trace-java#8714) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Exclude ProxyLeakTask exception from exception profiling
([#&#8203;8666](DataDog/dd-trace-java#8666) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Telemetry

- ✨ Allow dogstatsd port to be configurable with
DD_DOGSTATSD_PORT
([#&#8203;8693](DataDog/dd-trace-java#8693) -
[@&#8203;randomanderson](https://github.com/randomanderson))
- 🐛 Fix appsec.waf.requests telemetry metric
([#&#8203;8644](DataDog/dd-trace-java#8644) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Tracer core

- ✨ Exclude jackson afterburner dynamic classes from
instrumentation
([#&#8203;8747](DataDog/dd-trace-java#8747) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Introduce Java 8 bytecode bridge for instrumentation API
([#&#8203;8736](DataDog/dd-trace-java#8736) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ⚡🧹 Use byte-buddy classes optimized for Java8+
([#&#8203;8735](DataDog/dd-trace-java#8735) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Do not set the hibernate or datanucleus span service name when
disabled
([#&#8203;8727](DataDog/dd-trace-java#8727) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Update bytebuddy and ASM to support JDK 24
([#&#8203;8720](DataDog/dd-trace-java#8720) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- 🐛 Turn off JDK socket support by default
([#&#8203;8715](DataDog/dd-trace-java#8715) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛 Log warning when trace buffer overflow occurs
([#&#8203;8712](DataDog/dd-trace-java#8712) -
[@&#8203;ygree](https://github.com/ygree))
- ✨🧪 Introducing an internal integration name
([#&#8203;8708](DataDog/dd-trace-java#8708) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add process tags to client stats payload
([#&#8203;8704](DataDog/dd-trace-java#8704) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Collect process tags for tracing
([#&#8203;8698](DataDog/dd-trace-java#8698) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Stable Config file: target system properties in
process_arguments and support template variables in YamlParser
([#&#8203;8690](DataDog/dd-trace-java#8690) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨⚡ Use prefix trie for proxy ignores
([#&#8203;8678](DataDog/dd-trace-java#8678) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Allow agent to be automatically injected when running aside
Log4J patch agent
([#&#8203;8648](DataDog/dd-trace-java#8648) -
[@&#8203;paullegranddc](https://github.com/paullegranddc))
- ✨ Use jvmstat for JDKs 9+ programmatically
([#&#8203;8641](DataDog/dd-trace-java#8641) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Tracer internal logging

- 🐛 Delete print line
([#&#8203;8686](DataDog/dd-trace-java#8686) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

### Instrumentations

#### Akka instrumentation

- 🐛 Handle reentrant scope cleanup in Akka/Pekko actor
instrumentations
([#&#8203;8722](DataDog/dd-trace-java#8722) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Apache Spark instrumentation

- ✨ Use OpenLineage root parent information to generate trace
id ([#&#8203;8726](DataDog/dd-trace-java#8726)
- [@&#8203;mobuchowski](https://github.com/mobuchowski))
- ✨ Spark job cancellation no longer marks application as
failed
([#&#8203;8701](DataDog/dd-trace-java#8701) -
[@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd))

#### JDBC instrumentation

- 💡 Add support for sybase tds jdbc driver
([#&#8203;8764](DataDog/dd-trace-java#8764) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Kotlin instrumentation

- 🐛 Take defensive copy of parent scope stack when closing nested
coroutines
([#&#8203;8749](DataDog/dd-trace-java#8749) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Reactor instrumentation

- ✨⚡ Do not inspect reactor context when not needed
([#&#8203;8745](DataDog/dd-trace-java#8745) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants