-
Notifications
You must be signed in to change notification settings - Fork 304
Collect process tags for profiling upload requests #8780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023348
Total [baseline] (10.52 s) : 0, 10519651
Agent [candidate] (1.028 s) : 0, 1028332
Total [candidate] (10.464 s) : 0, 10464156
section appsec
Agent [baseline] (1.163 s) : 0, 1163052
Total [baseline] (10.681 s) : 0, 10681186
Agent [candidate] (1.165 s) : 0, 1164701
Total [candidate] (10.713 s) : 0, 10713330
section iast
Agent [baseline] (1.148 s) : 0, 1148460
Total [baseline] (10.909 s) : 0, 10909227
Agent [candidate] (1.152 s) : 0, 1152036
Total [candidate] (10.861 s) : 0, 10861317
section profiling
Agent [baseline] (1.283 s) : 0, 1282615
Total [baseline] (10.931 s) : 0, 10931218
Agent [candidate] (1.275 s) : 0, 1275104
Total [candidate] (10.866 s) : 0, 10866019
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.909 ms) : 0, 686909
BytebuddyAgent [candidate] (687.861 ms) : 0, 687861
GlobalTracer [baseline] (240.638 ms) : 0, 240638
GlobalTracer [candidate] (241.441 ms) : 0, 241441
AppSec [baseline] (55.447 ms) : 0, 55447
AppSec [candidate] (55.676 ms) : 0, 55676
Debugger [baseline] (7.023 ms) : 0, 7023
Debugger [candidate] (9.259 ms) : 0, 9259
Remote Config [baseline] (708.707 µs) : 0, 709
Remote Config [candidate] (694.63 µs) : 0, 695
Telemetry [baseline] (9.112 ms) : 0, 9112
Telemetry [candidate] (9.788 ms) : 0, 9788
section appsec
BytebuddyAgent [baseline] (702.07 ms) : 0, 702070
BytebuddyAgent [candidate] (702.847 ms) : 0, 702847
GlobalTracer [baseline] (237.071 ms) : 0, 237071
GlobalTracer [candidate] (237.397 ms) : 0, 237397
AppSec [baseline] (175.659 ms) : 0, 175659
AppSec [candidate] (175.786 ms) : 0, 175786
Debugger [baseline] (5.929 ms) : 0, 5929
Debugger [candidate] (6.313 ms) : 0, 6313
Remote Config [baseline] (621.572 µs) : 0, 622
Remote Config [candidate] (622.211 µs) : 0, 622
Telemetry [baseline] (7.391 ms) : 0, 7391
Telemetry [candidate] (7.414 ms) : 0, 7414
IAST [baseline] (21.647 ms) : 0, 21647
IAST [candidate] (21.631 ms) : 0, 21631
section iast
BytebuddyAgent [baseline] (801.545 ms) : 0, 801545
BytebuddyAgent [candidate] (804.622 ms) : 0, 804622
GlobalTracer [baseline] (230.169 ms) : 0, 230169
GlobalTracer [candidate] (231.186 ms) : 0, 231186
AppSec [baseline] (53.679 ms) : 0, 53679
AppSec [candidate] (52.507 ms) : 0, 52507
Debugger [baseline] (5.937 ms) : 0, 5937
Debugger [candidate] (5.941 ms) : 0, 5941
Remote Config [baseline] (608.196 µs) : 0, 608
Remote Config [candidate] (594.26 µs) : 0, 594
Telemetry [baseline] (7.866 ms) : 0, 7866
Telemetry [candidate] (7.83 ms) : 0, 7830
IAST [baseline] (25.208 ms) : 0, 25208
IAST [candidate] (25.876 ms) : 0, 25876
section profiling
BytebuddyAgent [baseline] (677.741 ms) : 0, 677741
BytebuddyAgent [candidate] (673.867 ms) : 0, 673867
GlobalTracer [baseline] (379.643 ms) : 0, 379643
GlobalTracer [candidate] (378.496 ms) : 0, 378496
AppSec [baseline] (54.939 ms) : 0, 54939
AppSec [candidate] (54.21 ms) : 0, 54210
Debugger [baseline] (6.239 ms) : 0, 6239
Debugger [candidate] (6.181 ms) : 0, 6181
Remote Config [baseline] (654.62 µs) : 0, 655
Remote Config [candidate] (654.649 µs) : 0, 655
Telemetry [baseline] (8.275 ms) : 0, 8275
Telemetry [candidate] (8.162 ms) : 0, 8162
ProfilingAgent [baseline] (104.25 ms) : 0, 104250
ProfilingAgent [candidate] (103.188 ms) : 0, 103188
Profiling [baseline] (104.276 ms) : 0, 104276
Profiling [candidate] (103.213 ms) : 0, 103213
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018462
Total [baseline] (8.662 s) : 0, 8662009
Agent [candidate] (1.02 s) : 0, 1020183
Total [candidate] (8.638 s) : 0, 8637652
section iast
Agent [baseline] (1.15 s) : 0, 1149869
Total [baseline] (9.212 s) : 0, 9211752
Agent [candidate] (1.145 s) : 0, 1145240
Total [candidate] (9.217 s) : 0, 9217402
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.147 s) : 0, 1146680
Total [baseline] (9.189 s) : 0, 9188608
Agent [candidate] (1.146 s) : 0, 1145900
Total [candidate] (9.174 s) : 0, 9173882
section iast_TELEMETRY_OFF
Agent [baseline] (1.153 s) : 0, 1153415
Total [baseline] (9.237 s) : 0, 9236539
Agent [candidate] (1.144 s) : 0, 1143858
Total [candidate] (9.182 s) : 0, 9182078
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.54 ms) : 0, 682540
BytebuddyAgent [candidate] (682.651 ms) : 0, 682651
GlobalTracer [baseline] (239.506 ms) : 0, 239506
GlobalTracer [candidate] (240.176 ms) : 0, 240176
AppSec [baseline] (54.885 ms) : 0, 54885
AppSec [candidate] (55.856 ms) : 0, 55856
Debugger [baseline] (7.523 ms) : 0, 7523
Debugger [candidate] (7.589 ms) : 0, 7589
Remote Config [baseline] (684.736 µs) : 0, 685
Remote Config [candidate] (690.142 µs) : 0, 690
Telemetry [baseline] (9.808 ms) : 0, 9808
Telemetry [candidate] (9.719 ms) : 0, 9719
section iast
BytebuddyAgent [baseline] (801.183 ms) : 0, 801183
BytebuddyAgent [candidate] (799.887 ms) : 0, 799887
GlobalTracer [baseline] (231.549 ms) : 0, 231549
GlobalTracer [candidate] (229.753 ms) : 0, 229753
IAST [baseline] (30.338 ms) : 0, 30338
IAST [candidate] (29.805 ms) : 0, 29805
AppSec [baseline] (48.932 ms) : 0, 48932
AppSec [candidate] (48.146 ms) : 0, 48146
Debugger [baseline] (5.898 ms) : 0, 5898
Debugger [candidate] (5.852 ms) : 0, 5852
Remote Config [baseline] (612.322 µs) : 0, 612
Remote Config [candidate] (577.076 µs) : 0, 577
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (7.828 ms) : 0, 7828
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.996 ms) : 0, 799996
BytebuddyAgent [candidate] (800.105 ms) : 0, 800105
GlobalTracer [baseline] (230.299 ms) : 0, 230299
GlobalTracer [candidate] (229.913 ms) : 0, 229913
IAST [baseline] (26.742 ms) : 0, 26742
IAST [candidate] (25.77 ms) : 0, 25770
AppSec [baseline] (51.843 ms) : 0, 51843
AppSec [candidate] (52.358 ms) : 0, 52358
Debugger [baseline] (5.936 ms) : 0, 5936
Debugger [candidate] (5.881 ms) : 0, 5881
Remote Config [baseline] (591.184 µs) : 0, 591
Remote Config [candidate] (584.092 µs) : 0, 584
Telemetry [baseline] (7.952 ms) : 0, 7952
Telemetry [candidate] (7.903 ms) : 0, 7903
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.734 ms) : 0, 804734
BytebuddyAgent [candidate] (797.466 ms) : 0, 797466
GlobalTracer [baseline] (231.839 ms) : 0, 231839
GlobalTracer [candidate] (230.529 ms) : 0, 230529
IAST [baseline] (24.16 ms) : 0, 24160
IAST [candidate] (22.289 ms) : 0, 22289
AppSec [baseline] (54.674 ms) : 0, 54674
AppSec [candidate] (55.844 ms) : 0, 55844
Debugger [baseline] (6.0 ms) : 0, 6000
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (615.272 µs) : 0, 615
Remote Config [candidate] (596.999 µs) : 0, 597
Telemetry [baseline] (7.821 ms) : 0, 7821
Telemetry [candidate] (7.785 ms) : 0, 7785
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (386.231 µs) : 366, 406
. : milestone, 386,
iast (525.606 µs) : 504, 548
. : milestone, 526,
iast_FULL (742.271 µs) : 720, 764
. : milestone, 742,
iast_GLOBAL (575.821 µs) : 552, 599
. : milestone, 576,
iast_HARDCODED_SECRET_DISABLED (520.41 µs) : 499, 542
. : milestone, 520,
iast_INACTIVE (471.184 µs) : 449, 494
. : milestone, 471,
iast_TELEMETRY_OFF (515.549 µs) : 492, 539
. : milestone, 516,
tracing (464.786 µs) : 443, 487
. : milestone, 465,
section candidate
no_agent (387.419 µs) : 366, 409
. : milestone, 387,
iast (532.286 µs) : 509, 556
. : milestone, 532,
iast_FULL (743.105 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (572.799 µs) : 551, 595
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (524.962 µs) : 502, 548
. : milestone, 525,
iast_INACTIVE (472.879 µs) : 451, 495
. : milestone, 473,
iast_TELEMETRY_OFF (511.012 µs) : 488, 534
. : milestone, 511,
tracing (463.684 µs) : 442, 486
. : milestone, 464,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.75 ms) : 1726, 1775
. : milestone, 1750,
appsec_no_iast (1.742 ms) : 1719, 1765
. : milestone, 1742,
code_origins (1.707 ms) : 1681, 1734
. : milestone, 1707,
iast (1.524 ms) : 1500, 1549
. : milestone, 1524,
profiling (1.563 ms) : 1538, 1588
. : milestone, 1563,
tracing (1.501 ms) : 1475, 1526
. : milestone, 1501,
section candidate
no_agent (1.373 ms) : 1352, 1393
. : milestone, 1373,
appsec (1.745 ms) : 1721, 1769
. : milestone, 1745,
appsec_no_iast (1.741 ms) : 1717, 1764
. : milestone, 1741,
code_origins (1.681 ms) : 1653, 1708
. : milestone, 1681,
iast (1.543 ms) : 1519, 1568
. : milestone, 1543,
profiling (1.522 ms) : 1499, 1545
. : milestone, 1522,
tracing (1.53 ms) : 1505, 1554
. : milestone, 1530,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.377 ms) : 2330, 2425
. : milestone, 2377,
iast (2.153 ms) : 2094, 2212
. : milestone, 2153,
iast_GLOBAL (2.202 ms) : 2142, 2262
. : milestone, 2202,
profiling (1.992 ms) : 1945, 2039
. : milestone, 1992,
tracing (1.986 ms) : 1940, 2032
. : milestone, 1986,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.38 ms) : 2333, 2428
. : milestone, 2380,
iast (2.15 ms) : 2090, 2209
. : milestone, 2150,
iast_GLOBAL (2.198 ms) : 2138, 2258
. : milestone, 2198,
profiling (2.027 ms) : 1979, 2076
. : milestone, 2027,
tracing (1.982 ms) : 1936, 2028
. : milestone, 1982,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~e3feadd917, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
appsec (14.797 s) : 14797000, 14797000
. : milestone, 14797000,
iast (18.82 s) : 18820000, 18820000
. : milestone, 18820000,
iast_GLOBAL (17.999 s) : 17999000, 17999000
. : milestone, 17999000,
profiling (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
tracing (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
section candidate
no_agent (15.299 s) : 15299000, 15299000
. : milestone, 15299000,
appsec (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
iast (18.356 s) : 18356000, 18356000
. : milestone, 18356000,
iast_GLOBAL (18.193 s) : 18193000, 18193000
. : milestone, 18193000,
profiling (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
tracing (14.705 s) : 14705000, 14705000
. : milestone, 14705000,
|
e3feadd
to
df276a0
Compare
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
What Does This Do
For service renaming we're surfacing all the process tags to all the payloads.
This PR adds the process tags to the profile upload request on the field
process_tags
(as other products are already doing).The value is a comma separated list of tags encoded as
key:value
. The value is already normalized according to our tag standards.The collection of this tag is today behind a feature flag and not enabled by default
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: AIDM-628