-
Notifications
You must be signed in to change notification settings - Fork 303
[wip] LLM Observability SDK merge branch #8781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gary-huang
wants to merge
1
commit into
master
Choose a base branch
from
gary/llmobs-sdk-merge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+392
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018603
Total [baseline] (10.47 s) : 0, 10469676
Agent [candidate] (1.02 s) : 0, 1020498
Total [candidate] (10.474 s) : 0, 10474459
section appsec
Agent [baseline] (1.173 s) : 0, 1173190
Total [baseline] (10.68 s) : 0, 10679684
Agent [candidate] (1.161 s) : 0, 1161228
Total [candidate] (10.658 s) : 0, 10658239
section iast
Agent [baseline] (1.161 s) : 0, 1160726
Total [baseline] (10.931 s) : 0, 10931331
Agent [candidate] (1.148 s) : 0, 1147677
Total [candidate] (10.87 s) : 0, 10870422
section profiling
Agent [baseline] (1.282 s) : 0, 1282287
Total [baseline] (10.931 s) : 0, 10931448
Agent [candidate] (1.277 s) : 0, 1277363
Total [candidate] (10.939 s) : 0, 10939181
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.006 ms) : 0, 683006
BytebuddyAgent [candidate] (682.702 ms) : 0, 682702
GlobalTracer [baseline] (240.372 ms) : 0, 240372
GlobalTracer [candidate] (240.371 ms) : 0, 240371
AppSec [baseline] (54.905 ms) : 0, 54905
AppSec [candidate] (54.456 ms) : 0, 54456
Debugger [baseline] (6.887 ms) : 0, 6887
Debugger [candidate] (8.984 ms) : 0, 8984
Remote Config [baseline] (710.403 µs) : 0, 710
Remote Config [candidate] (702.323 µs) : 0, 702
Telemetry [baseline] (9.108 ms) : 0, 9108
Telemetry [candidate] (9.735 ms) : 0, 9735
section appsec
BytebuddyAgent [baseline] (708.67 ms) : 0, 708670
BytebuddyAgent [candidate] (700.165 ms) : 0, 700165
GlobalTracer [baseline] (238.897 ms) : 0, 238897
GlobalTracer [candidate] (236.85 ms) : 0, 236850
AppSec [baseline] (176.83 ms) : 0, 176830
AppSec [candidate] (175.975 ms) : 0, 175975
Debugger [baseline] (6.012 ms) : 0, 6012
Debugger [candidate] (5.945 ms) : 0, 5945
Remote Config [baseline] (633.072 µs) : 0, 633
Remote Config [candidate] (629.389 µs) : 0, 629
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (7.4 ms) : 0, 7400
IAST [baseline] (21.656 ms) : 0, 21656
IAST [candidate] (21.524 ms) : 0, 21524
section iast
BytebuddyAgent [baseline] (810.901 ms) : 0, 810901
BytebuddyAgent [candidate] (801.053 ms) : 0, 801053
GlobalTracer [baseline] (232.903 ms) : 0, 232903
GlobalTracer [candidate] (230.699 ms) : 0, 230699
AppSec [baseline] (48.051 ms) : 0, 48051
AppSec [candidate] (50.1 ms) : 0, 50100
Debugger [baseline] (5.946 ms) : 0, 5946
Debugger [candidate] (5.848 ms) : 0, 5848
Remote Config [baseline] (596.565 µs) : 0, 597
Remote Config [candidate] (586.864 µs) : 0, 587
Telemetry [baseline] (7.98 ms) : 0, 7980
Telemetry [candidate] (7.838 ms) : 0, 7838
IAST [baseline] (29.903 ms) : 0, 29903
IAST [candidate] (27.993 ms) : 0, 27993
section profiling
ProfilingAgent [baseline] (104.243 ms) : 0, 104243
ProfilingAgent [candidate] (102.42 ms) : 0, 102420
BytebuddyAgent [baseline] (673.633 ms) : 0, 673633
BytebuddyAgent [candidate] (673.195 ms) : 0, 673195
GlobalTracer [baseline] (375.857 ms) : 0, 375857
GlobalTracer [candidate] (374.231 ms) : 0, 374231
AppSec [baseline] (62.515 ms) : 0, 62515
AppSec [candidate] (61.689 ms) : 0, 61689
Debugger [baseline] (6.327 ms) : 0, 6327
Debugger [candidate] (6.266 ms) : 0, 6266
Remote Config [baseline] (674.559 µs) : 0, 675
Remote Config [candidate] (651.992 µs) : 0, 652
Telemetry [baseline] (8.377 ms) : 0, 8377
Telemetry [candidate] (8.189 ms) : 0, 8189
Profiling [baseline] (104.267 ms) : 0, 104267
Profiling [candidate] (102.444 ms) : 0, 102444
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020217
Total [baseline] (8.638 s) : 0, 8638146
Agent [candidate] (1.036 s) : 0, 1035833
Total [candidate] (8.723 s) : 0, 8722809
section iast
Agent [baseline] (1.149 s) : 0, 1149145
Total [baseline] (9.226 s) : 0, 9225662
Agent [candidate] (1.158 s) : 0, 1157802
Total [candidate] (9.302 s) : 0, 9302361
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.157 s) : 0, 1157019
Total [baseline] (9.191 s) : 0, 9191405
Agent [candidate] (1.157 s) : 0, 1156567
Total [candidate] (9.212 s) : 0, 9212027
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1151775
Total [baseline] (9.224 s) : 0, 9224109
Agent [candidate] (1.153 s) : 0, 1152911
Total [candidate] (9.261 s) : 0, 9260899
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.669 ms) : 0, 681669
BytebuddyAgent [candidate] (691.862 ms) : 0, 691862
GlobalTracer [baseline] (240.219 ms) : 0, 240219
GlobalTracer [candidate] (243.25 ms) : 0, 243250
AppSec [baseline] (54.258 ms) : 0, 54258
AppSec [candidate] (54.985 ms) : 0, 54985
Debugger [baseline] (9.963 ms) : 0, 9963
Debugger [candidate] (10.052 ms) : 0, 10052
Remote Config [baseline] (712.058 µs) : 0, 712
Remote Config [candidate] (699.611 µs) : 0, 700
Telemetry [baseline] (9.859 ms) : 0, 9859
Telemetry [candidate] (11.262 ms) : 0, 11262
section iast
BytebuddyAgent [baseline] (801.819 ms) : 0, 801819
BytebuddyAgent [candidate] (807.146 ms) : 0, 807146
GlobalTracer [baseline] (230.499 ms) : 0, 230499
GlobalTracer [candidate] (232.24 ms) : 0, 232240
IAST [baseline] (28.435 ms) : 0, 28435
IAST [candidate] (26.346 ms) : 0, 26346
AppSec [baseline] (50.448 ms) : 0, 50448
AppSec [candidate] (52.816 ms) : 0, 52816
Debugger [baseline] (5.944 ms) : 0, 5944
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (597.529 µs) : 0, 598
Remote Config [candidate] (628.484 µs) : 0, 628
Telemetry [baseline] (7.937 ms) : 0, 7937
Telemetry [candidate] (8.063 ms) : 0, 8063
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.591 ms) : 0, 807591
BytebuddyAgent [candidate] (807.306 ms) : 0, 807306
GlobalTracer [baseline] (232.303 ms) : 0, 232303
GlobalTracer [candidate] (232.007 ms) : 0, 232007
IAST [baseline] (29.405 ms) : 0, 29405
IAST [candidate] (29.363 ms) : 0, 29363
AppSec [baseline] (49.676 ms) : 0, 49676
AppSec [candidate] (49.752 ms) : 0, 49752
Debugger [baseline] (5.913 ms) : 0, 5913
Debugger [candidate] (5.955 ms) : 0, 5955
Remote Config [baseline] (609.899 µs) : 0, 610
Remote Config [candidate] (610.272 µs) : 0, 610
Telemetry [baseline] (7.923 ms) : 0, 7923
Telemetry [candidate] (8.006 ms) : 0, 8006
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.639 ms) : 0, 803639
BytebuddyAgent [candidate] (804.336 ms) : 0, 804336
GlobalTracer [baseline] (231.484 ms) : 0, 231484
GlobalTracer [candidate] (231.716 ms) : 0, 231716
IAST [baseline] (24.785 ms) : 0, 24785
IAST [candidate] (23.309 ms) : 0, 23309
AppSec [baseline] (53.821 ms) : 0, 53821
AppSec [candidate] (55.423 ms) : 0, 55423
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (610.978 µs) : 0, 611
Remote Config [candidate] (608.4 µs) : 0, 608
Telemetry [baseline] (7.849 ms) : 0, 7849
Telemetry [candidate] (7.839 ms) : 0, 7839
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section baseline
no_agent (378.975 µs) : 359, 399
. : milestone, 379,
iast (518.568 µs) : 497, 541
. : milestone, 519,
iast_FULL (738.358 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (565.946 µs) : 544, 588
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (525.633 µs) : 503, 549
. : milestone, 526,
iast_INACTIVE (471.497 µs) : 448, 495
. : milestone, 471,
iast_TELEMETRY_OFF (521.444 µs) : 498, 545
. : milestone, 521,
tracing (459.971 µs) : 439, 481
. : milestone, 460,
section candidate
no_agent (382.032 µs) : 362, 402
. : milestone, 382,
iast (514.2 µs) : 492, 536
. : milestone, 514,
iast_FULL (732.557 µs) : 711, 754
. : milestone, 733,
iast_GLOBAL (554.738 µs) : 533, 576
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (518.485 µs) : 495, 542
. : milestone, 518,
iast_INACTIVE (461.743 µs) : 441, 483
. : milestone, 462,
iast_TELEMETRY_OFF (507.823 µs) : 484, 531
. : milestone, 508,
tracing (456.824 µs) : 435, 479
. : milestone, 457,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1389
. : milestone, 1369,
appsec (1.746 ms) : 1722, 1770
. : milestone, 1746,
appsec_no_iast (1.745 ms) : 1721, 1768
. : milestone, 1745,
code_origins (1.678 ms) : 1651, 1704
. : milestone, 1678,
iast (1.515 ms) : 1491, 1539
. : milestone, 1515,
profiling (1.553 ms) : 1528, 1578
. : milestone, 1553,
tracing (1.498 ms) : 1474, 1523
. : milestone, 1498,
section candidate
no_agent (1.354 ms) : 1335, 1374
. : milestone, 1354,
appsec (1.749 ms) : 1725, 1773
. : milestone, 1749,
appsec_no_iast (1.732 ms) : 1709, 1756
. : milestone, 1732,
code_origins (1.659 ms) : 1632, 1686
. : milestone, 1659,
iast (1.522 ms) : 1498, 1546
. : milestone, 1522,
profiling (1.516 ms) : 1493, 1540
. : milestone, 1516,
tracing (1.496 ms) : 1472, 1521
. : milestone, 1496,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section baseline
no_agent (15.639 s) : 15639000, 15639000
. : milestone, 15639000,
appsec (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
iast (18.581 s) : 18581000, 18581000
. : milestone, 18581000,
iast_GLOBAL (18.022 s) : 18022000, 18022000
. : milestone, 18022000,
profiling (15.177 s) : 15177000, 15177000
. : milestone, 15177000,
tracing (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
section candidate
no_agent (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
appsec (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
iast (18.523 s) : 18523000, 18523000
. : milestone, 18523000,
iast_GLOBAL (17.73 s) : 17730000, 17730000
. : milestone, 17730000,
profiling (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
tracing (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~2be1b73b0e, baseline=1.50.0-SNAPSHOT~7c80dbede3
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.422 ms) : 2372, 2472
. : milestone, 2422,
iast (2.201 ms) : 2139, 2264
. : milestone, 2201,
iast_GLOBAL (2.248 ms) : 2185, 2312
. : milestone, 2248,
profiling (2.067 ms) : 2015, 2118
. : milestone, 2067,
tracing (2.023 ms) : 1974, 2071
. : milestone, 2023,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.433 ms) : 2383, 2484
. : milestone, 2433,
iast (2.22 ms) : 2157, 2283
. : milestone, 2220,
iast_GLOBAL (2.246 ms) : 2182, 2309
. : milestone, 2246,
profiling (2.076 ms) : 2024, 2128
. : milestone, 2076,
tracing (2.026 ms) : 1977, 2074
. : milestone, 2026,
|
* add APIs for llm obs * add llm message class to support llm spans * follow java convention of naming Id instead of ID * add codeowners
896f40a
to
2be1b73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add APIs for llm obs
add llm message class to support llm spans
follow java convention of naming Id instead of ID
add codeowners
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]