Skip to content

Avoid potential race conditions on collecting process tags #8799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

Avoid potential race conditions on collecting process tags #8799

merged 2 commits into from
May 12, 2025

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner May 12, 2025 07:37
@amarziali amarziali requested a review from mcculls May 12, 2025 07:37
@amarziali amarziali added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels May 12, 2025
@amarziali amarziali requested a review from jpbempel May 12, 2025 07:37
jpbempel
jpbempel reviewed May 12, 2025
View reviewed changes
Copy link
Member

@jpbempel jpbempel left a comment •
edited by amarziali
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset should also be protected with a synchronized because it calls TAGS.putAll() ans TAGS.clear()

They are for testing but it's worth adding. I just did it thanks

@pr-commenter
Copy link

pr-commenter bot commented May 12, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/processtags-improve
git_commit_date 1747025672 1747036347
git_commit_sha 95412e3 ac47a27
release_version 1.50.0-SNAPSHOT~95412e3e2b 1.50.0-SNAPSHOT~ac47a276ef
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747038793 1747038793
ci_job_id 932883064 932883064
ci_pipeline_id 64747820 64747820
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ujqpvmht-project-304-concurrent-0-6dzahr5c 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ujqpvmht-project-304-concurrent-0-6dzahr5c 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024071
Total [baseline] (8.688 s) : 0, 8687824
Agent [candidate] (1.018 s) : 0, 1017722
Total [candidate] (8.645 s) : 0, 8644502
section iast
Agent [baseline] (1.164 s) : 0, 1164089
Total [baseline] (9.251 s) : 0, 9251308
Agent [candidate] (1.149 s) : 0, 1148525
Total [candidate] (9.228 s) : 0, 9227666
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.157 s) : 0, 1156663
Total [baseline] (9.261 s) : 0, 9260905
Agent [candidate] (1.157 s) : 0, 1156918
Total [candidate] (9.193 s) : 0, 9192532
section iast_TELEMETRY_OFF
Agent [baseline] (1.158 s) : 0, 1157844
Total [baseline] (9.245 s) : 0, 9244848
Agent [candidate] (1.152 s) : 0, 1152389
Total [candidate] (9.236 s) : 0, 9236232
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent iast 1.164 s 140.018 ms (13.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.157 s 132.591 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.158 s 133.772 ms (13.1%)
Total tracing 8.688 s -
Total iast 9.251 s 563.484 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.261 s 573.081 ms (6.6%)
Total iast_TELEMETRY_OFF 9.245 s 557.024 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent iast 1.149 s 130.803 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.157 s 139.196 ms (13.7%)
Agent iast_TELEMETRY_OFF 1.152 s 134.667 ms (13.2%)
Total tracing 8.645 s -
Total iast 9.228 s 583.163 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.193 s 548.03 ms (6.3%)
Total iast_TELEMETRY_OFF 9.236 s 591.729 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.539 ms) : 0, 684539
BytebuddyAgent [candidate] (681.199 ms) : 0, 681199
GlobalTracer [baseline] (240.663 ms) : 0, 240663
GlobalTracer [candidate] (239.803 ms) : 0, 239803
AppSec [baseline] (54.662 ms) : 0, 54662
AppSec [candidate] (54.347 ms) : 0, 54347
Debugger [baseline] (9.056 ms) : 0, 9056
Debugger [candidate] (8.25 ms) : 0, 8250
Remote Config [baseline] (720.637 µs) : 0, 721
Remote Config [candidate] (681.44 µs) : 0, 681
Telemetry [baseline] (10.654 ms) : 0, 10654
Telemetry [candidate] (9.792 ms) : 0, 9792
section iast
BytebuddyAgent [baseline] (813.551 ms) : 0, 813551
BytebuddyAgent [candidate] (801.643 ms) : 0, 801643
GlobalTracer [baseline] (232.884 ms) : 0, 232884
GlobalTracer [candidate] (230.426 ms) : 0, 230426
AppSec [baseline] (49.918 ms) : 0, 49918
AppSec [candidate] (51.991 ms) : 0, 51991
Debugger [baseline] (5.96 ms) : 0, 5960
Debugger [candidate] (5.911 ms) : 0, 5911
Remote Config [baseline] (599.599 µs) : 0, 600
Remote Config [candidate] (598.562 µs) : 0, 599
Telemetry [baseline] (8.042 ms) : 0, 8042
Telemetry [candidate] (7.877 ms) : 0, 7877
IAST [baseline] (29.367 ms) : 0, 29367
IAST [candidate] (25.839 ms) : 0, 25839
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.799 ms) : 0, 807799
BytebuddyAgent [candidate] (808.85 ms) : 0, 808850
GlobalTracer [baseline] (231.872 ms) : 0, 231872
GlobalTracer [candidate] (231.173 ms) : 0, 231173
AppSec [baseline] (47.919 ms) : 0, 47919
AppSec [candidate] (51.203 ms) : 0, 51203
Debugger [baseline] (5.933 ms) : 0, 5933
Debugger [candidate] (5.897 ms) : 0, 5897
Remote Config [baseline] (585.278 µs) : 0, 585
Remote Config [candidate] (585.384 µs) : 0, 585
Telemetry [baseline] (7.917 ms) : 0, 7917
Telemetry [candidate] (7.868 ms) : 0, 7868
IAST [baseline] (31.014 ms) : 0, 31014
IAST [candidate] (27.722 ms) : 0, 27722
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (808.445 ms) : 0, 808445
BytebuddyAgent [candidate] (804.592 ms) : 0, 804592
GlobalTracer [baseline] (232.374 ms) : 0, 232374
GlobalTracer [candidate] (231.575 ms) : 0, 231575
AppSec [baseline] (54.484 ms) : 0, 54484
AppSec [candidate] (52.683 ms) : 0, 52683
Debugger [baseline] (6.018 ms) : 0, 6018
Debugger [candidate] (5.973 ms) : 0, 5973
Remote Config [baseline] (623.797 µs) : 0, 624
Remote Config [candidate] (596.369 µs) : 0, 596
Telemetry [baseline] (7.907 ms) : 0, 7907
Telemetry [candidate] (7.784 ms) : 0, 7784
IAST [baseline] (24.227 ms) : 0, 24227
IAST [candidate] (25.502 ms) : 0, 25502
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031672
Total [baseline] (10.504 s) : 0, 10503824
Agent [candidate] (1.019 s) : 0, 1019227
Total [candidate] (10.463 s) : 0, 10462586
section appsec
Agent [baseline] (1.166 s) : 0, 1166111
Total [baseline] (10.718 s) : 0, 10717816
Agent [candidate] (1.163 s) : 0, 1162597
Total [candidate] (10.705 s) : 0, 10705297
section iast
Agent [baseline] (1.149 s) : 0, 1149230
Total [baseline] (10.873 s) : 0, 10873213
Agent [candidate] (1.159 s) : 0, 1158771
Total [candidate] (11.0 s) : 0, 11000318
section profiling
Agent [baseline] (1.281 s) : 0, 1281235
Total [baseline] (10.832 s) : 0, 10832411
Agent [candidate] (1.287 s) : 0, 1287386
Total [candidate] (10.959 s) : 0, 10958870
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.032 s -
Agent appsec 1.166 s 134.439 ms (13.0%)
Agent iast 1.149 s 117.558 ms (11.4%)
Agent profiling 1.281 s 249.563 ms (24.2%)
Total tracing 10.504 s -
Total appsec 10.718 s 213.992 ms (2.0%)
Total iast 10.873 s 369.389 ms (3.5%)
Total profiling 10.832 s 328.587 ms (3.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent appsec 1.163 s 143.37 ms (14.1%)
Agent iast 1.159 s 139.545 ms (13.7%)
Agent profiling 1.287 s 268.159 ms (26.3%)
Total tracing 10.463 s -
Total appsec 10.705 s 242.711 ms (2.3%)
Total iast 11.0 s 537.732 ms (5.1%)
Total profiling 10.959 s 496.284 ms (4.7%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.145 ms) : 0, 691145
BytebuddyAgent [candidate] (681.588 ms) : 0, 681588
GlobalTracer [baseline] (242.084 ms) : 0, 242084
GlobalTracer [candidate] (239.628 ms) : 0, 239628
AppSec [baseline] (55.736 ms) : 0, 55736
AppSec [candidate] (54.308 ms) : 0, 54308
Debugger [baseline] (8.317 ms) : 0, 8317
Debugger [candidate] (9.813 ms) : 0, 9813
Remote Config [baseline] (696.002 µs) : 0, 696
Remote Config [candidate] (682.856 µs) : 0, 683
Telemetry [baseline] (9.868 ms) : 0, 9868
Telemetry [candidate] (9.58 ms) : 0, 9580
section appsec
BytebuddyAgent [baseline] (704.518 ms) : 0, 704518
BytebuddyAgent [candidate] (700.333 ms) : 0, 700333
GlobalTracer [baseline] (237.049 ms) : 0, 237049
GlobalTracer [candidate] (237.356 ms) : 0, 237356
IAST [baseline] (21.748 ms) : 0, 21748
IAST [candidate] (22.096 ms) : 0, 22096
AppSec [baseline] (175.621 ms) : 0, 175621
AppSec [candidate] (175.894 ms) : 0, 175894
Debugger [baseline] (5.957 ms) : 0, 5957
Debugger [candidate] (5.984 ms) : 0, 5984
Remote Config [baseline] (624.436 µs) : 0, 624
Remote Config [candidate] (641.781 µs) : 0, 642
Telemetry [baseline] (7.782 ms) : 0, 7782
Telemetry [candidate] (7.784 ms) : 0, 7784
section iast
BytebuddyAgent [baseline] (802.385 ms) : 0, 802385
BytebuddyAgent [candidate] (809.334 ms) : 0, 809334
GlobalTracer [baseline] (230.499 ms) : 0, 230499
GlobalTracer [candidate] (232.182 ms) : 0, 232182
IAST [baseline] (28.348 ms) : 0, 28348
IAST [candidate] (28.474 ms) : 0, 28474
AppSec [baseline] (49.326 ms) : 0, 49326
AppSec [candidate] (49.862 ms) : 0, 49862
Debugger [baseline] (5.922 ms) : 0, 5922
Debugger [candidate] (5.921 ms) : 0, 5921
Remote Config [baseline] (590.334 µs) : 0, 590
Remote Config [candidate] (593.575 µs) : 0, 594
Telemetry [baseline] (7.86 ms) : 0, 7860
Telemetry [candidate] (7.944 ms) : 0, 7944
section profiling
BytebuddyAgent [baseline] (673.682 ms) : 0, 673682
BytebuddyAgent [candidate] (676.427 ms) : 0, 676427
GlobalTracer [baseline] (378.566 ms) : 0, 378566
GlobalTracer [candidate] (379.465 ms) : 0, 379465
AppSec [baseline] (54.5 ms) : 0, 54500
AppSec [candidate] (54.072 ms) : 0, 54072
Debugger [baseline] (6.138 ms) : 0, 6138
Debugger [candidate] (6.2 ms) : 0, 6200
Remote Config [baseline] (656.494 µs) : 0, 656
Remote Config [candidate] (671.572 µs) : 0, 672
Telemetry [baseline] (8.063 ms) : 0, 8063
Telemetry [candidate] (8.24 ms) : 0, 8240
ProfilingAgent [baseline] (108.978 ms) : 0, 108978
ProfilingAgent [candidate] (111.394 ms) : 0, 111394
Profiling [baseline] (109.003 ms) : 0, 109003
Profiling [candidate] (111.419 ms) : 0, 111419
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-12T08:03:52 2025-05-12T08:11:37
git_branch master andrea.marziali/processtags-improve
git_commit_date 1747025672 1747036347
git_commit_sha 95412e3 ac47a27
release_version 1.50.0-SNAPSHOT~95412e3e2b 1.50.0-SNAPSHOT~ac47a276ef
start_time 2025-05-12T08:03:38 2025-05-12T08:11:23
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747037894 1747037894
ci_job_id 932883065 932883065
ci_pipeline_id 64747820 64747820
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ecrswmq9-project-304-concurrent-0-yxd4enmm 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ecrswmq9-project-304-concurrent-0-yxd4enmm 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (386.24 µs) : 366, 406
.   : milestone, 386,
iast (513.1 µs) : 490, 536
.   : milestone, 513,
iast_FULL (727.987 µs) : 706, 750
.   : milestone, 728,
iast_GLOBAL (573.667 µs) : 551, 597
.   : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (507.005 µs) : 485, 529
.   : milestone, 507,
iast_INACTIVE (465.285 µs) : 442, 488
.   : milestone, 465,
iast_TELEMETRY_OFF (514.615 µs) : 492, 537
.   : milestone, 515,
tracing (463.526 µs) : 441, 486
.   : milestone, 464,
section candidate
no_agent (379.835 µs) : 360, 399
.   : milestone, 380,
iast (508.626 µs) : 487, 530
.   : milestone, 509,
iast_FULL (734.584 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (559.981 µs) : 538, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (520.773 µs) : 498, 543
.   : milestone, 521,
iast_INACTIVE (466.841 µs) : 444, 490
.   : milestone, 467,
iast_TELEMETRY_OFF (503.545 µs) : 481, 527
.   : milestone, 504,
tracing (460.216 µs) : 438, 483
.   : milestone, 460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 386.24 µs [366.433 µs, 406.048 µs] -
iast 513.1 µs [490.033 µs, 536.168 µs] 126.86 µs (32.8%)
iast_FULL 727.987 µs [706.175 µs, 749.798 µs] 341.746 µs (88.5%)
iast_GLOBAL 573.667 µs [550.833 µs, 596.501 µs] 187.427 µs (48.5%)
iast_HARDCODED_SECRET_DISABLED 507.005 µs [485.333 µs, 528.678 µs] 120.765 µs (31.3%)
iast_INACTIVE 465.285 µs [442.397 µs, 488.173 µs] 79.045 µs (20.5%)
iast_TELEMETRY_OFF 514.615 µs [491.863 µs, 537.367 µs] 128.374 µs (33.2%)
tracing 463.526 µs [440.623 µs, 486.429 µs] 77.285 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.835 µs [360.243 µs, 399.427 µs] -
iast 508.626 µs [486.842 µs, 530.41 µs] 128.791 µs (33.9%)
iast_FULL 734.584 µs [712.535 µs, 756.633 µs] 354.749 µs (93.4%)
iast_GLOBAL 559.981 µs [538.436 µs, 581.526 µs] 180.146 µs (47.4%)
iast_HARDCODED_SECRET_DISABLED 520.773 µs [498.074 µs, 543.472 µs] 140.938 µs (37.1%)
iast_INACTIVE 466.841 µs [443.779 µs, 489.902 µs] 87.006 µs (22.9%)
iast_TELEMETRY_OFF 503.545 µs [480.54 µs, 526.551 µs] 123.711 µs (32.6%)
tracing 460.216 µs [437.861 µs, 482.572 µs] 80.382 µs (21.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1383
.   : milestone, 1364,
appsec (1.738 ms) : 1714, 1761
.   : milestone, 1738,
appsec_no_iast (1.713 ms) : 1690, 1737
.   : milestone, 1713,
code_origins (1.662 ms) : 1636, 1688
.   : milestone, 1662,
iast (1.514 ms) : 1490, 1537
.   : milestone, 1514,
profiling (1.543 ms) : 1519, 1567
.   : milestone, 1543,
tracing (1.473 ms) : 1450, 1495
.   : milestone, 1473,
section candidate
no_agent (1.356 ms) : 1336, 1376
.   : milestone, 1356,
appsec (1.738 ms) : 1715, 1762
.   : milestone, 1738,
appsec_no_iast (1.713 ms) : 1690, 1737
.   : milestone, 1713,
code_origins (1.666 ms) : 1639, 1692
.   : milestone, 1666,
iast (1.521 ms) : 1497, 1546
.   : milestone, 1521,
profiling (1.522 ms) : 1498, 1547
.   : milestone, 1522,
tracing (1.494 ms) : 1471, 1518
.   : milestone, 1494,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.344 ms, 1.383 ms] -
appsec 1.738 ms [1.714 ms, 1.761 ms] 374.222 µs (27.4%)
appsec_no_iast 1.713 ms [1.69 ms, 1.737 ms] 349.904 µs (25.7%)
code_origins 1.662 ms [1.636 ms, 1.688 ms] 298.704 µs (21.9%)
iast 1.514 ms [1.49 ms, 1.537 ms] 150.015 µs (11.0%)
profiling 1.543 ms [1.519 ms, 1.567 ms] 179.488 µs (13.2%)
tracing 1.473 ms [1.45 ms, 1.495 ms] 109.112 µs (8.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.336 ms, 1.376 ms] -
appsec 1.738 ms [1.715 ms, 1.762 ms] 382.619 µs (28.2%)
appsec_no_iast 1.713 ms [1.69 ms, 1.737 ms] 357.254 µs (26.3%)
code_origins 1.666 ms [1.639 ms, 1.692 ms] 309.954 µs (22.9%)
iast 1.521 ms [1.497 ms, 1.546 ms] 165.469 µs (12.2%)
profiling 1.522 ms [1.498 ms, 1.547 ms] 166.577 µs (12.3%)
tracing 1.494 ms [1.471 ms, 1.518 ms] 138.663 µs (10.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/processtags-improve
git_commit_date 1747025672 1747036347
git_commit_sha 95412e3 ac47a27
release_version 1.50.0-SNAPSHOT~95412e3e2b 1.50.0-SNAPSHOT~ac47a276ef
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1747038415 1747038415
ci_job_id 932883066 932883066
ci_pipeline_id 64747820 64747820
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ujqpvmht-project-304-concurrent-1-2wxriazs 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ujqpvmht-project-304-concurrent-1-2wxriazs 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.018 s) : 15018000, 15018000
.   : milestone, 15018000,
appsec (14.9 s) : 14900000, 14900000
.   : milestone, 14900000,
iast (18.955 s) : 18955000, 18955000
.   : milestone, 18955000,
iast_GLOBAL (18.097 s) : 18097000, 18097000
.   : milestone, 18097000,
profiling (15.177 s) : 15177000, 15177000
.   : milestone, 15177000,
tracing (15.048 s) : 15048000, 15048000
.   : milestone, 15048000,
section candidate
no_agent (15.205 s) : 15205000, 15205000
.   : milestone, 15205000,
appsec (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
iast (19.137 s) : 19137000, 19137000
.   : milestone, 19137000,
iast_GLOBAL (18.027 s) : 18027000, 18027000
.   : milestone, 18027000,
profiling (15.743 s) : 15743000, 15743000
.   : milestone, 15743000,
tracing (15.297 s) : 15297000, 15297000
.   : milestone, 15297000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.018 s [15.018 s, 15.018 s] -
appsec 14.9 s [14.9 s, 14.9 s] -118.0 ms (-0.8%)
iast 18.955 s [18.955 s, 18.955 s] 3.937 s (26.2%)
iast_GLOBAL 18.097 s [18.097 s, 18.097 s] 3.079 s (20.5%)
profiling 15.177 s [15.177 s, 15.177 s] 159.0 ms (1.1%)
tracing 15.048 s [15.048 s, 15.048 s] 30.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.205 s [15.205 s, 15.205 s] -
appsec 15.101 s [15.101 s, 15.101 s] -104.0 ms (-0.7%)
iast 19.137 s [19.137 s, 19.137 s] 3.932 s (25.9%)
iast_GLOBAL 18.027 s [18.027 s, 18.027 s] 2.822 s (18.6%)
profiling 15.743 s [15.743 s, 15.743 s] 538.0 ms (3.5%)
tracing 15.297 s [15.297 s, 15.297 s] 92.0 ms (0.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ac47a276ef, baseline=1.50.0-SNAPSHOT~95412e3e2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.399 ms) : 2349, 2448
.   : milestone, 2399,
iast (2.185 ms) : 2123, 2247
.   : milestone, 2185,
iast_GLOBAL (2.233 ms) : 2171, 2296
.   : milestone, 2233,
profiling (2.03 ms) : 1979, 2080
.   : milestone, 2030,
tracing (2.019 ms) : 1971, 2067
.   : milestone, 2019,
section candidate
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.4 ms) : 2351, 2449
.   : milestone, 2400,
iast (2.185 ms) : 2123, 2247
.   : milestone, 2185,
iast_GLOBAL (2.226 ms) : 2164, 2289
.   : milestone, 2226,
profiling (2.052 ms) : 2001, 2102
.   : milestone, 2052,
tracing (2.009 ms) : 1961, 2058
.   : milestone, 2009,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.399 ms [2.349 ms, 2.448 ms] 927.217 µs (63.0%)
iast 2.185 ms [2.123 ms, 2.247 ms] 713.597 µs (48.5%)
iast_GLOBAL 2.233 ms [2.171 ms, 2.296 ms] 762.065 µs (51.8%)
profiling 2.03 ms [1.979 ms, 2.08 ms] 558.466 µs (38.0%)
tracing 2.019 ms [1.971 ms, 2.067 ms] 547.727 µs (37.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.4 ms [2.351 ms, 2.449 ms] 923.62 µs (62.5%)
iast 2.185 ms [2.123 ms, 2.247 ms] 708.013 µs (47.9%)
iast_GLOBAL 2.226 ms [2.164 ms, 2.289 ms] 749.729 µs (50.8%)
profiling 2.052 ms [2.001 ms, 2.102 ms] 574.958 µs (38.9%)
tracing 2.009 ms [1.961 ms, 2.058 ms] 532.742 µs (36.1%)

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Was this helpful? Give us feedback!

@amarziali amarziali merged commit a4b7a7b into master May 12, 2025
582 of 588 checks passed
@amarziali amarziali deleted the andrea.marziali/processtags-improve branch May 12, 2025 15:07
@github-actions github-actions bot added this to the 1.50.0 milestone May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @jpbempel