Skip to content

Add process tags to crashtracking #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add process tags to crashtracking #8810

wants to merge 2 commits into from
+40 −10

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented May 13, 2025 •
edited
Loading

What Does This Do

Adds Process tags (when enabled) to crashtracking payload. Depending on the payload the tags are:

  • logs payload -> /process_tags
  • telemetry payload -> /application/process_tags

The tags are encoded as a comma separated list. Each entry, key:value

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner May 13, 2025 09:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali requested a review from raphaelgavache May 13, 2025 09:19
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/crashtracking
git_commit_date 1747405134 1747404924
git_commit_sha c5a98d6 7cd016e
release_version 1.50.0-SNAPSHOT~c5a98d6714 1.50.0-SNAPSHOT~7cd016e3d1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747407463 1747407463
ci_job_id 941800754 941800754
ci_pipeline_id 65330288 65330288
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-nwp2usjz-project-304-concurrent-0-ku5arwce 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-nwp2usjz-project-304-concurrent-0-ku5arwce 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 59 metrics, 11 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Remote Config worse
[+16.722µs; +61.285µs] or [+2.905%; +10.648%]		 614.558µs 575.554µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~7cd016e3d1, baseline=1.50.0-SNAPSHOT~c5a98d6714

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023134
Total [baseline] (8.678 s) : 0, 8677715
Agent [candidate] (1.028 s) : 0, 1027598
Total [candidate] (8.641 s) : 0, 8640686
section iast
Agent [baseline] (1.148 s) : 0, 1148230
Total [baseline] (9.214 s) : 0, 9213681
Agent [candidate] (1.149 s) : 0, 1149032
Total [candidate] (9.231 s) : 0, 9231204
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.149 s) : 0, 1149255
Total [baseline] (9.225 s) : 0, 9225320
Agent [candidate] (1.149 s) : 0, 1148627
Total [candidate] (9.205 s) : 0, 9204803
section iast_TELEMETRY_OFF
Agent [baseline] (1.141 s) : 0, 1141441
Total [baseline] (9.221 s) : 0, 9221132
Agent [candidate] (1.15 s) : 0, 1150197
Total [candidate] (9.271 s) : 0, 9271416
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent iast 1.148 s 125.096 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.149 s 126.121 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.141 s 118.307 ms (11.6%)
Total tracing 8.678 s -
Total iast 9.214 s 535.966 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.225 s 547.606 ms (6.3%)
Total iast_TELEMETRY_OFF 9.221 s 543.418 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.028 s -
Agent iast 1.149 s 121.434 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.149 s 121.029 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.15 s 122.6 ms (11.9%)
Total tracing 8.641 s -
Total iast 9.231 s 590.518 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.205 s 564.117 ms (6.5%)
Total iast_TELEMETRY_OFF 9.271 s 630.73 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~7cd016e3d1, baseline=1.50.0-SNAPSHOT~c5a98d6714

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.889 ms) : 0, 683889
BytebuddyAgent [candidate] (687.408 ms) : 0, 687408
GlobalTracer [baseline] (240.015 ms) : 0, 240015
GlobalTracer [candidate] (241.301 ms) : 0, 241301
AppSec [baseline] (54.699 ms) : 0, 54699
AppSec [candidate] (55.487 ms) : 0, 55487
Debugger [baseline] (9.762 ms) : 0, 9762
Debugger [candidate] (9.061 ms) : 0, 9061
Remote Config [baseline] (700.364 µs) : 0, 700
Remote Config [candidate] (718.69 µs) : 0, 719
Telemetry [baseline] (10.562 ms) : 0, 10562
Telemetry [candidate] (9.907 ms) : 0, 9907
section iast
BytebuddyAgent [baseline] (801.013 ms) : 0, 801013
BytebuddyAgent [candidate] (802.187 ms) : 0, 802187
GlobalTracer [baseline] (230.806 ms) : 0, 230806
GlobalTracer [candidate] (230.098 ms) : 0, 230098
IAST [baseline] (28.387 ms) : 0, 28387
IAST [candidate] (30.054 ms) : 0, 30054
AppSec [baseline] (50.207 ms) : 0, 50207
AppSec [candidate] (48.743 ms) : 0, 48743
Debugger [baseline] (5.941 ms) : 0, 5941
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (596.995 µs) : 0, 597
Remote Config [candidate] (615.668 µs) : 0, 616
Telemetry [baseline] (7.854 ms) : 0, 7854
Telemetry [candidate] (7.98 ms) : 0, 7980
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.89 ms) : 0, 801890
BytebuddyAgent [candidate] (801.371 ms) : 0, 801371
GlobalTracer [baseline] (231.081 ms) : 0, 231081
GlobalTracer [candidate] (230.592 ms) : 0, 230592
IAST [baseline] (28.966 ms) : 0, 28966
IAST [candidate] (28.548 ms) : 0, 28548
AppSec [baseline] (49.455 ms) : 0, 49455
AppSec [candidate] (50.209 ms) : 0, 50209
Debugger [baseline] (5.891 ms) : 0, 5891
Debugger [candidate] (5.903 ms) : 0, 5903
Remote Config [baseline] (600.074 µs) : 0, 600
Remote Config [candidate] (614.36 µs) : 0, 614
Telemetry [baseline] (7.932 ms) : 0, 7932
Telemetry [candidate] (7.921 ms) : 0, 7921
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.871 ms) : 0, 795871
BytebuddyAgent [candidate] (802.506 ms) : 0, 802506
GlobalTracer [baseline] (229.813 ms) : 0, 229813
GlobalTracer [candidate] (231.151 ms) : 0, 231151
IAST [baseline] (23.043 ms) : 0, 23043
IAST [candidate] (22.504 ms) : 0, 22504
AppSec [baseline] (55.152 ms) : 0, 55152
AppSec [candidate] (56.114 ms) : 0, 56114
Debugger [baseline] (5.819 ms) : 0, 5819
Debugger [candidate] (5.966 ms) : 0, 5966
Remote Config [baseline] (575.554 µs) : 0, 576
Remote Config [candidate] (614.558 µs) : 0, 615
Telemetry [baseline] (7.632 ms) : 0, 7632
Telemetry [candidate] (7.774 ms) : 0, 7774
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~7cd016e3d1, baseline=1.50.0-SNAPSHOT~c5a98d6714

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020122
Total [baseline] (10.482 s) : 0, 10482385
Agent [candidate] (1.019 s) : 0, 1019454
Total [candidate] (10.485 s) : 0, 10484875
section appsec
Agent [baseline] (1.161 s) : 0, 1161230
Total [baseline] (10.688 s) : 0, 10687719
Agent [candidate] (1.16 s) : 0, 1160136
Total [candidate] (10.688 s) : 0, 10687980
section iast
Agent [baseline] (1.147 s) : 0, 1146866
Total [baseline] (10.917 s) : 0, 10916641
Agent [candidate] (1.158 s) : 0, 1158047
Total [candidate] (10.99 s) : 0, 10990285
section profiling
Agent [baseline] (1.298 s) : 0, 1298234
Total [baseline] (10.906 s) : 0, 10906305
Agent [candidate] (1.279 s) : 0, 1278620
Total [candidate] (10.811 s) : 0, 10811304
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.161 s 141.108 ms (13.8%)
Agent iast 1.147 s 126.745 ms (12.4%)
Agent profiling 1.298 s 278.113 ms (27.3%)
Total tracing 10.482 s -
Total appsec 10.688 s 205.334 ms (2.0%)
Total iast 10.917 s 434.257 ms (4.1%)
Total profiling 10.906 s 423.921 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent appsec 1.16 s 140.682 ms (13.8%)
Agent iast 1.158 s 138.593 ms (13.6%)
Agent profiling 1.279 s 259.166 ms (25.4%)
Total tracing 10.485 s -
Total appsec 10.688 s 203.105 ms (1.9%)
Total iast 10.99 s 505.41 ms (4.8%)
Total profiling 10.811 s 326.43 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~7cd016e3d1, baseline=1.50.0-SNAPSHOT~c5a98d6714

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.038 ms) : 0, 683038
BytebuddyAgent [candidate] (681.9 ms) : 0, 681900
GlobalTracer [baseline] (240.165 ms) : 0, 240165
GlobalTracer [candidate] (240.125 ms) : 0, 240125
AppSec [baseline] (54.411 ms) : 0, 54411
AppSec [candidate] (54.999 ms) : 0, 54999
Debugger [baseline] (9.127 ms) : 0, 9127
Debugger [candidate] (7.6 ms) : 0, 7600
Remote Config [baseline] (708.131 µs) : 0, 708
Remote Config [candidate] (698.155 µs) : 0, 698
Telemetry [baseline] (9.116 ms) : 0, 9116
Telemetry [candidate] (10.562 ms) : 0, 10562
section appsec
BytebuddyAgent [baseline] (700.417 ms) : 0, 700417
BytebuddyAgent [candidate] (699.399 ms) : 0, 699399
GlobalTracer [baseline] (236.497 ms) : 0, 236497
GlobalTracer [candidate] (236.571 ms) : 0, 236571
IAST [baseline] (21.629 ms) : 0, 21629
IAST [candidate] (21.637 ms) : 0, 21637
AppSec [baseline] (175.663 ms) : 0, 175663
AppSec [candidate] (175.902 ms) : 0, 175902
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (625.132 µs) : 0, 625
Remote Config [candidate] (621.254 µs) : 0, 621
Telemetry [baseline] (7.762 ms) : 0, 7762
Telemetry [candidate] (7.398 ms) : 0, 7398
section iast
BytebuddyAgent [baseline] (799.423 ms) : 0, 799423
BytebuddyAgent [candidate] (808.889 ms) : 0, 808889
GlobalTracer [baseline] (231.369 ms) : 0, 231369
GlobalTracer [candidate] (232.143 ms) : 0, 232143
IAST [baseline] (30.142 ms) : 0, 30142
IAST [candidate] (31.002 ms) : 0, 31002
AppSec [baseline] (48.267 ms) : 0, 48267
AppSec [candidate] (47.873 ms) : 0, 47873
Debugger [baseline] (5.856 ms) : 0, 5856
Debugger [candidate] (5.926 ms) : 0, 5926
Remote Config [baseline] (582.937 µs) : 0, 583
Remote Config [candidate] (587.797 µs) : 0, 588
Telemetry [baseline] (7.824 ms) : 0, 7824
Telemetry [candidate] (7.972 ms) : 0, 7972
section profiling
BytebuddyAgent [baseline] (682.172 ms) : 0, 682172
BytebuddyAgent [candidate] (673.93 ms) : 0, 673930
GlobalTracer [baseline] (381.536 ms) : 0, 381536
GlobalTracer [candidate] (374.08 ms) : 0, 374080
AppSec [baseline] (62.819 ms) : 0, 62819
AppSec [candidate] (61.829 ms) : 0, 61829
Debugger [baseline] (6.416 ms) : 0, 6416
Debugger [candidate] (6.288 ms) : 0, 6288
Remote Config [baseline] (685.394 µs) : 0, 685
Remote Config [candidate] (654.848 µs) : 0, 655
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (8.199 ms) : 0, 8199
ProfilingAgent [baseline] (104.876 ms) : 0, 104876
ProfilingAgent [candidate] (102.929 ms) : 0, 102929
Profiling [baseline] (104.9 ms) : 0, 104900
Profiling [candidate] (102.953 ms) : 0, 102953
Loading

Load

Dacapo

@amarziali amarziali requested review from jbachorik and MattAlp May 13, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelgavache raphaelgavache raphaelgavache approved these changes

@jbachorik jbachorik Awaiting requested review from jbachorik

@MattAlp MattAlp Awaiting requested review from MattAlp

Assignees
No one assigned
Labels
comp: crash tracking Crash tracking type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @raphaelgavache