-
Notifications
You must be signed in to change notification settings - Fork 303
HTTP response schema collection and data classification #8840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sezen-datadog
wants to merge
2
commits into
master
Choose a base branch
from
sezen.leblay/APPSEC-57259
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
891c835
to
a2809f5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 55 metrics, 14 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021383
Total [baseline] (8.645 s) : 0, 8645455
Agent [candidate] (1.022 s) : 0, 1022279
Total [candidate] (8.649 s) : 0, 8649492
section iast
Agent [baseline] (1.149 s) : 0, 1149025
Total [baseline] (9.23 s) : 0, 9230124
Agent [candidate] (1.147 s) : 0, 1147069
Total [candidate] (9.216 s) : 0, 9216155
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.156 s) : 0, 1156024
Total [baseline] (9.187 s) : 0, 9187411
Agent [candidate] (1.15 s) : 0, 1149703
Total [candidate] (9.205 s) : 0, 9204734
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1152330
Total [baseline] (9.232 s) : 0, 9231510
Agent [candidate] (1.144 s) : 0, 1143706
Total [candidate] (9.247 s) : 0, 9246942
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.114 ms) : 0, 683114
BytebuddyAgent [candidate] (682.686 ms) : 0, 682686
GlobalTracer [baseline] (240.562 ms) : 0, 240562
GlobalTracer [candidate] (239.788 ms) : 0, 239788
AppSec [baseline] (54.383 ms) : 0, 54383
AppSec [candidate] (55.099 ms) : 0, 55099
Debugger [baseline] (7.725 ms) : 0, 7725
Debugger [candidate] (9.881 ms) : 0, 9881
Remote Config [baseline] (706.907 µs) : 0, 707
Remote Config [candidate] (744.948 µs) : 0, 745
Telemetry [baseline] (11.318 ms) : 0, 11318
Telemetry [candidate] (10.469 ms) : 0, 10469
section iast
BytebuddyAgent [baseline] (803.044 ms) : 0, 803044
BytebuddyAgent [candidate] (800.488 ms) : 0, 800488
GlobalTracer [baseline] (230.048 ms) : 0, 230048
GlobalTracer [candidate] (229.917 ms) : 0, 229917
IAST [baseline] (28.848 ms) : 0, 28848
IAST [candidate] (29.125 ms) : 0, 29125
AppSec [baseline] (48.44 ms) : 0, 48440
AppSec [candidate] (49.682 ms) : 0, 49682
Debugger [baseline] (5.852 ms) : 0, 5852
Debugger [candidate] (5.884 ms) : 0, 5884
Remote Config [baseline] (592.868 µs) : 0, 593
Remote Config [candidate] (596.475 µs) : 0, 596
Telemetry [baseline] (7.847 ms) : 0, 7847
Telemetry [candidate] (7.909 ms) : 0, 7909
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.98 ms) : 0, 806980
BytebuddyAgent [candidate] (802.461 ms) : 0, 802461
GlobalTracer [baseline] (231.74 ms) : 0, 231740
GlobalTracer [candidate] (230.846 ms) : 0, 230846
IAST [baseline] (27.85 ms) : 0, 27850
IAST [candidate] (29.019 ms) : 0, 29019
AppSec [baseline] (51.254 ms) : 0, 51254
AppSec [candidate] (48.736 ms) : 0, 48736
Debugger [baseline] (5.915 ms) : 0, 5915
Debugger [candidate] (5.875 ms) : 0, 5875
Remote Config [baseline] (612.519 µs) : 0, 613
Remote Config [candidate] (594.085 µs) : 0, 594
Telemetry [baseline] (7.941 ms) : 0, 7941
Telemetry [candidate] (7.904 ms) : 0, 7904
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.933 ms) : 0, 804933
BytebuddyAgent [candidate] (797.257 ms) : 0, 797257
GlobalTracer [baseline] (231.268 ms) : 0, 231268
GlobalTracer [candidate] (230.296 ms) : 0, 230296
IAST [baseline] (22.233 ms) : 0, 22233
IAST [candidate] (24.664 ms) : 0, 24664
AppSec [baseline] (55.963 ms) : 0, 55963
AppSec [candidate] (53.755 ms) : 0, 53755
Debugger [baseline] (5.931 ms) : 0, 5931
Debugger [candidate] (5.891 ms) : 0, 5891
Remote Config [baseline] (603.321 µs) : 0, 603
Remote Config [candidate] (596.947 µs) : 0, 597
Telemetry [baseline] (7.771 ms) : 0, 7771
Telemetry [candidate] (7.757 ms) : 0, 7757
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018635
Total [baseline] (10.449 s) : 0, 10449129
Agent [candidate] (1.022 s) : 0, 1021622
Total [candidate] (10.558 s) : 0, 10557913
section appsec
Agent [baseline] (1.165 s) : 0, 1164590
Total [baseline] (10.669 s) : 0, 10668733
Agent [candidate] (1.162 s) : 0, 1161542
Total [candidate] (10.655 s) : 0, 10654930
section iast
Agent [baseline] (1.149 s) : 0, 1148540
Total [baseline] (10.963 s) : 0, 10963077
Agent [candidate] (1.166 s) : 0, 1165887
Total [candidate] (10.997 s) : 0, 10997163
section profiling
Agent [baseline] (1.293 s) : 0, 1293112
Total [baseline] (10.955 s) : 0, 10955316
Agent [candidate] (1.277 s) : 0, 1277019
Total [candidate] (10.846 s) : 0, 10846483
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.886 ms) : 0, 681886
BytebuddyAgent [candidate] (682.775 ms) : 0, 682775
GlobalTracer [baseline] (239.818 ms) : 0, 239818
GlobalTracer [candidate] (240.746 ms) : 0, 240746
AppSec [baseline] (54.348 ms) : 0, 54348
AppSec [candidate] (55.0 ms) : 0, 55000
Debugger [baseline] (8.503 ms) : 0, 8503
Debugger [candidate] (8.273 ms) : 0, 8273
Remote Config [baseline] (700.537 µs) : 0, 701
Remote Config [candidate] (756.431 µs) : 0, 756
Telemetry [baseline] (9.863 ms) : 0, 9863
Telemetry [candidate] (10.413 ms) : 0, 10413
section appsec
BytebuddyAgent [baseline] (702.81 ms) : 0, 702810
BytebuddyAgent [candidate] (700.288 ms) : 0, 700288
GlobalTracer [baseline] (237.091 ms) : 0, 237091
GlobalTracer [candidate] (236.809 ms) : 0, 236809
IAST [baseline] (21.692 ms) : 0, 21692
IAST [candidate] (21.658 ms) : 0, 21658
AppSec [baseline] (176.288 ms) : 0, 176288
AppSec [candidate] (176.105 ms) : 0, 176105
Debugger [baseline] (5.945 ms) : 0, 5945
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (624.232 µs) : 0, 624
Remote Config [candidate] (628.509 µs) : 0, 629
Telemetry [baseline] (7.418 ms) : 0, 7418
Telemetry [candidate] (7.392 ms) : 0, 7392
section iast
BytebuddyAgent [baseline] (801.266 ms) : 0, 801266
BytebuddyAgent [candidate] (813.885 ms) : 0, 813885
GlobalTracer [baseline] (230.675 ms) : 0, 230675
GlobalTracer [candidate] (233.508 ms) : 0, 233508
IAST [baseline] (29.081 ms) : 0, 29081
IAST [candidate] (29.723 ms) : 0, 29723
AppSec [baseline] (49.684 ms) : 0, 49684
AppSec [candidate] (50.364 ms) : 0, 50364
Debugger [baseline] (5.872 ms) : 0, 5872
Debugger [candidate] (5.947 ms) : 0, 5947
Remote Config [baseline] (583.837 µs) : 0, 584
Remote Config [candidate] (620.728 µs) : 0, 621
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (8.043 ms) : 0, 8043
section profiling
BytebuddyAgent [baseline] (682.076 ms) : 0, 682076
BytebuddyAgent [candidate] (672.424 ms) : 0, 672424
GlobalTracer [baseline] (378.285 ms) : 0, 378285
GlobalTracer [candidate] (373.953 ms) : 0, 373953
AppSec [baseline] (62.181 ms) : 0, 62181
AppSec [candidate] (62.479 ms) : 0, 62479
Debugger [baseline] (6.294 ms) : 0, 6294
Debugger [candidate] (6.215 ms) : 0, 6215
Remote Config [baseline] (656.867 µs) : 0, 657
Remote Config [candidate] (655.522 µs) : 0, 656
Telemetry [baseline] (8.257 ms) : 0, 8257
Telemetry [candidate] (8.185 ms) : 0, 8185
ProfilingAgent [baseline] (104.068 ms) : 0, 104068
ProfilingAgent [candidate] (102.465 ms) : 0, 102465
Profiling [baseline] (104.093 ms) : 0, 104093
Profiling [candidate] (102.489 ms) : 0, 102489
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1351, 1390
. : milestone, 1370,
appsec (1.742 ms) : 1719, 1766
. : milestone, 1742,
appsec_no_iast (1.747 ms) : 1723, 1771
. : milestone, 1747,
code_origins (1.673 ms) : 1646, 1700
. : milestone, 1673,
iast (1.528 ms) : 1503, 1552
. : milestone, 1528,
profiling (1.558 ms) : 1533, 1583
. : milestone, 1558,
tracing (1.489 ms) : 1464, 1514
. : milestone, 1489,
section candidate
no_agent (1.353 ms) : 1333, 1373
. : milestone, 1353,
appsec (1.73 ms) : 1707, 1753
. : milestone, 1730,
appsec_no_iast (1.712 ms) : 1689, 1736
. : milestone, 1712,
code_origins (1.663 ms) : 1635, 1690
. : milestone, 1663,
iast (1.504 ms) : 1479, 1528
. : milestone, 1504,
profiling (1.559 ms) : 1534, 1584
. : milestone, 1559,
tracing (1.493 ms) : 1469, 1517
. : milestone, 1493,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section baseline
no_agent (384.188 µs) : 365, 404
. : milestone, 384,
iast (521.001 µs) : 497, 545
. : milestone, 521,
iast_FULL (737.593 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (569.494 µs) : 547, 592
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (515.104 µs) : 492, 538
. : milestone, 515,
iast_INACTIVE (463.767 µs) : 441, 486
. : milestone, 464,
iast_TELEMETRY_OFF (504.606 µs) : 481, 528
. : milestone, 505,
tracing (468.048 µs) : 445, 491
. : milestone, 468,
section candidate
no_agent (383.034 µs) : 362, 404
. : milestone, 383,
iast (512.24 µs) : 489, 535
. : milestone, 512,
iast_FULL (736.263 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (562.323 µs) : 540, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (509.96 µs) : 487, 533
. : milestone, 510,
iast_INACTIVE (463.579 µs) : 441, 486
. : milestone, 464,
iast_TELEMETRY_OFF (505.311 µs) : 483, 527
. : milestone, 505,
tracing (458.278 µs) : 436, 480
. : milestone, 458,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section baseline
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (15.266 s) : 15266000, 15266000
. : milestone, 15266000,
iast (19.059 s) : 19059000, 19059000
. : milestone, 19059000,
iast_GLOBAL (18.354 s) : 18354000, 18354000
. : milestone, 18354000,
profiling (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
tracing (15.211 s) : 15211000, 15211000
. : milestone, 15211000,
section candidate
no_agent (15.611 s) : 15611000, 15611000
. : milestone, 15611000,
appsec (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
iast (18.857 s) : 18857000, 18857000
. : milestone, 18857000,
iast_GLOBAL (18.105 s) : 18105000, 18105000
. : milestone, 18105000,
profiling (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
tracing (15.246 s) : 15246000, 15246000
. : milestone, 15246000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~4d7fed2982, baseline=1.50.0-SNAPSHOT~c5a98d6714
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.408 ms) : 2359, 2458
. : milestone, 2408,
iast (2.195 ms) : 2133, 2257
. : milestone, 2195,
iast_GLOBAL (2.244 ms) : 2181, 2307
. : milestone, 2244,
profiling (2.066 ms) : 2015, 2117
. : milestone, 2066,
tracing (2.004 ms) : 1956, 2052
. : milestone, 2004,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.421 ms) : 2371, 2470
. : milestone, 2421,
iast (2.194 ms) : 2132, 2256
. : milestone, 2194,
iast_GLOBAL (2.237 ms) : 2174, 2300
. : milestone, 2237,
profiling (2.529 ms) : 2346, 2711
. : milestone, 2529,
tracing (2.021 ms) : 1973, 2070
. : milestone, 2021,
|
a2809f5
to
113c0d2
Compare
ff2d34f
to
4d7fed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57259